Bramus Van Damme (Gerrit)

unread,

Dec 9, 2024, 11:21:18 AM12/9/24

to Chromium LUCI CQ, AyeAye, Alex Rudenko, Rune Lillesveen, Philip Pfaffe, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Alex Rudenko, Bramus Van Damme, Philip Pfaffe and Rune Lillesveen

Message from Bramus Van Damme

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Bramus Van Damme
Philip Pfaffe
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

Dec 10, 2024, 3:02:54 AM12/10/24

to Bramus Van Damme, Rune Lillesveen, Chromium LUCI CQ, AyeAye, Alex Rudenko, Philip Pfaffe, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Alex Rudenko, Bramus Van Damme and Philip Pfaffe

Rune Lillesveen voted and added 2 comments

Votes added by Rune Lillesveen

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Rune Lillesveen . resolved

core/animation and core/css lgtm

Will this be useful in practice because applying @starting-style also to the end point of the interpolation will often effectively stop the interpolation from happening?

Commit Message

Line 9, Patchset 4 (Latest):

This is the backend CL to allow authors to force an element into its
starting style. It uses a probe that tracks which elements are forced

Rune Lillesveen . unresolved

I think "force elements to always have @starting-style rules applied" is more accurate?

An element's "starting style" is the style that is calculated for the starting point of the interpolation. This change will apply @starting-style to all other styles too, right?

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Bramus Van Damme
Philip Pfaffe

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

Dec 10, 2024, 3:09:14 AM12/10/24

to Bramus Van Damme, Rune Lillesveen, Chromium LUCI CQ, AyeAye, Philip Pfaffe, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Bramus Van Damme and Philip Pfaffe

Alex Rudenko voted and added 2 comments

Votes added by Alex Rudenko

Code-Review

+1

2 comments

File third_party/blink/public/devtools_protocol/browser_protocol.pdl

Line 2242, Patchset 4 (Latest): # Ensures that the given node is in its starting-style state

Alex Rudenko . unresolved

```suggestion
  # Ensures that the given node is in its starting-style state.
```

Line 2247, Patchset 4 (Latest): # Boolean indidcating if this is on or off

Alex Rudenko . unresolved

```suggestion
      # Boolean indidcating if this is on or off.
```

Open in Gerrit

Related details

Attention is currently required from:

Bramus Van Damme
Philip Pfaffe

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Philip Pfaffe (Gerrit)

unread,

Dec 10, 2024, 3:35:44 AM12/10/24

to Bramus Van Damme, Alex Rudenko, Rune Lillesveen, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Bramus Van Damme

Philip Pfaffe voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bramus Van Damme

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Bramus Van Damme (Gerrit)

unread,

Dec 10, 2024, 5:48:19 AM12/10/24

to Philip Pfaffe, Alex Rudenko, Rune Lillesveen, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Alex Rudenko, Philip Pfaffe and Rune Lillesveen

Bramus Van Damme added 4 comments

Patchset-level comments

File-level comment, Patchset 4:

Rune Lillesveen . resolved

core/animation and core/css lgtm
Will this be useful in practice because applying @starting-style also to the end point of the interpolation will often effectively stop the interpolation from happening?

Bramus Van Damme

Yes, this is to allow authors to debug the `@starting-style` styles in DevTools.

I am currently working on a Design Doc on how this would look, but the idea is authors can toggle this on and off. When on, they can manipulate the `@starting-style` styles to see what they are doing. They toggling it back off, the interpolation will run.

Commit Message

Line 9, Patchset 4:This is the backend CL to allow authors to force an element into its


starting style. It uses a probe that tracks which elements are forced

Rune Lillesveen . resolved

I think "force elements to always have @starting-style rules applied" is more accurate?
An element's "starting style" is the style that is calculated for the starting point of the interpolation. This change will apply @starting-style to all other styles too, right?

Bramus Van Damme

Good callout to more correctly word this. I have updated the description.

File third_party/blink/public/devtools_protocol/browser_protocol.pdl

Line 2242, Patchset 4: # Ensures that the given node is in its starting-style state

Alex Rudenko . resolved

```suggestion
  # Ensures that the given node is in its starting-style state.
```

Bramus Van Damme

Done

Line 2247, Patchset 4: # Boolean indidcating if this is on or off

Alex Rudenko . resolved

```suggestion
      # Boolean indidcating if this is on or off.
```

Bramus Van Damme

Done

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Philip Pfaffe
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

Dec 10, 2024, 9:00:32 AM12/10/24

to Bramus Van Damme, Philip Pfaffe, Rune Lillesveen, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Bramus Van Damme, Philip Pfaffe and Rune Lillesveen

Alex Rudenko voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bramus Van Damme
Philip Pfaffe
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

Dec 10, 2024, 12:29:00 PM12/10/24

to Bramus Van Damme, Rune Lillesveen, Alex Rudenko, Philip Pfaffe, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Bramus Van Damme and Philip Pfaffe

Rune Lillesveen voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bramus Van Damme
Philip Pfaffe

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Bramus Van Damme (Gerrit)

unread,

Dec 10, 2024, 5:26:30 PM12/10/24

to Rune Lillesveen, Alex Rudenko, Philip Pfaffe, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Philip Pfaffe

Bramus Van Damme voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Philip Pfaffe

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Bramus Van Damme (Gerrit)

unread,

Dec 10, 2024, 5:45:15 PM12/10/24

to Rune Lillesveen, Alex Rudenko, Philip Pfaffe, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Alex Rudenko, Philip Pfaffe and Rune Lillesveen

Bramus Van Damme added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Bramus Van Damme . resolved

The build failed and mentioned I had to rebase. If y’all could +1 this again, that’d be great.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Philip Pfaffe
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

Dec 11, 2024, 2:46:35 AM12/11/24

to Bramus Van Damme, Rune Lillesveen, Alex Rudenko, Philip Pfaffe, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Alex Rudenko, Bramus Van Damme and Philip Pfaffe

Rune Lillesveen added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Bramus Van Damme . resolved

The build failed and mentioned I had to rebase. If y’all could +1 this again, that’d be great.

Rune Lillesveen

Looks like you need to fix some tests first.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko

Bramus Van Damme
Philip Pfaffe

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Bramus Van Damme (Gerrit)

unread,

Dec 12, 2024, 2:28:02 AM12/12/24

to Rune Lillesveen, Alex Rudenko, Philip Pfaffe, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Alex Rudenko and Philip Pfaffe

Bramus Van Damme added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Bramus Van Damme . resolved

All tests should be fixed now.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Philip Pfaffe

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

Dec 12, 2024, 3:44:59 AM12/12/24

to Bramus Van Damme, Rune Lillesveen, Alex Rudenko, Philip Pfaffe, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Alex Rudenko, Bramus Van Damme and Philip Pfaffe

Rune Lillesveen added 1 comment

File third_party/blink/renderer/core/css/element_rule_collector.cc

Line 494, Patchset 11 (Latest): mode_ != SelectorChecker::kResolvingStyle) &&

Rune Lillesveen . unresolved

Why are you re-introducing this check? The CL description doesn't state that you're reverting the behavior of always showing @starting-style rules as matched?

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Bramus Van Damme
Philip Pfaffe

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Bramus Van Damme (Gerrit)

unread,

Dec 12, 2024, 4:01:49 PM12/12/24

to Rune Lillesveen, Alex Rudenko, Philip Pfaffe, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Alex Rudenko, Philip Pfaffe and Rune Lillesveen

Bramus Van Damme added 1 comment

File third_party/blink/renderer/core/css/element_rule_collector.cc

Line 494, Patchset 11 (Latest): mode_ != SelectorChecker::kResolvingStyle) &&

Rune Lillesveen . unresolved

Why are you re-introducing this check? The CL description doesn't state that you're reverting the behavior of always showing @starting-style rules as matched?

Bramus Van Damme

The idea is that these styles only need to be gathered when the author is actively inspecting + debugging the `@starting-style` rules from DevTools. They can (~ will be able to) to that by triggering a `forceStartingStyle` on the inspected element.

This indeed rolls back part of the previous CL that unconditionally gathered the `@starting-style` rules. By only conditionally collecting them, DevTools will only show those rules when the element has `forceStartingStyle` set to `true`.

Would you recommend to continue gathering the `@starting-style` rules by default, and have DevTools conditionally show them instead? A possible concern with that approach is that the traffic over CPD would include `@starting-style` rules for every inspected element, even when the author is not even inspecting that state.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Philip Pfaffe
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

Dec 13, 2024, 2:33:56 AM12/13/24

to Bramus Van Damme, Rune Lillesveen, Alex Rudenko, Philip Pfaffe, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Alex Rudenko, Bramus Van Damme and Philip Pfaffe

Rune Lillesveen voted and added 1 comment

Votes added by Rune Lillesveen

Code-Review

+1

1 comment

File third_party/blink/renderer/core/css/element_rule_collector.cc

Line 494, Patchset 11 (Latest): mode_ != SelectorChecker::kResolvingStyle) &&

Rune Lillesveen . resolved

Why are you re-introducing this check? The CL description doesn't state that you're reverting the behavior of always showing @starting-style rules as matched?

Bramus Van Damme

The idea is that these styles only need to be gathered when the author is actively inspecting + debugging the `@starting-style` rules from DevTools. They can (~ will be able to) to that by triggering a `forceStartingStyle` on the inspected element.
This indeed rolls back part of the previous CL that unconditionally gathered the `@starting-style` rules. By only conditionally collecting them, DevTools will only show those rules when the element has `forceStartingStyle` set to `true`.
Would you recommend to continue gathering the `@starting-style` rules by default, and have DevTools conditionally show them instead? A possible concern with that approach is that the traffic over CPD would include `@starting-style` rules for every inspected element, even when the author is not even inspecting that state.

Rune Lillesveen

The idea is that these styles only need to be gathered when the author is actively inspecting + debugging the `@starting-style` rules from DevTools. They can (~ will be able to) to that by triggering a `forceStartingStyle` on the inspected element.
This indeed rolls back part of the previous CL that unconditionally gathered the `@starting-style` rules. By only conditionally collecting them, DevTools will only show those rules when the element has `forceStartingStyle` set to `true`.

Thn that should be called out in the commit message.

Would you recommend to continue gathering the `@starting-style` rules by default, and have DevTools conditionally show them instead? A possible concern with that approach is that the traffic over CPD would include `@starting-style` rules for every inspected element, even when the author is not even inspecting that state.

I just wanted to make sure that's the intent and that's also clear to the devtools reviewers here.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko

Bramus Van Damme
Philip Pfaffe

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

Dec 13, 2024, 4:36:24 AM12/13/24

to Bramus Van Damme, Rune Lillesveen, Philip Pfaffe, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Bramus Van Damme and Philip Pfaffe

Alex Rudenko voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bramus Van Damme
Philip Pfaffe

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Bramus Van Damme (Gerrit)

unread,

Dec 13, 2024, 5:19:30 AM12/13/24

to Alex Rudenko, Rune Lillesveen, Philip Pfaffe, Chromium LUCI CQ, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention needed from Philip Pfaffe

Bramus Van Damme voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Philip Pfaffe

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Dec 13, 2024, 6:21:48 AM12/13/24

to Bramus Van Damme, Alex Rudenko, Rune Lillesveen, Philip Pfaffe, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

11 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Add forceStartingStyle command to DevTools

This is the backend CL to allow authors to force an element having its
`@starting-style` rules applied on top of all other styles.

It uses a probe that tracks which elements are forced into that state,
which is taken into account when collecting and applying styles.

This is a follow-up CL to [^1] which unconditionally collected
`@starting-style` rules. Gathering `@starting-style` rules now happens
conditionally again (effectively reverting part of that previous CL).

By conditionally collecting those rules, DevTools will only show them


when the element has `forceStartingStyle` set to `true`.

[^1]: https://chromium-review.googlesource.com/c/chromium/src/+/5916506

R=alexr...@chromium.org, fut...@chromium.org, pfa...@chromium.org

Bug: 40278160

Change-Id: I63b69207a0c7bcfa38b2f4546679dd952bc6b3f4

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077714

Reviewed-by: Alex Rudenko <alexr...@chromium.org>

Reviewed-by: Rune Lillesveen <fut...@chromium.org>

Commit-Queue: Bramus Van Damme <bra...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1395863}

Files:

M third_party/blink/public/devtools_protocol/browser_protocol.pdl
M third_party/blink/renderer/core/animation/css/css_animations.cc
M third_party/blink/renderer/core/css/element_rule_collector.cc
M third_party/blink/renderer/core/css/resolver/style_resolver_test.cc
M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
M third_party/blink/renderer/core/inspector/inspector_css_agent.h
M third_party/blink/renderer/core/probe/core_probes.json5
M third_party/blink/renderer/core/probe/core_probes.pidl
M third_party/blink/web_tests/inspector-protocol/css/starting-style/1-expected.txt
M third_party/blink/web_tests/inspector-protocol/css/starting-style/2-expected.txt
M third_party/blink/web_tests/inspector-protocol/css/starting-style/3-expected.txt
M third_party/blink/web_tests/inspector-protocol/css/starting-style/4-expected.txt
M third_party/blink/web_tests/inspector-protocol/css/starting-style/5-expected.txt
M third_party/blink/web_tests/inspector-protocol/css/starting-style/6-expected.txt
M third_party/blink/web_tests/inspector-protocol/css/starting-style/7-expected.txt
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/1-expected.txt
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/1.js
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/2-expected.txt
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/2.js
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/3-expected.txt
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/3.js
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/4-expected.txt
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/4.js
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/5-expected.txt
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/5.js
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/6-expected.txt
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/6.js
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/7-expected.txt
A third_party/blink/web_tests/inspector-protocol/css/starting-style/forced/7.js

Change size: L

Delta: 29 files changed, 749 insertions(+), 57 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Rune Lillesveen, +1 by Alex Rudenko

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Hernández Marcos Jose Alberto (Gerrit)

unread,

12:38 AM (7 hours ago) 12:38 AM

to Chromium LUCI CQ, Bramus Van Damme, Alex Rudenko, Rune Lillesveen, Philip Pfaffe, AyeAye, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Hernández Marcos Jose Alberto added 1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Hernández Marcos Jose Alberto . resolved

Yes

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Add forceStartingStyle command to DevTools [chromium/src : main]

Bramus Van Damme (Gerrit)

Message from Bramus Van Damme

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen voted and added 2 comments

Votes added by Rune Lillesveen

2 comments

Related details

Alex Rudenko (Gerrit)

Alex Rudenko voted and added 2 comments

Votes added by Alex Rudenko

2 comments

Related details

Philip Pfaffe (Gerrit)

Philip Pfaffe voted Code-Review+1

Related details

Bramus Van Damme (Gerrit)

Bramus Van Damme added 4 comments

Related details

Alex Rudenko (Gerrit)

Alex Rudenko voted Code-Review+1

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen voted Code-Review+1

Related details

Bramus Van Damme (Gerrit)

Bramus Van Damme voted Commit-Queue+2

Related details

Bramus Van Damme (Gerrit)

Bramus Van Damme added 1 comment

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen added 1 comment

Related details

Bramus Van Damme (Gerrit)

Bramus Van Damme added 1 comment

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen added 1 comment

Related details

Bramus Van Damme (Gerrit)

Bramus Van Damme added 1 comment

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen voted and added 1 comment

Votes added by Rune Lillesveen

1 comment

Related details

Alex Rudenko (Gerrit)

Alex Rudenko voted Code-Review+1

Related details

Bramus Van Damme (Gerrit)

Bramus Van Damme voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Unreviewed changes

Change information

Hernández Marcos Jose Alberto (Gerrit)

Hernández Marcos Jose Alberto added 1 comment

Related details