Add SelectivePermissionInterventionIssue support to frontend [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Josh Karlin (Gerrit)
Mar 2, 2026, 8:13:15 AM (yesterday) Mar 2
to Josh Karlin, Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Josh Karlin added 1 comment![]( "Open in Gerrit")
File front_end/panels/issues/AffectedSelectivePermissionsInterventionView.ts
Line 109, Patchset 6:
const stackTraceTranslated = await stackTraceModel.createFromProtocolRuntime(stackTrace, async frames => {Simon Zünd . resolved
Josh KarlinThe right way is `Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance().createStackTraceFromProtocolRuntime`. The second argument is a mapping function that should implement source mapping :)
Excellent, thank you! Done.
Related details
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Josh Karlin (Gerrit)
Mar 2, 2026, 9:31:11 AM (yesterday) Mar 2
to Josh Karlin, Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Josh Karlin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
12:26 AM (14 hours ago) 12:26 AM
to Josh Karlin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Josh Karlin
Simon Zünd voted and added 2 comments![]( "Open in Gerrit")
Votes added by Simon Zünd
| Code-Review | +1 |
2 comments
Patchset-level comments
Simon Zünd . resolved
lgtm % wrong URL, thanks
File front_end/ui/components/markdown_view/MarkdownLinksMap.ts
Related details
Attention is currently required from:
- Josh Karlin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
12:27 AM (14 hours ago) 12:27 AM
to Josh Karlin, Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Josh Karlin and Philip Pfaffe
Simon Zünd voted and added 1 comment![]( "Open in Gerrit")
Votes added by Simon Zünd
| Code-Review | +0 |
1 comment
Patchset-level comments
Attention is currently required from:
- Josh Karlin
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
5:07 AM (10 hours ago) 5:07 AM
to Josh Karlin, Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Josh Karlin
Philip Pfaffe voted and added 2 comments![]( "Open in Gerrit")
Votes added by Philip Pfaffe
| Code-Review | +1 |
2 comments
Patchset-level comments
Philip Pfaffe . resolved
LGTM, just one suggestion :)
Thanks!
File front_end/panels/issues/AffectedSelectivePermissionsInterventionView.ts
Line 44, Patchset 10 (Latest):
#appendDetails(Philip Pfaffe . unresolved
Do you think it'd be possible to render the contents here with lit? AffectedResourcesView itself isn't migrated yet, but maybe we could at least take care of the contents here already if that's not too much work, WDYT?
Related details
Attention is currently required from:
- Josh Karlin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Josh Karlin (Gerrit)
11:03 AM (4 hours ago) 11:03 AM
to Josh Karlin, Philip Pfaffe, Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe and Simon Zünd
Josh Karlin added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File front_end/panels/issues/AffectedSelectivePermissionsInterventionView.ts
Line 44, Patchset 10:
#appendDetails(Philip Pfaffe . unresolved
Do you think it'd be possible to render the contents here with lit? AffectedResourcesView itself isn't migrated yet, but maybe we could at least take care of the contents here already if that's not too much work, WDYT?
Josh Karlin
How is this?
File front_end/ui/components/markdown_view/MarkdownLinksMap.ts
This is the googler link. Should be crbug.com probably.
Attention is currently required from:
- Philip Pfaffe
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages