[RPP] Force tab targetType in trace_app [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Connor Clark (Gerrit)
Oct 13, 2025, 5:03:04 PMOct 13
to Paul Irish, devtools-rev...@chromium.org
Attention needed from Paul Irish
Connor Clark voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Oct 13, 2025, 5:28:22 PMOct 13
to Connor Clark, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Connor Clark
Paul Irish voted![]( "Open in Gerrit")
Attention is currently required from:
- Connor Clark
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Oct 13, 2025, 7:01:17 PMOct 13
to Paul Irish, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Paul Irish
Connor Clark voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Oct 13, 2025, 7:03:00 PMOct 13
to Connor Clark, Paul Irish, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[RPP] Force tab targetType in trace_app
This is required for some features to work, such as linkifying the
console source location in the bottom-up / call-tree tables. The short
summary is that `primaryPageTarget()` does not return the correct target
for rehydrated connections unless the first / root target is of type
tab, which breaks linkifying.
Bug: 427455148
Change-Id: I62e656d9f92892d8b051e0c7b98c663b432499d1
Reviewed-by: Paul Irish <paul...@chromium.org>
Auto-Submit: Connor Clark <cja...@chromium.org>
Commit-Queue: Connor Clark <cja...@chromium.org>
Files:
- M front_end/entrypoints/inspector_main/InspectorMain.ts
Change size: XS
Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Irish
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
5:02 AM (19 hours ago) 5:02 AM
to Connor Clark, Devtools-frontend LUCI CQ, Paul Irish, devtools-rev...@chromium.org
Simon Zünd added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Simon Zünd . unresolved
qq: I was looking at this code today due to some `ConnectionTransport` refactoring, and I was wondering where the `trace_app` entrypoint wires up "InspectorMain"?
Ideally the trace_app has it's own early runnable that calls `initMainConnection`, rather then hijacking inspector_main.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages