Also filtering requests by scope when invalidate network log view. [devtools/devtools-frontend : main]

Danil Somsikov (Gerrit)

unread,

Apr 5, 2023, 5:18:59 AM4/5/23

to Wolfgang Beyer, almuthan...@chromium.org, devtools-rev...@chromium.org

Attention is currently required from: Wolfgang Beyer.

Danil Somsikov would like Wolfgang Beyer to review this change.

Also filtering requests by scope when invalidate network log view.

Bug: 1417112
Change-Id: I539aa85ac19a6a1bba38102ff244228e1b150db9
---
M front_end/panels/network/NetworkLogView.ts
M test/unittests/front_end/panels/network/NetworkLogView_test.ts
2 files changed, 12 insertions(+), 5 deletions(-)

To view, visit change 4402895. To unsubscribe, or for help writing mail filters, visit settings.

Danil Somsikov (Gerrit)

unread,

Apr 5, 2023, 5:19:00 AM4/5/23

to almuthan...@chromium.org, devtools-rev...@chromium.org, Wolfgang Beyer

Attention is currently required from: Wolfgang Beyer.

Patch set 2:Auto-Submit +1Commit-Queue +1

View Change

To view, visit change 4402895. To unsubscribe, or for help writing mail filters, visit settings.

Wolfgang Beyer (Gerrit)

unread,

Apr 5, 2023, 9:15:15 AM4/5/23

to Danil Somsikov, almuthan...@chromium.org, devtools-rev...@chromium.org, Devtools-frontend LUCI CQ

Attention is currently required from: Danil Somsikov.

Patch set 4:Code-Review +1Commit-Queue +2

View Change

1 comment:

Patchset:
- Patch Set #4:
  LGTM

To view, visit change 4402895. To unsubscribe, or for help writing mail filters, visit settings.

Devtools-frontend LUCI CQ (Gerrit)

unread,

Apr 5, 2023, 10:09:13 AM4/5/23

to Danil Somsikov, almuthan...@chromium.org, devtools-rev...@chromium.org, Wolfgang Beyer

Devtools-frontend LUCI CQ submitted this change.

View Change

Approvals:
  Danil Somsikov: Send CL to CQ automatically after approval
  Wolfgang Beyer: Looks good to me; Commit

Also filtering requests by scope when invalidate network log view.

Bug: 1417112
Change-Id: I539aa85ac19a6a1bba38102ff244228e1b150db9

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4402895
Reviewed-by: Wolfgang Beyer <wo...@chromium.org>
Commit-Queue: Wolfgang Beyer <wo...@chromium.org>
Auto-Submit: Danil Somsikov <d...@chromium.org>


---
M front_end/panels/network/NetworkLogView.ts
M test/unittests/front_end/panels/network/NetworkLogView_test.ts
2 files changed, 12 insertions(+), 5 deletions(-)

To view, visit change 4402895. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward