Fix custom ESLint rules loading on Windows [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Alex Rudenko (Gerrit)

unread,
Jul 3, 2026, 8:57:48 AM (yesterday) Jul 3
to Karim El Harim, Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alex Rudenko, Karim El Harim and Simon Zünd

Alex Rudenko voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
  • Karim El Harim
  • Simon Zünd
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I95938fcf4a5379e2800b4ed3d277fb24ed232784
Gerrit-Change-Number: 8032650
Gerrit-PatchSet: 1
Gerrit-Owner: Karim El Harim <karime...@gmail.com>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Attention: Karim El Harim <karime...@gmail.com>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Attention: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Jul 2026 12:57:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
Jul 3, 2026, 9:00:23 AM (yesterday) Jul 3
to Karim El Harim, Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Karim El Harim and Simon Zünd

Alex Rudenko added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alex Rudenko . resolved

Thanks for the CL. I think it would be helpful if you could unchain the CL from the elements fix as these can land independently.

Open in Gerrit

Related details

Attention is currently required from:
  • Karim El Harim
  • Simon Zünd
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I95938fcf4a5379e2800b4ed3d277fb24ed232784
Gerrit-Change-Number: 8032650
Gerrit-PatchSet: 1
Gerrit-Owner: Karim El Harim <karime...@gmail.com>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Attention: Karim El Harim <karime...@gmail.com>
Gerrit-Attention: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Jul 2026 13:00:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Karim El Harim (Gerrit)

unread,
Jul 3, 2026, 9:56:56 AM (yesterday) Jul 3
to Simon Zünd, Alex Rudenko, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Simon Zünd

Message from Karim El Harim

Done, rebased onto main so this CL no longer depends on the elements fix.

Open in Gerrit

Related details

Attention is currently required from:
  • Simon Zünd
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I95938fcf4a5379e2800b4ed3d277fb24ed232784
Gerrit-Change-Number: 8032650
Gerrit-PatchSet: 2
Gerrit-Attention: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Jul 2026 13:56:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages