[protocol] Nuke ParallelConnection/proxyConnection [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Simon Zünd (Gerrit)

unread,
Nov 4, 2025, 12:30:39 AM (3 days ago) Nov 4
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I5d42635f64e9c51af6a990f774a61bdc50119b7a
Gerrit-Change-Number: 7106262
Gerrit-PatchSet: 3
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 05:30:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
Nov 4, 2025, 1:43:23 AM (3 days ago) Nov 4
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd

Alex Rudenko voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Simon Zünd
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I5d42635f64e9c51af6a990f774a61bdc50119b7a
Gerrit-Change-Number: 7106262
Gerrit-PatchSet: 4
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 06:43:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Simon Zünd (Gerrit)

unread,
Nov 4, 2025, 1:46:22 AM (3 days ago) Nov 4
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Simon Zünd voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I5d42635f64e9c51af6a990f774a61bdc50119b7a
Gerrit-Change-Number: 7106262
Gerrit-PatchSet: 4
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Tue, 04 Nov 2025 06:46:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
Nov 4, 2025, 1:47:46 AM (3 days ago) Nov 4
to Simon Zünd, Alex Rudenko, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
[protocol] Nuke ParallelConnection/proxyConnection

LH and recorder player both use the new CDPConnection interface so
we can safely remove the parallel connection now.
Bug: 453469270
Change-Id: I5d42635f64e9c51af6a990f774a61bdc50119b7a
Commit-Queue: Simon Zünd <szu...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Files:
  • M front_end/core/protocol_client/InspectorBackend.ts
  • M front_end/core/sdk/ChildTargetManager.ts
  • M front_end/core/sdk/Connections.ts
  • M front_end/services/puppeteer/PuppeteerConnection.ts
  • M test/e2e_non_hosted/puppeteer/puppeteer_test.ts
Change size: L
Delta: 5 files changed, 7 insertions(+), 315 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alex Rudenko
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I5d42635f64e9c51af6a990f774a61bdc50119b7a
Gerrit-Change-Number: 7106262
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages