[heap] Enter global safepoint scope for snapshot creation after GC [v8/v8 : main]
Michael Lippautz (Gerrit)
Michael Lippautz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +1 |
2 comments
bool HeapSnapshotGenerator::GenerateSnapshotAfterGC() {I want to refactor away this method in a follow up. It does almost the same thing is the regular `GenerateSnapshot()`, without the GC.
(There should be not progress counter without it being passed to the generator in first place.)
Related details
- Dominik Inführ
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Michael Lippautz voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Dominik Inführ
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Dominik Inführ voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
2 comments
bool HeapSnapshotGenerator::GenerateSnapshotAfterGC() {I want to refactor away this method in a follow up. It does almost the same thing is the regular `GenerateSnapshot()`, without the GC.
(There should be not progress counter without it being passed to the generator in first place.)
- Michael Lippautz
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Michael Lippautz voted Commit-Queue+2![]( "Open in Gerrit")
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Michael Lippautz added 2 comments![]( "Open in Gerrit")
// Flags: --expose-gc --shared-heap --heap-snapshot-on-gc=0This flag makes us create snapshots on every GC, in the current working directory.
@mache...@chromium.org: I have flagged the test as slow already. Should we avoid it in first place?
Related details
- Dominik Inführ
- Michael Achenbach
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Michael Achenbach added 1 comment![]( "Open in Gerrit")
// Flags: --expose-gc --shared-heap --heap-snapshot-on-gc=0This flag makes us create snapshots on every GC, in the current working directory.
@mache...@chromium.org: I have flagged the test as slow already. Should we avoid it in first place?
Sounds like something we'd rather avoid. The bots won't care much, but I assume this will negatively affect developers? Is the file .gitignored in V8? Also, would it ever clash if we run this test concurrently and both processes want to write to this file?
Would it be possible to add yet another flag, and if that is passed, write the file to /dev/null or skip writing and dump to stdout instead?
Related details
- Dominik Inführ
- Michael Lippautz
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +1 |
1 comment
// Flags: --expose-gc --shared-heap --heap-snapshot-on-gc=0Michael AchenbachThis flag makes us create snapshots on every GC, in the current working directory.
@mache...@chromium.org: I have flagged the test as slow already. Should we avoid it in first place?
Sounds like something we'd rather avoid. The bots won't care much, but I assume this will negatively affect developers? Is the file .gitignored in V8? Also, would it ever clash if we run this test concurrently and both processes want to write to this file?
Would it be possible to add yet another flag, and if that is passed, write the file to /dev/null or skip writing and dump to stdout instead?
Thanks, we already had a flag for the filename, so I can just pass that to `/dev/null` and only enable on Linux.
Related details
- Dominik Inführ
- Michael Achenbach
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Michael Achenbach voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Achenbach
| Code-Review | +1 |
1 comment
Related details
- Dominik Inführ
- Michael Lippautz
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Dominik Inführ voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
2 comments
if (v8_flags.heap_snapshot_on_oom && !isolate->has_active_deserializer()) {I think it would be nice in general if we would be able to take a snapshot every time we are able to GC. Are some verifications in the heap snapshot generator too strict here that we could relax to allow this again?
Related details
- Michael Lippautz
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +2 |
1 comment
if (v8_flags.heap_snapshot_on_oom && !isolate->has_active_deserializer()) {I think it would be nice in general if we would be able to take a snapshot every time we are able to GC. Are some verifications in the heap snapshot generator too strict here that we could relax to allow this again?
That's already a TODO at the site where the deserializer is recorded. Not sure how much work it actually is. The state is certainly inconsistent though.
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[heap] Enter global safepoint scope for snapshot creation after GC
The regular snapshot creation already enters the global safepoint which
is necessary to to shared space handling.
This basically is the same as http://crrev.com/c/6994961
- M src/execution/isolate.h
- M src/heap/cppgc-js/cpp-heap.cc
- M src/heap/heap.cc
- M src/profiler/heap-snapshot-generator.cc
- M test/mjsunit/mjsunit.status
- A test/mjsunit/regress/regress-494583765.js
Code-Review: +1 by Michael Achenbach, +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |