Prevent CPU throttling rate from being incorrectly overwritten [chromium/src : main]
1 view
Skip to first unread message
Wolfgang Beyer (Gerrit)
May 21, 2026, 2:48:16 PM (3 days ago) May 21
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, scheduler-...@chromium.org, chikamu...@chromium.org
Wolfgang Beyer abandoned this change.
Abandoned
in favour of https://crrev.com/c/7867994
Wolfgang Beyer abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wolfgang Beyer (Gerrit)
May 22, 2026, 4:43:31 AM (3 days ago) May 22
to Alex Rudenko, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-...@chromium.org, scheduler-...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, chikamu...@chromium.org
Attention needed from Alex Rudenko
Wolfgang Beyer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
May 22, 2026, 4:53:30 AM (3 days ago) May 22
to Wolfgang Beyer, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-...@chromium.org, scheduler-...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, chikamu...@chromium.org
Attention needed from Wolfgang Beyer
Alex Rudenko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Rudenko
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Wolfgang Beyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wolfgang Beyer (Gerrit)
May 22, 2026, 5:01:43 AM (3 days ago) May 22
to Michael Lippautz, Alex Rudenko, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-...@chromium.org, scheduler-...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, chikamu...@chromium.org
Attention needed from Michael Lippautz
Wolfgang Beyer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Wolfgang Beyer . resolved
Michael, PTAL as owner of thread_cpu_throttler
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
May 22, 2026, 5:06:23 AM (3 days ago) May 22
to Wolfgang Beyer, Etienne Pierre-Doray, Alex Rudenko, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-...@chromium.org, scheduler-...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, chikamu...@chromium.org
Attention needed from Etienne Pierre-Doray and Wolfgang Beyer
Michael Lippautz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Michael Lippautz . resolved
I think the change makes sense. I don't see any other `*ForTesting()` "public" scheduler APIs though, so let me add a more local owner to better judge this -- sorry for the detour.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Wolfgang Beyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 22, 2026, 11:33:32 AM (2 days ago) May 22
to Wolfgang Beyer, Michael Lippautz, Alex Rudenko, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-...@chromium.org, scheduler-...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, chikamu...@chromium.org
Attention needed from Wolfgang Beyer
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Wolfgang Beyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wolfgang Beyer (Gerrit)
May 22, 2026, 11:48:33 AM (2 days ago) May 22
to Etienne Pierre-Doray, Michael Lippautz, Alex Rudenko, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-...@chromium.org, scheduler-...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, chikamu...@chromium.org
Wolfgang Beyer voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 22, 2026, 11:51:43 AM (2 days ago) May 22
to Wolfgang Beyer, Etienne Pierre-Doray, Michael Lippautz, Alex Rudenko, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, scheduler-...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, chikamu...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Prevent CPU throttling rate from being incorrectly overwritten
When a CDP session is being restored or disabled, only set the CPU
throttling rate if it is different from 1. Otherwise, if there are
multiple CDP sessions to the same target, a session which internally
has no CPU throttling factor set, would overwrite the CPU throttling
factor for the whole target.
Fixed: 515365473
Change-Id: I8441770bf0921895586e5bfd03312bd5b3d8b7a3
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Commit-Queue: Wolfgang Beyer <wo...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1634987}
Files:
- M third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
- M third_party/blink/renderer/core/inspector/inspector_emulation_agent_test.cc
- M third_party/blink/renderer/platform/scheduler/common/thread_cpu_throttler.cc
- M third_party/blink/renderer/platform/scheduler/public/thread_cpu_throttler.h
Change size: M
Delta: 4 files changed, 111 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko, +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages