Fix tests disabled for crbug.com/345285378 [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Alex Rudenko (Gerrit)

unread,
Jul 3, 2026, 9:44:58 AM (yesterday) Jul 3
to Nicholas Roscino, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Nicholas Roscino

Alex Rudenko voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nicholas Roscino
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I4806ced5db045bb66dda429ab9a319786b61edc2
Gerrit-Change-Number: 8033044
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Nicholas Roscino <nros...@chromium.org>
Gerrit-Attention: Nicholas Roscino <nros...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Jul 2026 13:44:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nicholas Roscino (Gerrit)

unread,
Jul 3, 2026, 9:47:27 AM (yesterday) Jul 3
to Alex Rudenko, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alex Rudenko

Nicholas Roscino voted and added 1 comment

Votes added by Nicholas Roscino

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Nicholas Roscino . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I4806ced5db045bb66dda429ab9a319786b61edc2
Gerrit-Change-Number: 8033044
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Nicholas Roscino <nros...@chromium.org>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Jul 2026 13:47:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jul 3, 2026, 10:21:24 AM (yesterday) Jul 3
to Alex Rudenko, Nicholas Roscino, devtools-rev...@chromium.org

devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Fix tests disabled for crbug.com/345285378

The update captures the current behavior. Currently, there is no
indication that this is a wrong behavior but at one point
`has-cross-site-ancestor` was true and now it is an empty string, which
might be expected cookie management changes on the Chromium side.
Fixed: 345285378
Change-Id: I4806ced5db045bb66dda429ab9a319786b61edc2
Commit-Queue: Nicholas Roscino <nros...@chromium.org>
Auto-Submit: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Nicholas Roscino <nros...@chromium.org>
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Files:
  • M test/e2e/application/cookies.test.ts
Change size: S
Delta: 1 file changed, 3 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nicholas Roscino
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I4806ced5db045bb66dda429ab9a319786b61edc2
Gerrit-Change-Number: 8033044
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Nicholas Roscino <nros...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages