[api] Rename Get/SetPrototypeV2() and HolderV2() [v8/v8 : main]

0 views
Skip to first unread message

Michael Lippautz (Gerrit)

unread,
9:56 AM (5 hours ago) 9:56 AM
to Igor Sheludko, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Igor Sheludko

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie8f49b3890780f23bdc8b053518dfea03e8d96e9
Gerrit-Change-Number: 7624359
Gerrit-PatchSet: 3
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Mar 2026 14:56:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Igor Sheludko (Gerrit)

unread,
11:55 AM (3 hours ago) 11:55 AM
to Michael Lippautz, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com

Igor Sheludko voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie8f49b3890780f23bdc8b053518dfea03e8d96e9
Gerrit-Change-Number: 7624359
Gerrit-PatchSet: 3
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Mar 2026 16:55:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
11:57 AM (3 hours ago) 11:57 AM
to Igor Sheludko, Michael Lippautz, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[api] Rename Get/SetPrototypeV2() and HolderV2()

... to Get/SetPrototype() and Holder() to cleanup the V8 Api and start
deprecation of V2 versions.
Bug: 333672197
Change-Id: Ie8f49b3890780f23bdc8b053518dfea03e8d96e9
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105571}
Files:
  • M include/v8-function-callback.h
  • M include/v8-object.h
  • M samples/process.cc
  • M src/api/api.cc
  • M src/builtins/accessors.cc
  • M src/d8/d8.cc
  • M src/debug/debug-wasm-objects.cc
  • M src/execution/isolate.cc
  • M src/inspector/v8-console.cc
  • M src/inspector/v8-debugger.cc
  • M test/cctest/test-accessors.cc
  • M test/cctest/test-api-interceptors.cc
  • M test/cctest/test-api.cc
  • M test/cctest/test-unscopables-hidden-prototype.cc
  • M test/unittests/api/dictionary-template-unittest.cc
  • M test/unittests/api/interceptor-unittest.cc
  • M test/unittests/api/v8-object-unittest.cc
  • M test/unittests/debug/debug-property-iterator-unittest.cc
  • M test/unittests/objects/global-object-unittest.cc
  • M test/unittests/objects/value-serializer-unittest.cc
Change size: L
Delta: 20 files changed, 138 insertions(+), 153 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie8f49b3890780f23bdc8b053518dfea03e8d96e9
Gerrit-Change-Number: 7624359
Gerrit-PatchSet: 4
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages