Migrate comments from crbug.com/<crbug ID> to crbug.com/<buganizer ID> [chromium/src : main]

0 views
Skip to first unread message

Solomon Kinard (Gerrit)

unread,
Jan 28, 2026, 5:01:27 PMJan 28
to Kevin McNee, Permissions Reviews, devtools...@chromium.org, Victor Tan, James Maclean, chromium...@chromium.org, (Julie)Jeongeun Kim, Mike Taylor, Peter Beverloo, webapks-...@chromium.org, nektar...@chromium.org, nator...@chromium.org, chromeos-kio...@google.com, feature-me...@chromium.org, yuzo+...@chromium.org, browser-comp...@chromium.org, oshima...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, dtseng...@chromium.org, storage...@chromium.org, dmurph+wat...@chromium.org, net-r...@chromium.org, chromium-a...@chromium.org, rayanka...@chromium.org, kinuko+...@chromium.org, msrame...@chromium.org, dtraino...@chromium.org, francisjp...@google.com, josiah...@chromium.org, dullweb...@chromium.org, mac-r...@chromium.org, webap...@microsoft.com, extension...@chromium.org

Solomon Kinard has uploaded the change for review

Commit message

Migrate comments from crbug.com/<crbug ID> to crbug.com/<buganizer ID>

The pre-existing <crbug ID> represents the deprecated <monorail ID>.

Doc:
https://docs.google.com/document/d/1MDJ0IsE4ICl0fjOF8vbHfx6-CXRV2IJsUiU7IUT-nH8/edit?usp=sharing
Bug: 321899722
Change-Id: Ie02be8a1777a264830ff4b8446fc459a7e58278f

Change diff


Change information

Files:
  • M chrome/browser/accessibility/image_annotation_browsertest.cc
  • M chrome/browser/after_startup_task_utils.cc
  • M chrome/browser/android/background_sync_launcher_android.cc
  • M chrome/browser/android/metrics/uma_utils.cc
  • M chrome/browser/android/tab_android.cc
  • M chrome/browser/android/usage_stats/usage_stats_database.cc
  • M chrome/browser/android/webapk/webapk_installer.cc
  • M chrome/browser/apps/guest_view/web_view_browsertest.cc
  • M chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
  • M chrome/browser/apps/platform_apps/api/media_galleries/media_galleries_apitest.cc
  • M chrome/browser/apps/platform_apps/api/sync_file_system/sync_file_system_apitest.cc
  • M chrome/browser/apps/platform_apps/app_browsertest.cc
  • M chrome/browser/apps/platform_apps/app_window_browsertest.cc
  • M chrome/browser/apps/platform_apps/app_window_frame_browsertest.cc
  • M chrome/browser/apps/platform_apps/app_window_interactive_uitest.cc
  • M chrome/browser/apps/platform_apps/event_page_browsertest.cc
  • M chrome/browser/apps/platform_apps/extension_app_shim_manager_delegate_mac.cc
  • M chrome/browser/apps/platform_apps/platform_app_navigation_redirector.cc
  • M chrome/browser/autofill/autofill_browsertest.cc
  • M chrome/browser/autofill/autofill_interactive_uitest.cc
  • M chrome/browser/background/background_contents_service.cc
  • M chrome/browser/background_fetch/background_fetch_permission_context.cc
  • M chrome/browser/bookmarks/android/bookmark_bridge.cc
  • M chrome/browser/browser_about_handler_unittest.cc
  • M chrome/browser/browser_commands_unittest.cc
  • M chrome/browser/browser_keyevents_interactive_uitest.cc
  • M chrome/browser/browser_process_impl.cc
  • M chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
  • M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
  • M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
  • M chrome/browser/browsing_data/counters/downloads_counter_browsertest.cc
  • M chrome/browser/captive_portal/captive_portal_browsertest.cc
  • M chrome/browser/chrome_browser_main.cc
  • M chrome/browser/chrome_browser_main_win.cc
  • M chrome/browser/chrome_content_browser_client.cc
  • M chrome/browser/chrome_content_browser_client_browsertest.cc
  • M chrome/browser/chrome_content_browser_client_navigation_throttles.cc
  • M chrome/browser/chrome_content_browser_client_unittest.cc
  • M chrome/browser/chrome_do_not_track_browsertest.cc
  • M chrome/browser/chrome_navigation_browsertest.cc
  • M chrome/browser/chrome_security_exploit_browsertest.cc
  • M chrome/browser/chrome_service_worker_browsertest.cc
  • M chrome/browser/chrome_worker_browsertest.cc
  • M chrome/browser/chromeos/app_mode/chrome_kiosk_app_installer.cc
  • M chrome/browser/client_hints/client_hints_browsertest.cc
  • M chrome/browser/component_updater/widevine_cdm_component_installer.cc
  • M chrome/browser/content_settings/host_content_settings_map_unittest.cc
  • M chrome/browser/crash_recovery_browsertest.cc
  • M chrome/browser/crash_upload_list/crash_upload_list_android.cc
  • M chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
  • M chrome/browser/devtools/device/cast_device_provider.cc
  • M chrome/browser/devtools/devtools_browsertest.cc
  • M chrome/browser/devtools/devtools_eye_dropper.cc
  • M chrome/browser/devtools/devtools_interactive_uitest.cc
  • M chrome/browser/devtools/devtools_ui_bindings.cc
  • M chrome/browser/devtools/devtools_window.cc
  • M chrome/browser/download/chrome_download_manager_delegate.cc
  • M chrome/browser/download/download_browsertest.cc
  • M chrome/browser/download/download_core_service_impl.cc
  • M chrome/browser/download/download_danger_prompt_browsertest.cc
  • M chrome/browser/download/download_history.cc
  • M chrome/browser/download/download_request_limiter.cc
  • M chrome/browser/download/download_request_limiter_unittest.cc
  • M chrome/browser/download/notification/download_notification_browsertest.cc
  • M chrome/browser/download/save_page_browsertest.cc
  • M chrome/browser/net/chrome_network_service_restart_browsertest.cc
  • M chrome/browser/net/errorpage_browsertest.cc
  • M chrome/browser/net/net_error_diagnostics_dialog_win.cc
  • M chrome/browser/net/network_context_configuration_browsertest.cc
  • M chrome/browser/net/system_network_context_manager.cc
  • M chrome/browser/no_best_effort_tasks_browsertest.cc
  • M chrome/browser/notifications/chrome_ash_message_center_client.cc
  • M chrome/browser/notifications/extension_notifier_controller.cc
  • M chrome/browser/notifications/notification_channels_provider_android.h
  • M chrome/browser/notifications/notification_interactive_uitest.cc
  • M chrome/browser/notifications/notification_interactive_uitest_support.cc
  • M chrome/browser/notifications/notification_permission_context_unittest.cc
  • M chrome/browser/notifications/notification_platform_bridge_android.cc
  • M chrome/browser/notifications/notification_platform_bridge_chromeos_unittest.cc
  • M chrome/browser/notifications/notification_platform_bridge_delegate.h
  • M chrome/browser/notifications/notification_platform_bridge_linux.cc
  • M chrome/browser/notifications/notification_platform_bridge_win.cc
  • M chrome/browser/notifications/notification_ui_manager_impl.cc
  • M chrome/browser/notifications/notification_ui_manager_interactive_uitest.cc
  • M chrome/browser/notifications/notification_ui_manager_unittest.cc
  • M chrome/browser/notifications/persistent_notification_handler.h
  • M chrome/browser/notifications/platform_notification_service_impl.cc
  • M chrome/browser/notifications/popups_only_ui_controller.cc
  • M chrome/browser/notifications/scheduler/internal/notification_scheduler.cc
  • M chrome/browser/notifications/win/notification_template_builder.cc
Change size: L
Delta: 90 files changed, 270 insertions(+), 267 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie02be8a1777a264830ff4b8446fc459a7e58278f
Gerrit-Change-Number: 7528185
Gerrit-PatchSet: 1
Gerrit-Owner: Solomon Kinard <solomo...@chromium.org>
Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Victor Tan <vict...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Solomon Kinard (Gerrit)

unread,
Jan 28, 2026, 5:04:40 PMJan 28
to Lei Zhang, Permissions Reviews, Rijubrata Bhaumik, Tommy Li, chromium...@chromium.org, Andrew Rayskiy, Enterprise Policy Reviews, Kevin McNee, prerendering-reviews, devtools...@chromium.org, Simon Hangl, James Maclean, (Julie)Jeongeun Kim, Peter Beverloo, bmcquad...@chromium.org, vakh+safe_br...@chromium.org, loading-rev...@chromium.org, zackha...@chromium.org, philli...@chromium.org, cros-ed...@google.com, feature-me...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, storage...@chromium.org, asvitki...@chromium.org, subresource-f...@chromium.org, zelin+watch-we...@chromium.org, print-rev...@chromium.org, mfoltz+wa...@chromium.org, cros-print...@google.com, chromium-a...@chromium.org, csharris...@chromium.org, vasilii+watchlis...@chromium.org, eme-r...@chromium.org, druber...@chromium.org, francisjp...@google.com, josiah...@chromium.org, loyso...@chromium.org, dmurph+watc...@chromium.org, speed-metrics...@chromium.org, kuragin+web-ap...@chromium.org, webap...@microsoft.com, japhet+...@chromium.org, dibyapal+wa...@chromium.org, nwoked...@chromium.org, chrome-gr...@chromium.org, gavin...@chromium.org, mek+w...@chromium.org, nektar...@chromium.org, speed-metr...@chromium.org, browser-comp...@chromium.org, abigailbk...@google.com, feature-v...@chromium.org, dtseng...@chromium.org, jdeblas...@chromium.org, sloboda...@chromium.org, tburkar...@chromium.org, performance-m...@chromium.org, grt+...@chromium.org, xinghui...@chromium.org, andysjl...@chromium.org, chfreme...@chromium.org, mgiuca...@chromium.org, fuzzin...@chromium.org, pdf-r...@chromium.org, phoglun...@chromium.org, aixba+wat...@chromium.org, gcasto+w...@chromium.org, chromiumme...@microsoft.com, rginda...@chromium.org, mac-r...@chromium.org, extension...@chromium.org

Solomon Kinard has uploaded the change for review

Commit message

Migrate comments from crbug.com/<crbug ID> to crbug.com/<buganizer ID>

The pre-existing <crbug ID> represents the deprecated <monorail ID>.

Doc:
https://docs.google.com/document/d/1MDJ0IsE4ICl0fjOF8vbHfx6-CXRV2IJsUiU7IUT-nH8/edit?usp=sharing
Bug: 321899722
Change-Id: I226805656293ef19c9f7a807075767f281ee6437

Change diff


Change information

Files:
  • M chrome/browser/engagement/history_aware_site_engagement_service.cc
  • M chrome/browser/engagement/important_sites_util_browsertest.cc
  • M chrome/browser/external_protocol/external_protocol_handler.cc
  • M chrome/browser/external_protocol/external_protocol_handler.h
  • M chrome/browser/external_protocol/external_protocol_handler_unittest.cc
  • M chrome/browser/favicon/content_favicon_driver_browsertest.cc
  • M chrome/browser/file_system_access/chrome_file_system_access_permission_context.cc
  • M chrome/browser/first_run/first_run.cc
  • M chrome/browser/first_run/first_run_browsertest.cc
  • M chrome/browser/flag_descriptions.h
  • M chrome/browser/font_family_cache.cc
  • M chrome/browser/font_family_cache.h
  • M chrome/browser/fullscreen_linux.cc
  • M chrome/browser/global_keyboard_shortcuts_mac.h
  • M chrome/browser/google/google_update_settings_posix.cc
  • M chrome/browser/google/google_update_settings_unittest.cc
  • M chrome/browser/google/google_update_win.cc
  • M chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_browsertest.cc
  • M chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_interactive_uitest.cc
  • M chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc
  • M chrome/browser/history/history_browsertest.cc
  • M chrome/browser/idle/idle_detection_permission_context_unittest.cc
  • M chrome/browser/iframe_browsertest.cc
  • M chrome/browser/image_fetcher/image_fetcher_service_factory.cc
  • M chrome/browser/lifetime/application_lifetime_aura.cc
  • M chrome/browser/lifetime/application_lifetime_browsertest.cc
  • M chrome/browser/lifetime/application_lifetime_chromeos.cc
  • M chrome/browser/lifetime/browser_close_manager_browsertest.cc
  • M chrome/browser/lifetime/browser_shutdown_browsertest.cc
  • M chrome/browser/local_discovery/endpoint_resolver.cc
  • M chrome/browser/lookalikes/lookalike_url_navigation_throttle.cc
  • M chrome/browser/media/android/cdm/per_device_provisioning_permission.h
  • M chrome/browser/media/capture_access_handler_base.cc
  • M chrome/browser/media/encrypted_media_browsertest.cc
  • M chrome/browser/media/encrypted_media_supported_types_browsertest.cc
  • M chrome/browser/media/extension_media_access_handler.cc
  • M chrome/browser/media/media_browsertest.cc
  • M chrome/browser/media/media_engagement_score.cc
  • M chrome/browser/media/router/discovery/dial/dial_service_impl.cc
  • M chrome/browser/media/router/discovery/discovery_network_list_win.cc
  • M chrome/browser/media/router/media_router_feature.h
  • M chrome/browser/media/router/providers/dial/dial_internal_message_fuzzer.cc
  • M chrome/browser/media/webrtc/media_stream_device_permission_context.cc
  • M chrome/browser/media/webrtc/media_stream_device_permission_context.h
  • M chrome/browser/media/webrtc/native_desktop_media_list.cc
  • M chrome/browser/media/webrtc/native_desktop_media_list_unittest.cc
  • M chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc
  • M chrome/browser/media/webrtc/webrtc_desktop_capture_browsertest.cc
  • M chrome/browser/media/webrtc/webrtc_interactive_uitest.cc
  • M chrome/browser/media/webrtc/webrtc_log_uploader.cc
  • M chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc
  • M chrome/browser/media_galleries/gallery_watch_manager_unittest.cc
  • M chrome/browser/media_galleries/media_galleries_preferences.cc
  • M chrome/browser/memory_details.cc
  • M chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.h
  • M chrome/browser/metrics/enrollment_status.h
  • M chrome/browser/metrics/first_web_contents_profiler_base.h
  • M chrome/browser/metrics/metrics_service_browsertest.cc
  • M chrome/browser/metrics/network_quality_estimator_provider_impl.cc
  • M chrome/browser/metrics/power/process_monitor.cc
  • M chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
  • M chrome/browser/metrics/variations/force_field_trials_browsertest.cc
  • M chrome/browser/metrics/variations/variations_http_headers_browsertest.cc
  • M chrome/browser/mouse_events_interactive_uitest.cc
  • M chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
  • M chrome/browser/offline_pages/offline_page_utils_unittest.cc
  • M chrome/browser/offline_pages/recent_tab_helper.cc
  • M chrome/browser/offline_pages/recent_tab_helper_unittest.cc
  • M chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer_browsertest.cc
  • M chrome/browser/page_load_metrics/observers/security_state_page_load_metrics_observer_browsertest.cc
  • M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
  • M chrome/browser/password_manager/android/auto_signin_prompt_controller.cc
  • M chrome/browser/password_manager/chrome_password_manager_client.cc
  • M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
  • M chrome/browser/password_manager/credential_manager_browsertest.cc
  • M chrome/browser/password_manager/password_manager_browsertest.cc
  • M chrome/browser/password_manager/password_manager_interactive_uitest.cc
  • M chrome/browser/password_manager/password_manager_util_win.cc
  • M chrome/browser/payments/payment_handler_exploit_browsertest.cc
  • M chrome/browser/pdf/pdf_extension_accessibility_test.cc
  • M chrome/browser/pdf/pdf_extension_js_test.cc
  • M chrome/browser/pdf/pdf_extension_test.cc
  • M chrome/browser/performance_manager/policies/discard_eligibility_policy.cc
  • M chrome/browser/performance_manager/policies/working_set_trimmer_policy.h
  • M chrome/browser/permissions/chrome_permissions_client.cc
  • M chrome/browser/permissions/permission_request_manager_browsertest.cc
  • M chrome/browser/permissions/permission_subscription_unittest.cc
  • M chrome/browser/platform_util_win.cc
  • M chrome/browser/plugins/plugin_response_interceptor_url_loader_throttle.cc
  • M chrome/browser/policy/cloud/user_policy_signin_service.cc
  • M chrome/browser/policy/cloud/user_policy_signin_service_mobile.cc
  • M chrome/browser/policy/configuration_policy_handler_list_factory.cc
  • M chrome/browser/policy/extension_policy_browsertest.cc
  • M chrome/browser/policy/networking/user_network_configuration_updater_ash.cc
  • M chrome/browser/policy/networking/user_network_configuration_updater_factory.cc
  • M chrome/browser/policy/site_isolation_policy_browsertest.cc
  • M chrome/browser/policy/test/content_settings_policy_browsertest.cc
  • M chrome/browser/policy/test/policy_browsertest.cc
  • M chrome/browser/policy/test/url_blocklist_policy_browsertest.cc
  • M chrome/browser/predictors/autocomplete_action_predictor_table.h
  • M chrome/browser/prefetch/prefetch_browsertest.cc
  • M chrome/browser/prefs/pref_service_browsertest.cc
  • M chrome/browser/prefs/tracked/pref_hash_browsertest.cc
  • M chrome/browser/preloading/prefetch/no_state_prefetch/prerender_nostate_prefetch_browsertest.cc
  • M chrome/browser/printing/background_printing_manager.cc
  • M chrome/browser/printing/print_backend_service_manager.cc
  • M chrome/browser/printing/print_browsertest.cc
  • M chrome/browser/printing/print_job.h
  • M chrome/browser/printing/print_preview_dialog_controller_unittest.cc
  • M chrome/browser/printing/print_view_manager.cc
  • M chrome/browser/printing/print_view_manager_unittest.cc
  • M chrome/browser/printing/printer_query.cc
  • M chrome/browser/printing/printer_query_oop.cc
  • M chrome/browser/process_singleton.h
  • M chrome/browser/process_singleton_browsertest.cc
  • M chrome/browser/process_singleton_posix.cc
  • M chrome/browser/profiles/avatar_menu.cc
  • M chrome/browser/profiles/delete_profile_helper.cc
  • M chrome/browser/profiles/force_safe_search_policy_handler.cc
  • M chrome/browser/profiles/host_zoom_map_browsertest.cc
  • M chrome/browser/profiles/profile.cc
  • M chrome/browser/profiles/profile_attributes_entry.cc
  • M chrome/browser/profiles/profile_attributes_storage_unittest.cc
  • M chrome/browser/profiles/profile_browsertest.cc
  • M chrome/browser/profiles/profile_destroyer.cc
  • M chrome/browser/profiles/profile_downloader_unittest.cc
  • M chrome/browser/profiles/profile_impl.cc
  • M chrome/browser/profiles/profile_list_desktop_unittest.cc
  • M chrome/browser/profiles/profile_manager.cc
  • M chrome/browser/profiles/profile_manager_unittest.cc
  • M chrome/browser/push_messaging/push_messaging_app_identifier.cc
  • M chrome/browser/push_messaging/push_messaging_browsertest.cc
  • M chrome/browser/push_messaging/push_messaging_notification_manager.h
  • M chrome/browser/push_messaging/push_messaging_service_factory.cc
  • M chrome/browser/push_messaging/push_messaging_service_impl.cc
  • M chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
  • M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
  • M chrome/browser/repost_form_warning_browsertest.cc
  • M chrome/browser/resource_coordinator/lifecycle_unit.h
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
  • M chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc
  • M chrome/browser/resource_coordinator/tab_manager.h
  • M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
  • M chrome/browser/resource_coordinator/tab_manager_unittest.cc
  • M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
  • M chrome/browser/safe_browsing/download_protection/download_protection_delegate_desktop.cc
  • M chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc
  • M chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc
  • M chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc
  • M chrome/browser/safe_browsing/incident_reporting/verifier_test/verifier_test_dll.cc
  • M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
  • M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
  • M chrome/browser/search/search.cc
  • M chrome/browser/search/search_unittest.cc
  • M chrome/browser/search_engines/template_url_parser_unittest.cc
  • M chrome/browser/sessions/better_session_restore_browsertest.cc
  • M chrome/browser/sessions/session_restore.cc
  • M chrome/browser/sessions/session_restore_browsertest.cc
  • M chrome/browser/sessions/session_restore_browsertest_chromeos.cc
  • M chrome/browser/sessions/session_service.cc
  • M chrome/browser/sessions/tab_restore_browsertest.cc
  • M chrome/browser/sessions/tab_restore_service_unittest.cc
  • M chrome/browser/shutdown_signal_handlers_posix.cc
  • M chrome/browser/signin/account_consistency_mode_manager.cc
  • M chrome/browser/signin/dice_browsertest.cc
  • M chrome/browser/signin/dice_intercepted_session_startup_helper.cc
  • M chrome/browser/signin/header_modification_delegate_impl.h
  • M chrome/browser/signin/mirror_browsertest.cc
  • M chrome/browser/signin/signin_ui_util.cc
  • M chrome/browser/site_isolation/chrome_site_per_process_browsertest.cc
  • M chrome/browser/site_isolation/site_details_browsertest.cc
  • M chrome/browser/site_isolation/site_per_process_interactive_uitest.cc
  • M chrome/browser/site_isolation/site_per_process_text_input_interactive_uitest.cc
  • M chrome/browser/site_isolation/spellcheck_per_process_browsertest.cc
  • M chrome/browser/speech/extension_api/tts_engine_extension_api.cc
  • M chrome/browser/speech/extension_api/tts_extension_apitest.cc
  • M chrome/browser/speech/speech_recognizer_delegate.h
  • M chrome/browser/spellchecker/spellcheck_factory.cc
  • M chrome/browser/spellchecker/spellcheck_service_browsertest.cc
  • M chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
  • M chrome/browser/ssl/https_upgrades_browsertest.cc
  • M chrome/browser/ssl/security_state_tab_helper_browsertest.cc
  • M chrome/browser/ssl/ssl_browsertest.cc
  • M chrome/browser/ssl/stateful_ssl_host_state_delegate_test.cc
  • M chrome/browser/subresource_filter/ad_tagging_browsertest.cc
  • M chrome/browser/subresource_filter/subresource_filter_browsertest.cc
  • M chrome/browser/subresource_filter/subresource_filter_devtools_browsertest.cc
  • M chrome/browser/subresource_filter/subresource_filter_special_subframe_navigations_browsertest.cc
  • M chrome/browser/supervised_user/family_link_url_filter_browsertest.cc
  • M chrome/browser/supervised_user/supervised_user_navigation_throttle_browsertest.cc
  • M chrome/browser/unload_browsertest.cc
  • M chrome/browser/vr/ui_element_renderer.cc
  • M chrome/browser/web_applications/externally_managed_app_manager_unittest.cc
  • M chrome/browser/web_applications/locks/partitioned_lock_manager.cc
  • M chrome/browser/web_applications/os_integration/web_app_shortcut_win.cc
Change size: L
Delta: 195 files changed, 447 insertions(+), 439 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I226805656293ef19c9f7a807075767f281ee6437
Gerrit-Change-Number: 7528269
Gerrit-PatchSet: 1
Gerrit-Owner: Solomon Kinard <solomo...@chromium.org>
Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Solomon Kinard (Gerrit)

unread,
Feb 5, 2026, 12:46:05 AMFeb 5
to Alison Gale, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin McNee, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, Tommy Li, James Maclean, abigailbk...@google.com, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, csharris...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, josiah...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Alison Gale

Solomon Kinard added 1 comment

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Gale
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I226805656293ef19c9f7a807075767f281ee6437
Gerrit-Change-Number: 7528269
Gerrit-PatchSet: 3
Gerrit-Owner: Solomon Kinard <solomo...@chromium.org>
Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Alison Gale <ag...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Feb 2026 05:45:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alison Gale (Gerrit)

unread,
Feb 5, 2026, 1:44:53 PMFeb 5
to Solomon Kinard, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin McNee, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, Tommy Li, James Maclean, abigailbk...@google.com, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, csharris...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, josiah...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Solomon Kinard

Alison Gale voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Solomon Kinard
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Solomon Kinard <solomo...@chromium.org>
    Gerrit-Comment-Date: Thu, 05 Feb 2026 18:44:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Solomon Kinard (Gerrit)

    unread,
    Feb 6, 2026, 3:53:21 PMFeb 6
    to Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin McNee, Mike Taylor, Permissions Reviews, Peter Beverloo, Victor Tan, James Maclean, abigailbk...@google.com, browser-comp...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kinuko+...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, msrame...@chromium.org, nator...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rayanka...@chromium.org, storage...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, yuzo+...@chromium.org
    Attention needed from Nico Weber

    Solomon Kinard added 1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Solomon Kinard . resolved

    Thanks for reviewing the LSC group thread. Any idea how to get the rubber stamp ability to merge these LSCs?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nico Weber
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie02be8a1777a264830ff4b8446fc459a7e58278f
      Gerrit-Change-Number: 7528185
      Gerrit-PatchSet: 1
      Gerrit-Owner: Solomon Kinard <solomo...@chromium.org>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Kevin McNee <mc...@chromium.org>
      Gerrit-CC: Mike Taylor <mike...@chromium.org>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-CC: Victor Tan <vict...@chromium.org>
      Gerrit-Attention: Nico Weber <tha...@chromium.org>
      Gerrit-Comment-Date: Fri, 06 Feb 2026 20:53:12 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Avi Drissman (Gerrit)

      unread,
      Feb 9, 2026, 2:07:21 PMFeb 9
      to Solomon Kinard, Avi Drissman, Alison Gale, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin McNee, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, Tommy Li, James Maclean, abigailbk...@google.com, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, csharris...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, josiah...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
      Attention needed from Solomon Kinard

      Avi Drissman voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Solomon Kinard
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I226805656293ef19c9f7a807075767f281ee6437
      Gerrit-Change-Number: 7528269
      Gerrit-PatchSet: 3
      Gerrit-Owner: Solomon Kinard <solomo...@chromium.org>
      Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Kevin McNee <mc...@chromium.org>
      Gerrit-CC: Lei Zhang <the...@chromium.org>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-CC: Tommy Li <tomm...@chromium.org>
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Solomon Kinard <solomo...@chromium.org>
      Gerrit-Comment-Date: Mon, 09 Feb 2026 19:07:12 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Avi Drissman (Gerrit)

      unread,
      Feb 9, 2026, 2:07:25 PMFeb 9
      to Solomon Kinard, Avi Drissman, Alison Gale, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin McNee, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, Tommy Li, James Maclean, abigailbk...@google.com, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, csharris...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, josiah...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
      Attention needed from Solomon Kinard

      Avi Drissman voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Mon, 09 Feb 2026 19:07:19 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Avi Drissman (Gerrit)

      unread,
      Feb 9, 2026, 2:07:48 PMFeb 9
      to Solomon Kinard, Avi Drissman, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin McNee, Mike Taylor, Permissions Reviews, Peter Beverloo, Victor Tan, James Maclean, abigailbk...@google.com, browser-comp...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kinuko+...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, msrame...@chromium.org, nator...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rayanka...@chromium.org, storage...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, yuzo+...@chromium.org
      Attention needed from Nico Weber and Solomon Kinard

      Avi Drissman voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Nico Weber
      • Solomon Kinard
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie02be8a1777a264830ff4b8446fc459a7e58278f
      Gerrit-Change-Number: 7528185
      Gerrit-PatchSet: 1
      Gerrit-Owner: Solomon Kinard <solomo...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Kevin McNee <mc...@chromium.org>
      Gerrit-CC: Mike Taylor <mike...@chromium.org>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-CC: Victor Tan <vict...@chromium.org>
      Gerrit-Attention: Solomon Kinard <solomo...@chromium.org>
      Gerrit-Attention: Nico Weber <tha...@chromium.org>
      Gerrit-Comment-Date: Mon, 09 Feb 2026 19:07:41 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Avi Drissman (Gerrit)

      unread,
      Feb 9, 2026, 2:07:53 PMFeb 9
      to Solomon Kinard, Avi Drissman, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin McNee, Mike Taylor, Permissions Reviews, Peter Beverloo, Victor Tan, James Maclean, abigailbk...@google.com, browser-comp...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kinuko+...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, msrame...@chromium.org, nator...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rayanka...@chromium.org, storage...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, yuzo+...@chromium.org
      Attention needed from Nico Weber and Solomon Kinard

      Avi Drissman voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Mon, 09 Feb 2026 19:07:48 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Feb 9, 2026, 4:21:55 PMFeb 9
      to Solomon Kinard, Avi Drissman, Nico Weber, Akihiro Ota, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin McNee, Mike Taylor, Permissions Reviews, Peter Beverloo, Victor Tan, James Maclean, abigailbk...@google.com, browser-comp...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kinuko+...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, msrame...@chromium.org, nator...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rayanka...@chromium.org, storage...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, yuzo+...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Migrate comments from crbug.com/<crbug ID> to crbug.com/<buganizer ID>

      The pre-existing <crbug ID> represents the deprecated <monorail ID>.

      Doc:
      https://docs.google.com/document/d/1MDJ0IsE4ICl0fjOF8vbHfx6-CXRV2IJsUiU7IUT-nH8/edit?usp=sharing
      Bug: 321899722
      Change-Id: Ie02be8a1777a264830ff4b8446fc459a7e58278f
      Reviewed-by: Avi Drissman <a...@chromium.org>
      Commit-Queue: Avi Drissman <a...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1582007}
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Avi Drissman
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie02be8a1777a264830ff4b8446fc459a7e58278f
      Gerrit-Change-Number: 7528185
      Gerrit-PatchSet: 2
      Gerrit-Owner: Solomon Kinard <solomo...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      open
      diffy
      satisfied_requirement

      Solomon Kinard (Gerrit)

      unread,
      Feb 10, 2026, 12:10:06 PMFeb 10
      to Avi Drissman, Alison Gale, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin McNee, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, Tommy Li, James Maclean, abigailbk...@google.com, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, csharris...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, josiah...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

      Solomon Kinard voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I226805656293ef19c9f7a807075767f281ee6437
      Gerrit-Change-Number: 7528269
      Gerrit-PatchSet: 8
      Gerrit-Owner: Solomon Kinard <solomo...@chromium.org>
      Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Kevin McNee <mc...@chromium.org>
      Gerrit-CC: Lei Zhang <the...@chromium.org>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-CC: Tommy Li <tomm...@chromium.org>
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Comment-Date: Tue, 10 Feb 2026 17:09:53 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Feb 10, 2026, 12:14:56 PMFeb 10
      to Solomon Kinard, Avi Drissman, Alison Gale, Akihiro Ota, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin McNee, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, Tommy Li, James Maclean, abigailbk...@google.com, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, csharris...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, josiah...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, pdf-r...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      3 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: chrome/browser/signin/account_consistency_mode_manager.cc
      Insertions: 1, Deletions: 2.

      The diff is too large to show. Please review the diff.
      ```

      Change information

      Commit message:
      Migrate comments from crbug.com/<crbug ID> to crbug.com/<buganizer ID>

      The pre-existing <crbug ID> represents the deprecated <monorail ID>.

      Doc:
      https://docs.google.com/document/d/1MDJ0IsE4ICl0fjOF8vbHfx6-CXRV2IJsUiU7IUT-nH8/edit?usp=sharing

      Skip-Clang-Tidy-Checks: google-default-arguments
      Bug: 321899722
      Change-Id: I226805656293ef19c9f7a807075767f281ee6437
      Reviewed-by: Avi Drissman <a...@chromium.org>
      Reviewed-by: Alison Gale <ag...@chromium.org>
      Commit-Queue: Solomon Kinard <solomo...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1582583}
      Files:
        • M content/browser/push_messaging/push_messaging_manager.cc
        Change size: L
        Delta: 196 files changed, 436 insertions(+), 430 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Alison Gale, +1 by Avi Drissman
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I226805656293ef19c9f7a807075767f281ee6437
        Gerrit-Change-Number: 7528269
        Gerrit-PatchSet: 9
        Gerrit-Owner: Solomon Kinard <solomo...@chromium.org>
        Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Andrew Rayskiy <green...@google.com>
        open
        diffy
        satisfied_requirement

        Nico Weber (Gerrit)

        unread,
        Feb 10, 2026, 2:24:02 PMFeb 10
        to Solomon Kinard, Chromium LUCI CQ, Avi Drissman, Nico Weber, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin McNee, Mike Taylor, Permissions Reviews, Peter Beverloo, Victor Tan, James Maclean, abigailbk...@google.com, browser-comp...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kinuko+...@chromium.org, kyungjunle...@google.com, mac-r...@chromium.org, msrame...@chromium.org, nator...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rayanka...@chromium.org, storage...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, yuzo+...@chromium.org

        Nico Weber added 1 comment

        Patchset-level comments
        Solomon Kinard . resolved

        Thanks for reviewing the LSC group thread. Any idea how to get the rubber stamp ability to merge these LSCs?

        Nico Weber

        Since you said it's just 7 CLs, I think you can just send them to me and I can stamp.

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie02be8a1777a264830ff4b8446fc459a7e58278f
        Gerrit-Change-Number: 7528185
        Gerrit-PatchSet: 2
        Gerrit-Owner: Solomon Kinard <solomo...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
        Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: James Maclean <wjma...@chromium.org>
        Gerrit-CC: Kevin McNee <mc...@chromium.org>
        Gerrit-CC: Mike Taylor <mike...@chromium.org>
        Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
        Gerrit-CC: Peter Beverloo <pe...@chromium.org>
        Gerrit-CC: Victor Tan <vict...@chromium.org>
        Gerrit-Comment-Date: Tue, 10 Feb 2026 19:23:53 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Solomon Kinard <solomo...@chromium.org>
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages