DevTools: Add Smart Card Emulation Components [chromium/src : main]

0 views

Skip to first unread message

Zgroza (Luke) Klimek (Gerrit)

unread,

12:11 PM (11 hours ago) 12:11 PM

to Paulina Gacek, Patryk Chodur, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org

Attention needed from Patryk Chodur and Paulina Gacek

Zgroza (Luke) Klimek added 4 comments

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Zgroza (Luke) Klimek . unresolved

So, the high-level comment would be to add some simple unit tests for this. I know those are quite trivial for now, though I don't feel good about adding dead code without even tests.

File content/browser/smart_card/emulation/emulated_smart_card_connection.h

Line 53, Patchset 12 (Latest): const std::string handle_id_;

Zgroza (Luke) Klimek . unresolved

As below, making this an integer could be a good idea.

File content/browser/smart_card/emulation/emulated_smart_card_context.h

Line 48, Patchset 12 (Latest): const std::string context_id_;

Zgroza (Luke) Klimek . unresolved

This will always be an integer though due to the way PC/SC works, enforcing type here would be nice.

File content/browser/smart_card/emulation/emulated_smart_card_context.cc

Line 32, Patchset 12 (Latest): SmartCardError::kServiceStopped));

Zgroza (Luke) Klimek . unresolved

I'm not sure whether `kNoService` wouldn't be even better here. This is a situation where there is no PC/SC component and no way to get it. But I don't feel strong about it.

Open in Gerrit

Related details

Attention is currently required from:

Patryk Chodur
Paulina Gacek

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages