[M138-LTS] Fix lifetime issue in InspectorIndexedDBAgent during navigation [chromium/src : refs/branch-heads/7204]

0 views
Skip to first unread message

Andrey Kosyakov (Gerrit)

unread,
Nov 3, 2025, 2:04:54 PM (2 days ago) Nov 3
to Roger Felipe Zanoni da Silva (xWF), Wang Neden, Giovanni Pezzino, Evan Stade, Chromium LUCI CQ, AyeAye, dmurph+wa...@chromium.org, edgesto...@microsoft.com, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, enne...@chromium.org
Attention needed from Evan Stade, Giovanni Pezzino and Roger Felipe Zanoni da Silva (xWF)

Andrey Kosyakov added 2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Andrey Kosyakov . resolved

merge lgtm. I left a drive-by comment because I did not see the original CL, but please land the merge as is.

File third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc
Line 642, Patchset 1 (Latest): request_callback_->sendFailure(protocol::Response::ServerError(
Andrey Kosyakov . unresolved

drive-by: note there's no point in invoking a protocol callback in case the session has been disconnected.

Open in Gerrit

Related details

Attention is currently required from:
  • Evan Stade
  • Giovanni Pezzino
  • Roger Felipe Zanoni da Silva (xWF)
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedLint
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7204
Gerrit-Change-Id: Iec5355c44d27d496eb7274da69ddaf32be9cdfb6
Gerrit-Change-Number: 7026868
Gerrit-PatchSet: 1
Gerrit-Owner: Roger Felipe Zanoni da Silva (xWF) <rza...@google.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Evan Stade <evan...@microsoft.com>
Gerrit-Reviewer: Giovanni Pezzino <gio...@google.com>
Gerrit-Reviewer: Roger Felipe Zanoni da Silva (xWF) <rza...@google.com>
Gerrit-CC: Wang Neden <nede...@gmail.com>
Gerrit-Attention: Evan Stade <evan...@microsoft.com>
Gerrit-Attention: Giovanni Pezzino <gio...@google.com>
Gerrit-Attention: Roger Felipe Zanoni da Silva (xWF) <rza...@google.com>
Gerrit-Comment-Date: Mon, 03 Nov 2025 19:04:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
Nov 3, 2025, 3:07:05 PM (2 days ago) Nov 3
to Roger Felipe Zanoni da Silva (xWF), Wang Neden, Giovanni Pezzino, Evan Stade, Chromium LUCI CQ, AyeAye, dmurph+wa...@chromium.org, edgesto...@microsoft.com, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, enne...@chromium.org
Attention needed from Evan Stade, Giovanni Pezzino and Roger Felipe Zanoni da Silva (xWF)

Andrey Kosyakov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Evan Stade
  • Giovanni Pezzino
  • Roger Felipe Zanoni da Silva (xWF)
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedLint
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7204
Gerrit-Change-Id: Iec5355c44d27d496eb7274da69ddaf32be9cdfb6
Gerrit-Change-Number: 7026868
Gerrit-PatchSet: 1
Gerrit-Owner: Roger Felipe Zanoni da Silva (xWF) <rza...@google.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Evan Stade <evan...@microsoft.com>
Gerrit-Reviewer: Giovanni Pezzino <gio...@google.com>
Gerrit-Reviewer: Roger Felipe Zanoni da Silva (xWF) <rza...@google.com>
Gerrit-CC: Wang Neden <nede...@gmail.com>
Gerrit-Attention: Evan Stade <evan...@microsoft.com>
Gerrit-Attention: Giovanni Pezzino <gio...@google.com>
Gerrit-Attention: Roger Felipe Zanoni da Silva (xWF) <rza...@google.com>
Gerrit-Comment-Date: Mon, 03 Nov 2025 20:06:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Giovanni Pezzino (Gerrit)

unread,
Nov 4, 2025, 4:44:05 AM (yesterday) Nov 4
to Roger Felipe Zanoni da Silva (xWF), Wang Neden, Andrey Kosyakov, Evan Stade, Chromium LUCI CQ, AyeAye, dmurph+wa...@chromium.org, edgesto...@microsoft.com, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, enne...@chromium.org
Attention needed from Evan Stade and Roger Felipe Zanoni da Silva (xWF)

Giovanni Pezzino voted and added 1 comment

Votes added by Giovanni Pezzino

Code-Review+1

1 comment

Patchset-level comments
Giovanni Pezzino . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Evan Stade
  • Roger Felipe Zanoni da Silva (xWF)
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedLint
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7204
    Gerrit-Change-Id: Iec5355c44d27d496eb7274da69ddaf32be9cdfb6
    Gerrit-Change-Number: 7026868
    Gerrit-PatchSet: 1
    Gerrit-Owner: Roger Felipe Zanoni da Silva (xWF) <rza...@google.com>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Evan Stade <evan...@microsoft.com>
    Gerrit-Reviewer: Giovanni Pezzino <gio...@google.com>
    Gerrit-Reviewer: Roger Felipe Zanoni da Silva (xWF) <rza...@google.com>
    Gerrit-CC: Wang Neden <nede...@gmail.com>
    Gerrit-Attention: Evan Stade <evan...@microsoft.com>
    Gerrit-Attention: Roger Felipe Zanoni da Silva (xWF) <rza...@google.com>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 09:43:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages