[protocol] Create targets with CDPConnection instead of transport [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
Nov 5, 2025, 4:35:01 AM (2 days ago) Nov 5
to Devtools-frontend LUCI CQ, Alex Rudenko, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Simon Zünd added 1 comment![]( "Open in Gerrit")
File front_end/core/protocol_client/InspectorBackend.ts
Line 265, Patchset 1 (Latest):
} else {
router = new SessionRouter(new DevToolsCDPConnection(ConnectionTransport.getFactory()()));
}
Simon Zünd . resolved
I'll see if I can get rid of the transport factory all-together now. It would be better if we just create targets/connections/transport from the top-down and not inject it side-ways via the factory.
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Nov 5, 2025, 4:36:45 AM (2 days ago) Nov 5
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
Nov 5, 2025, 4:58:11 AM (2 days ago) Nov 5
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Simon Zünd voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Nov 5, 2025, 5:08:26 AM (2 days ago) Nov 5
to Simon Zünd, Alex Rudenko, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[protocol] Create targets with CDPConnection instead of transport
This is the final piece to the puzzle, now the MCP server can implement
a DevTools CDPConnection of it's own that uses puppeteer under the
hood, and pass it in when creating the root SDK.Target.
R=alexr...@chromium.org
Bug: 453469270
Change-Id: Id733bf66a07c9f5141bcd47d83a260ccc99eb917
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Simon Zünd <szu...@chromium.org>
Files:
- M front_end/core/protocol_client/InspectorBackend.ts
- M front_end/core/sdk/Target.ts
- M front_end/core/sdk/TargetManager.ts
- M front_end/entrypoints/node_app/app/NodeMain.ts
Change size: S
Delta: 4 files changed, 13 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages