Add webmcp cdp domain handler on the browser side [chromium/src : main]
0 views
Skip to first unread message
Philip Pfaffe (Gerrit)
Mar 23, 2026, 5:30:19 AM (yesterday) Mar 23
to Danil Somsikov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Danil Somsikov
Philip Pfaffe added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Danil Somsikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
Mar 23, 2026, 5:35:53 AM (yesterday) Mar 23
to Philip Pfaffe, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Philip Pfaffe
Danil Somsikov added 2 comments![]( "Open in Gerrit")
File chrome/browser/devtools/protocol/webmcp_handler.h
Line 18, Patchset 1 (Latest):
public content::WebContentsObserver {Danil Somsikov . unresolved
Why does it need to be a `WebContentsObserver`?
File chrome/browser/devtools/protocol/webmcp_handler.cc
Line 25, Patchset 1 (Latest):
return protocol::Response::FallThrough();Danil Somsikov . unresolved
Is the fall-though intentional? Please add a code comment explaining why.
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Mar 23, 2026, 10:20:39 AM (22 hours ago) Mar 23
to Danil Somsikov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Danil Somsikov
Philip Pfaffe added 2 comments![]( "Open in Gerrit")
File chrome/browser/devtools/protocol/webmcp_handler.h
Why does it need to be a `WebContentsObserver`?
Philip Pfaffe
From a followup CL, removed it here.
File chrome/browser/devtools/protocol/webmcp_handler.cc
Is the fall-though intentional? Please add a code comment explaining why.
Attention is currently required from:
- Danil Somsikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
Mar 23, 2026, 10:36:31 AM (22 hours ago) Mar 23
to Philip Pfaffe, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Philip Pfaffe
Danil Somsikov added 1 comment![]( "Open in Gerrit")
File chrome/browser/devtools/protocol/webmcp_handler.cc
Line 25, Patchset 3 (Latest):
// necesary.Danil Somsikov . unresolved
Please fix this WARNING reported by Spellchecker: "necesary" is a possible misspelling of "necessary".
To bypass Spellchecker, ad...
"necesary" is a possible misspelling of "necessary".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
Mar 23, 2026, 10:36:39 AM (22 hours ago) Mar 23
to Philip Pfaffe, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Philip Pfaffe
Danil Somsikov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
5:51 AM (2 hours ago) 5:51 AM
to Danil Somsikov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Philip Pfaffe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Pfaffe
| Commit-Queue | +2 |
1 comment
File chrome/browser/devtools/protocol/webmcp_handler.cc
Please fix this WARNING reported by Spellchecker: "necesary" is a possible misspelling of "necessary".
To bypass Spellchecker, ad...
"necesary" is a possible misspelling of "necessary".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
6:10 AM (2 hours ago) 6:10 AM
to Danil Somsikov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Philip Pfaffe voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
7:00 AM (1 hour ago) 7:00 AM
to Philip Pfaffe, Danil Somsikov, chromium...@chromium.org, devtools...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/devtools/protocol/webmcp_handler.cc
Insertions: 3, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Add webmcp cdp domain handler on the browser side
This will host tool call log events for cross document results and
invoking tools.
Bug: 485810761
Change-Id: I1be8026435dbc80cb78bb8601b704afe3cd4b1ed
Commit-Queue: Philip Pfaffe <pfa...@chromium.org>
Reviewed-by: Danil Somsikov <d...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1604013}
Files:
- M chrome/browser/devtools/BUILD.gn
- M chrome/browser/devtools/chrome_devtools_session.cc
- M chrome/browser/devtools/chrome_devtools_session.h
- M chrome/browser/devtools/inspector_protocol_config.json
- A chrome/browser/devtools/protocol/webmcp_handler.cc
- A chrome/browser/devtools/protocol/webmcp_handler.h
Change size: M
Delta: 6 files changed, 86 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Danil Somsikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages