Fix failure conditions [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alex Rudenko (Gerrit)
6:59 AM (3 hours ago) 6:59 AM
to Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Alex Rudenko added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Alex Rudenko . resolved
The test was failing locally and it looks like errors.test.ts was meant to be used here.
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
7:00 AM (3 hours ago) 7:00 AM
to Alex Rudenko, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Philip Pfaffe voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
7:02 AM (3 hours ago) 7:02 AM
to Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Alex Rudenko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
8:10 AM (2 hours ago) 8:10 AM
to Alex Rudenko, Philip Pfaffe, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix failure conditions
Bug: none
Change-Id: Ib8496b2819c5472c075fb466f0c754a644b2412f
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Files:
- M scripts/test_harness.py
Change size: XS
Delta: 1 file changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Philip Pfaffe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages