[protocol] Rename various *Connection classes to *Transport [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Simon Zünd (Gerrit)

unread,
Nov 4, 2025, 12:43:10 AM (yesterday) Nov 4
to Devtools-frontend LUCI CQ, Benedikt Meurer, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Benedikt Meurer
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2d7266081a119758a4687d7f419e3a24ea87b49a
Gerrit-Change-Number: 7116099
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 05:43:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Benedikt Meurer (Gerrit)

unread,
Nov 4, 2025, 1:57:38 AM (yesterday) Nov 4
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd

Benedikt Meurer voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Simon Zünd
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2d7266081a119758a4687d7f419e3a24ea87b49a
Gerrit-Change-Number: 7116099
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 06:57:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Simon Zünd (Gerrit)

unread,
Nov 4, 2025, 1:58:06 AM (yesterday) Nov 4
to Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Simon Zünd voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2d7266081a119758a4687d7f419e3a24ea87b49a
Gerrit-Change-Number: 7116099
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Tue, 04 Nov 2025 06:58:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
Nov 4, 2025, 1:59:59 AM (yesterday) Nov 4
to Simon Zünd, Benedikt Meurer, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
[protocol] Rename various *Connection classes to *Transport

We added a new layer inbetween "transport" and "session management":
The CDPConnection interface. This CL renames existing transport
implementations to better reflect what they really are.

R=bme...@chromium.org
Bug: 453469270
Change-Id: I2d7266081a119758a4687d7f419e3a24ea87b49a
Reviewed-by: Benedikt Meurer <bme...@chromium.org>
Commit-Queue: Simon Zünd <szu...@chromium.org>
Files:
  • M front_end/core/sdk/Connections.ts
  • M front_end/core/sdk/RehydratingConnection.test.ts
  • M front_end/core/sdk/RehydratingConnection.ts
  • M front_end/testing/MockConnection.ts
Change size: S
Delta: 4 files changed, 12 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Benedikt Meurer
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2d7266081a119758a4687d7f419e3a24ea87b49a
Gerrit-Change-Number: 7116099
Gerrit-PatchSet: 2
Gerrit-Owner: Simon Zünd <szu...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages