Refactor FakeBluetooth implementation to outside bluetooth/test [chromium/src : main]

0 views
Skip to first unread message

Alex N. Jose (Gerrit)

unread,
Jul 2, 2024, 4:57:49 PMJul 2
to Matt Reynolds, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Attention needed from Matt Reynolds and Reilly Grant

Alex N. Jose voted and added 1 comment

Votes added by Alex N. Jose

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Alex N. Jose . resolved

mattreynolds@, reillyg@, this is the second refactor (2 of 2 planned) that should unblock CDP API implementation, moving bluetooth/test* dependencies outside the test/ folder.

This CL currently moves the minimal tree/dependency. There are however a lot more (disconnected) `test/fake_*` files that potentially can move along with it. Should I go ahead and refactor further to move all of them? LMK.

Open in Gerrit

Related details

Attention is currently required from:
  • Matt Reynolds
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
Gerrit-Change-Number: 5673025
Gerrit-PatchSet: 3
Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 20:57:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jul 2, 2024, 5:25:50 PMJul 2
to Alex N. Jose, Chromium IPC Reviews, Juliet Lévesque, Daniel Cheng, Matt Reynolds, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Attention needed from Daniel Cheng, Juliet Lévesque, Matt Reynolds and Reilly Grant

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
Shadow: julietl...@google.com; IPC: dch...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

Shadow IPC reviewer(s): julietl...@google.com. Please conduct an IPC review and CR+1 when satisfied. Remember to add the main reviewers to the attention set if needed.

Main IPC reviewer(s): dch...@chromium.org. Please wait for the shadowed IPC reviewer to CR+1 before reviewing.

Shadowed: julietl...@google.com

Reviewer source(s):
dch...@chromium.org, julietl...@google.com is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Juliet Lévesque
  • Matt Reynolds
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
Gerrit-Change-Number: 5673025
Gerrit-PatchSet: 3
Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Juliet Lévesque <julietl...@google.com>
Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Juliet Lévesque <julietl...@google.com>
Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 21:25:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Reilly Grant (Gerrit)

unread,
Jul 2, 2024, 6:09:32 PMJul 2
to Alex N. Jose, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, Daniel Cheng, Matt Reynolds, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
Attention needed from Alex N. Jose, Daniel Cheng, Juliet Lévesque and Matt Reynolds

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review+1

1 comment

Patchset-level comments
Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Alex N. Jose
  • Daniel Cheng
  • Juliet Lévesque
  • Matt Reynolds
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
    Gerrit-Change-Number: 5673025
    Gerrit-PatchSet: 3
    Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
    Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Juliet Lévesque <julietl...@google.com>
    Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Attention: Juliet Lévesque <julietl...@google.com>
    Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>
    Gerrit-Attention: Alex N. Jose <ale...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Jul 2024 22:09:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Matt Reynolds (Gerrit)

    unread,
    Jul 2, 2024, 6:25:03 PMJul 2
    to Alex N. Jose, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
    Attention needed from Alex N. Jose, Daniel Cheng and Juliet Lévesque

    Matt Reynolds voted and added 1 comment

    Votes added by Matt Reynolds

    Code-Review+1

    1 comment

    Commit Message
    Line 14, Patchset 3 (Latest):* Rename bluetoth/../mojom/test to bluetoth/../mojom/emulation
    Matt Reynolds . unresolved

    ```

    • Rename bluetooth/../mojom/test to bluetooth/../mojom/emulation
    • ```
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex N. Jose
    • Daniel Cheng
    • Juliet Lévesque
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
      Gerrit-Change-Number: 5673025
      Gerrit-PatchSet: 3
      Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
      Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Juliet Lévesque <julietl...@google.com>
      Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Attention: Juliet Lévesque <julietl...@google.com>
      Gerrit-Attention: Alex N. Jose <ale...@chromium.org>
      Gerrit-Comment-Date: Tue, 02 Jul 2024 22:24:50 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Alex N. Jose (Gerrit)

      unread,
      Jul 2, 2024, 7:57:23 PMJul 2
      to Gary Tong, Matt Reynolds, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
      Attention needed from Daniel Cheng, Gary Tong and Juliet Lévesque

      Alex N. Jose added 1 comment

      Commit Message
      Line 14, Patchset 3:* Rename bluetoth/../mojom/test to bluetoth/../mojom/emulation
      Matt Reynolds . resolved

      ```

      • Rename bluetooth/../mojom/test to bluetooth/../mojom/emulation
      • ```
      Alex N. Jose

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      • Gary Tong
      • Juliet Lévesque
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
      Gerrit-Change-Number: 5673025
      Gerrit-PatchSet: 4
      Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
      Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
      Gerrit-Reviewer: Juliet Lévesque <julietl...@google.com>
      Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Attention: Juliet Lévesque <julietl...@google.com>
      Gerrit-Attention: Gary Tong <gat...@chromium.org>
      Gerrit-Comment-Date: Tue, 02 Jul 2024 23:57:06 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Matt Reynolds <mattre...@chromium.org>
      satisfied_requirement
      open
      diffy

      Daniel Cheng (Gerrit)

      unread,
      Jul 2, 2024, 8:23:44 PMJul 2
      to Alex N. Jose, Daniel Cheng, Mike West, Gary Tong, Matt Reynolds, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
      Attention needed from Alex N. Jose, Gary Tong, Juliet Lévesque and Mike West

      Daniel Cheng voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alex N. Jose
      • Gary Tong
      • Juliet Lévesque
      • Mike West
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
      Gerrit-Change-Number: 5673025
      Gerrit-PatchSet: 4
      Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
      Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
      Gerrit-Reviewer: Juliet Lévesque <julietl...@google.com>
      Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
      Gerrit-Reviewer: Mike West <mk...@chromium.org>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Juliet Lévesque <julietl...@google.com>
      Gerrit-Attention: Gary Tong <gat...@chromium.org>
      Gerrit-Attention: Mike West <mk...@chromium.org>
      Gerrit-Attention: Alex N. Jose <ale...@chromium.org>
      Gerrit-Comment-Date: Wed, 03 Jul 2024 00:23:31 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Vincent Scheib (Gerrit)

      unread,
      Jul 3, 2024, 2:46:21 PMJul 3
      to Alex N. Jose, Vincent Scheib, Daniel Cheng, Mike West, Gary Tong, Matt Reynolds, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
      Attention needed from Alex N. Jose, Gary Tong, Juliet Lévesque and Mike West

      Vincent Scheib added 1 comment

      File content/browser/bluetooth/README.md
      Line 73, Patchset 4 (Latest):../../../device/bluetooth/emulation/fake_bluetooth.h
      Vincent Scheib . unresolved

      Reference also in device/bluetooth/test/README.md

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alex N. Jose
      • Gary Tong
      • Juliet Lévesque
      • Mike West
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
        Gerrit-Change-Number: 5673025
        Gerrit-PatchSet: 4
        Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
        Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
        Gerrit-Reviewer: Juliet Lévesque <julietl...@google.com>
        Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
        Gerrit-Reviewer: Mike West <mk...@chromium.org>
        Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
        Gerrit-CC: Vincent Scheib <sch...@chromium.org>
        Gerrit-CC: gwsq
        Gerrit-Attention: Juliet Lévesque <julietl...@google.com>
        Gerrit-Attention: Gary Tong <gat...@chromium.org>
        Gerrit-Attention: Mike West <mk...@chromium.org>
        Gerrit-Attention: Alex N. Jose <ale...@chromium.org>
        Gerrit-Comment-Date: Wed, 03 Jul 2024 18:46:09 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Mike West (Gerrit)

        unread,
        Jul 5, 2024, 2:33:16 AMJul 5
        to Alex N. Jose, Vincent Scheib, Daniel Cheng, Gary Tong, Matt Reynolds, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
        Attention needed from Alex N. Jose, Gary Tong and Juliet Lévesque

        Mike West voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alex N. Jose
        • Gary Tong
        • Juliet Lévesque
        Gerrit-Attention: Alex N. Jose <ale...@chromium.org>
        Gerrit-Comment-Date: Fri, 05 Jul 2024 06:33:04 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Gary Tong (Gerrit)

        unread,
        Jul 7, 2024, 9:50:42 PMJul 7
        to Alex N. Jose, Mike West, Vincent Scheib, Daniel Cheng, Matt Reynolds, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
        Attention needed from Alex N. Jose and Juliet Lévesque

        Gary Tong voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alex N. Jose
        • Juliet Lévesque
        Gerrit-Attention: Alex N. Jose <ale...@chromium.org>
        Gerrit-Comment-Date: Mon, 08 Jul 2024 01:50:28 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Alex N. Jose (Gerrit)

        unread,
        Jul 8, 2024, 10:43:42 AMJul 8
        to Gary Tong, Mike West, Vincent Scheib, Daniel Cheng, Matt Reynolds, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
        Attention needed from Alex N. Jose, Daniel Cheng, Gary Tong, Juliet Lévesque, Matt Reynolds, Mike West, Reilly Grant and Vincent Scheib

        Alex N. Jose voted and added 2 comments

        Votes added by Alex N. Jose

        Commit-Queue+1

        2 comments

        Patchset-level comments
        Alex N. Jose . resolved

        Updated test/README references. +1s got outdated, PTAL.

        File content/browser/bluetooth/README.md
        Line 73, Patchset 4:../../../device/bluetooth/emulation/fake_bluetooth.h
        Vincent Scheib . resolved

        Reference also in device/bluetooth/test/README.md

        Alex N. Jose

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alex N. Jose
        • Daniel Cheng
        • Gary Tong
        • Juliet Lévesque
        • Matt Reynolds
        • Mike West
        • Reilly Grant
        • Vincent Scheib
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Review
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
        Gerrit-Change-Number: 5673025
        Gerrit-PatchSet: 5
        Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
        Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
        Gerrit-Reviewer: Juliet Lévesque <julietl...@google.com>
        Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
        Gerrit-Reviewer: Mike West <mk...@chromium.org>
        Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
        Gerrit-CC: Vincent Scheib <sch...@chromium.org>
        Gerrit-CC: gwsq
        Gerrit-Attention: Vincent Scheib <sch...@chromium.org>
        Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
        Gerrit-Attention: Reilly Grant <rei...@chromium.org>
        Gerrit-Attention: Juliet Lévesque <julietl...@google.com>
        Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>
        Gerrit-Attention: Gary Tong <gat...@chromium.org>
        Gerrit-Attention: Mike West <mk...@chromium.org>
        Gerrit-Attention: Alex N. Jose <ale...@chromium.org>
        Gerrit-Comment-Date: Mon, 08 Jul 2024 14:43:30 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Vincent Scheib <sch...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Daniel Cheng (Gerrit)

        unread,
        Jul 8, 2024, 11:41:40 AMJul 8
        to Alex N. Jose, Daniel Cheng, Gary Tong, Mike West, Vincent Scheib, Matt Reynolds, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
        Attention needed from Alex N. Jose, Gary Tong, Juliet Lévesque, Matt Reynolds, Mike West, Reilly Grant and Vincent Scheib

        Daniel Cheng voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alex N. Jose
        • Gary Tong
        • Juliet Lévesque
        • Matt Reynolds
        • Mike West
        • Reilly Grant
        • Vincent Scheib
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Review
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
          Gerrit-Change-Number: 5673025
          Gerrit-PatchSet: 6
          Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
          Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
          Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
          Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
          Gerrit-Reviewer: Juliet Lévesque <julietl...@google.com>
          Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
          Gerrit-Reviewer: Mike West <mk...@chromium.org>
          Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          Gerrit-CC: Vincent Scheib <sch...@chromium.org>
          Gerrit-CC: gwsq
          Gerrit-Attention: Vincent Scheib <sch...@chromium.org>
          Gerrit-Attention: Reilly Grant <rei...@chromium.org>
          Gerrit-Attention: Juliet Lévesque <julietl...@google.com>
          Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>
          Gerrit-Attention: Gary Tong <gat...@chromium.org>
          Gerrit-Attention: Mike West <mk...@chromium.org>
          Gerrit-Attention: Alex N. Jose <ale...@chromium.org>
          Gerrit-Comment-Date: Mon, 08 Jul 2024 15:41:24 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Matt Reynolds (Gerrit)

          unread,
          Jul 8, 2024, 8:50:23 PM (14 days ago) Jul 8
          to Alex N. Jose, Daniel Cheng, Gary Tong, Mike West, Vincent Scheib, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
          Attention needed from Alex N. Jose, Gary Tong, Juliet Lévesque, Mike West, Reilly Grant and Vincent Scheib

          Matt Reynolds voted and added 1 comment

          Votes added by Matt Reynolds

          Code-Review+1

          1 comment

          Patchset-level comments
          File-level comment, Patchset 6 (Latest):
          Matt Reynolds . resolved

          re-lgtm

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Alex N. Jose
          • Gary Tong
          • Juliet Lévesque
          Gerrit-Attention: Gary Tong <gat...@chromium.org>
          Gerrit-Attention: Mike West <mk...@chromium.org>
          Gerrit-Attention: Alex N. Jose <ale...@chromium.org>
          Gerrit-Comment-Date: Tue, 09 Jul 2024 00:50:12 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Alex N. Jose (Gerrit)

          unread,
          Jul 8, 2024, 8:54:09 PM (14 days ago) Jul 8
          to Matt Reynolds, Daniel Cheng, Gary Tong, Mike West, Vincent Scheib, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org
          Attention needed from Gary Tong, Juliet Lévesque, Mike West, Reilly Grant and Vincent Scheib

          Alex N. Jose voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention is currently required from:
          Gerrit-Comment-Date: Tue, 09 Jul 2024 00:53:57 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Jul 8, 2024, 8:58:03 PM (14 days ago) Jul 8
          to Alex N. Jose, Matt Reynolds, Daniel Cheng, Gary Tong, Mike West, Vincent Scheib, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org

          Chromium LUCI CQ submitted the change

          Change information

          Commit message:
          Refactor FakeBluetooth implementation to outside bluetooth/test

          As a precursor to introducing FakeBluetooth CDP API support
          (crrev.com/c/5559106), this CL refactors the core of FakeBluetooth
          implementation to outside bluetooth/test and into a separate
          bluetooth/emulation to allow wider usage.
          * Move essential fake_bluetooth functionality into bluetooth/emulation/
          * Rename bluetooth/../mojom/test to bluetooth/../mojom/emulation
          Bug: 342191615
          Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
          Reviewed-by: Daniel Cheng <dch...@chromium.org>
          Commit-Queue: Alex N. Jose <ale...@chromium.org>
          Reviewed-by: Matt Reynolds <mattre...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1324602}
          Files:
          • M content/browser/bluetooth/README.md
          • M content/web_test/browser/web_test_content_browser_client.cc
          • M device/bluetooth/BUILD.gn
          • R device/bluetooth/emulation/fake_bluetooth.cc
          • R device/bluetooth/emulation/fake_bluetooth.h
          • R device/bluetooth/emulation/fake_central.cc
          • R device/bluetooth/emulation/fake_central.h
          • R device/bluetooth/emulation/fake_peripheral.cc
          • R device/bluetooth/emulation/fake_peripheral.h
          • R device/bluetooth/emulation/fake_read_response.cc
          • R device/bluetooth/emulation/fake_read_response.h
          • R device/bluetooth/emulation/fake_remote_gatt_characteristic.cc
          • R device/bluetooth/emulation/fake_remote_gatt_characteristic.h
          • R device/bluetooth/emulation/fake_remote_gatt_descriptor.cc
          • R device/bluetooth/emulation/fake_remote_gatt_descriptor.h
          • R device/bluetooth/emulation/fake_remote_gatt_service.cc
          • R device/bluetooth/emulation/fake_remote_gatt_service.h
          • M device/bluetooth/public/mojom/BUILD.gn
          • R device/bluetooth/public/mojom/emulation/OWNERS
          • R device/bluetooth/public/mojom/emulation/README.md
          • R device/bluetooth/public/mojom/emulation/fake_bluetooth.mojom
          • R device/bluetooth/public/mojom/emulation/fake_bluetooth_mojom_traits.h
          • M device/bluetooth/test/README.md
          • M infra/archive_config/linux-archive-rel.json
          • M third_party/blink/web_tests/external/wpt/resources/chromium/web-bluetooth-test.js
          • M third_party/blink/web_tests/http/tests/inspector-protocol/device-access/resources/bluetooth-test.js
          • M third_party/blink/web_tests/wpt_internal/bluetooth/README.md
          Change size: M
          Delta: 27 files changed, 115 insertions(+), 108 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Daniel Cheng, +1 by Matt Reynolds
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
          Gerrit-Change-Number: 5673025
          Gerrit-PatchSet: 7
          Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
          Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
          Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
          Gerrit-Reviewer: Juliet Lévesque <julietl...@google.com>
          Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
          Gerrit-Reviewer: Mike West <mk...@chromium.org>
          Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          open
          diffy
          satisfied_requirement

          Vincent Scheib (Gerrit)

          unread,
          Jul 8, 2024, 8:59:15 PM (14 days ago) Jul 8
          to Chromium LUCI CQ, Alex N. Jose, Vincent Scheib, Matt Reynolds, Daniel Cheng, Gary Tong, Mike West, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org

          Vincent Scheib voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention set is empty
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Review
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
          Gerrit-Change-Number: 5673025
          Gerrit-PatchSet: 7
          Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
          Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
          Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
          Gerrit-Reviewer: Juliet Lévesque <julietl...@google.com>
          Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
          Gerrit-Reviewer: Mike West <mk...@chromium.org>
          Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
          Gerrit-Reviewer: Vincent Scheib <sch...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          Gerrit-CC: gwsq
          Gerrit-Comment-Date: Tue, 09 Jul 2024 00:59:04 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Blink W3C Test Autoroller (Gerrit)

          unread,
          Jul 8, 2024, 8:59:35 PM (14 days ago) Jul 8
          to Chromium LUCI CQ, Alex N. Jose, Vincent Scheib, Matt Reynolds, Daniel Cheng, Gary Tong, Mike West, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org

          Message from Blink W3C Test Autoroller

          Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/47047.

          When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

          WPT Export docs:
          https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

          Open in Gerrit

          Related details

          Attention set is empty
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Review
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: If5e2340e07dde07bc644e3e496ff584736067b0b
          Gerrit-Change-Number: 5673025
          Gerrit-PatchSet: 7
          Gerrit-Owner: Alex N. Jose <ale...@chromium.org>
          Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
          Gerrit-Reviewer: Gary Tong <gat...@chromium.org>
          Gerrit-Reviewer: Juliet Lévesque <julietl...@google.com>
          Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
          Gerrit-Reviewer: Mike West <mk...@chromium.org>
          Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
          Gerrit-Reviewer: Vincent Scheib <sch...@chromium.org>
          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          Gerrit-CC: gwsq
          Gerrit-Comment-Date: Tue, 09 Jul 2024 00:59:24 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy

          Blink W3C Test Autoroller (Gerrit)

          unread,
          Jul 8, 2024, 9:49:32 PM (14 days ago) Jul 8
          to Chromium LUCI CQ, Alex N. Jose, Vincent Scheib, Matt Reynolds, Daniel Cheng, Gary Tong, Mike West, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org

          Message from Blink W3C Test Autoroller

          The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/47047

          Gerrit-Comment-Date: Tue, 09 Jul 2024 01:49:21 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy

          Rey - Ban (Gerrit)

          unread,
          Jul 9, 2024, 2:50:51 AM (13 days ago) Jul 9
          to Chromium LUCI CQ, Alex N. Jose, Rey - Ban, Blink W3C Test Autoroller, Vincent Scheib, Matt Reynolds, Daniel Cheng, Gary Tong, Mike West, Reilly Grant, Chromium IPC Reviews, Juliet Lévesque, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, mattreyno...@chromium.org, odejesu...@chromium.org

          Rey - Ban added 1 comment

          Patchset-level comments
          File-level comment, Patchset 7 (Latest):
          Rey - Ban . resolved

          Hello World♡♡♡

          Gerrit-CC: Rey - Ban <erhenb...@gmail.com>
          Gerrit-CC: gwsq
          Gerrit-Comment-Date: Tue, 09 Jul 2024 06:50:40 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages