Commit-Queue | +1 |
mattreynolds@, reillyg@, this is the second refactor (2 of 2 planned) that should unblock CDP API implementation, moving bluetooth/test* dependencies outside the test/ folder.
This CL currently moves the minimal tree/dependency. There are however a lot more (disconnected) `test/fake_*` files that potentially can move along with it. Should I go ahead and refactor further to move all of them? LMK.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
Shadow: julietl...@google.com; IPC: dch...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
Shadow IPC reviewer(s): julietl...@google.com. Please conduct an IPC review and CR+1 when satisfied. Remember to add the main reviewers to the attention set if needed.
Main IPC reviewer(s): dch...@chromium.org. Please wait for the shadowed IPC reviewer to CR+1 before reviewing.
Shadowed: julietl...@google.com
Reviewer source(s):
dch...@chromium.org, julietl...@google.com is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
* Rename bluetoth/../mojom/test to bluetoth/../mojom/emulation
```
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
* Rename bluetoth/../mojom/test to bluetoth/../mojom/emulation
Alex N. Jose```
- Rename bluetooth/../mojom/test to bluetooth/../mojom/emulation
- ```
Done
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
../../../device/bluetooth/emulation/fake_bluetooth.h
Reference also in device/bluetooth/test/README.md
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
Code-Review | +1 |
Commit-Queue | +1 |
Updated test/README references. +1s got outdated, PTAL.
../../../device/bluetooth/emulation/fake_bluetooth.h
Alex N. JoseReference also in device/bluetooth/test/README.md
Done
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
Refactor FakeBluetooth implementation to outside bluetooth/test
As a precursor to introducing FakeBluetooth CDP API support
(crrev.com/c/5559106), this CL refactors the core of FakeBluetooth
implementation to outside bluetooth/test and into a separate
bluetooth/emulation to allow wider usage.
* Move essential fake_bluetooth functionality into bluetooth/emulation/
* Rename bluetooth/../mojom/test to bluetooth/../mojom/emulation
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/47047.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/47047