Fix live expression edit field tab keymap to respect MAX 2.1.1 [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Natasha Lee (Gerrit)
Jun 28, 2024, 1:57:57 PMJun 28
to Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Mathias Bynens
Natasha Lee added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Natasha Lee . resolved
Hi Mathias, can you help review this PR or suggest reviewers for this PR to fix keyboard accessibility issue for live expression edit field. thank you!!
Related details
Attention is currently required from:
- Mathias Bynens
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Natasha Lee (Gerrit)
Jul 2, 2024, 12:36:46 PMJul 2
to Changhao Han, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Changhao Han
Natasha Lee added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Natasha Lee . resolved
hi Changhao, friendly ping on this CL thank you 😊
Related details
Attention is currently required from:
- Changhao Han
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Changhao Han (Gerrit)
Jul 2, 2024, 6:17:46 PMJul 2
to Natasha Lee, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Natasha Lee
Changhao Han voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Natasha Lee
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Changhao Han (Gerrit)
Jul 2, 2024, 6:18:02 PMJul 2
to Natasha Lee, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Natasha Lee
Changhao Han added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Changhao Han . resolved
Hi sorry for the late reply. This LGTM, thanks!
Related details
Attention is currently required from:
- Natasha Lee
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Changhao Han (Gerrit)
Jul 2, 2024, 6:18:04 PMJul 2
to Natasha Lee, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Natasha Lee
Changhao Han voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Natasha Lee
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Jul 2, 2024, 7:03:33 PMJul 2
to Natasha Lee, Changhao Han, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix live expression edit field tab keymap to respect MAX 2.1.1
before: clicking tab after auto-completion would just indent the text
after: clicking tab after auto-completion exits edit field and focus on next focus point
Bug: 349939551
Change-Id: I68a2e7f869a23087e01f8e3288a934c12c509f7a
Reviewed-by: Changhao Han <chang...@chromium.org>
Commit-Queue: Changhao Han <chang...@chromium.org>
Files:
- M front_end/panels/console/ConsolePinPane.ts
Change size: S
Delta: 1 file changed, 12 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Changhao Han
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages