Fix double-flash during checkbox toggles [devtools/devtools-frontend : main]

[Philip Pfaffe (Gerrit)]

Attention needed from Danil Somsikov

Philip Pfaffe voted and added 1 comment

Votes added by Philip Pfaffe

Code-Review

+1

1 comment

File test/e2e/elements/style-flash.test.ts

Line 55, Patchset 13 (Latest): await new Promise(r => setTimeout(r, 1000));

Philip Pfaffe . unresolved

The timeouts are a bit heavy, any way we can wait for a proper signal?

Open in Gerrit

Related details

Attention is currently required from:

• Danil Somsikov

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: I2239f0fc85fdf9a55bb041244a911d1a7927d230

Gerrit-Change-Number: 8266539

Gerrit-PatchSet: 13

Gerrit-Owner: Danil Somsikov <d...@chromium.org>

Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: devtools-fro...@luci-project-accounts.iam.gserviceaccount.com <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Danil Somsikov <d...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Aug 2026 11:52:06 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes