Remove obsolete 3pcd feature setting in tests [chromium/src : main]

0 views
Skip to first unread message

Fiona Macintosh (Gerrit)

unread,
Dec 29, 2025, 10:25:37 AM (yesterday) Dec 29
to chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Rijubrata Bhaumik, bmcquad...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, csharris...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, gavin...@chromium.org, jdonnel...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, omnibox-...@chromium.org, rrsilva+wat...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org

Fiona Macintosh voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I496a306a990347fa4c3c103b067b2067207d2362
Gerrit-Change-Number: 7353320
Gerrit-PatchSet: 1
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Dec 2025 15:25:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fiona Macintosh (Gerrit)

unread,
Dec 29, 2025, 10:45:08 AM (yesterday) Dec 29
to Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Rijubrata Bhaumik, bmcquad...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, csharris...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, gavin...@chromium.org, jdonnel...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, omnibox-...@chromium.org, rrsilva+wat...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org

Fiona Macintosh voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I496a306a990347fa4c3c103b067b2067207d2362
Gerrit-Change-Number: 7353320
Gerrit-PatchSet: 2
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Dec 2025 15:45:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kevin Graney (Gerrit)

unread,
Dec 29, 2025, 11:30:34 AM (yesterday) Dec 29
to Fiona Macintosh, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Rijubrata Bhaumik, bmcquad...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, csharris...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, gavin...@chromium.org, jdonnel...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, omnibox-...@chromium.org, rrsilva+wat...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org
Attention needed from Fiona Macintosh

Kevin Graney voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fiona Macintosh
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I496a306a990347fa4c3c103b067b2067207d2362
    Gerrit-Change-Number: 7353320
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Kevin Graney <k...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Comment-Date: Mon, 29 Dec 2025 16:30:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    Dec 29, 2025, 1:17:43 PM (yesterday) Dec 29
    to Fiona Macintosh, Avi Drissman, Kevin Graney, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Rijubrata Bhaumik, bmcquad...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, csharris...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, gavin...@chromium.org, jdonnel...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, omnibox-...@chromium.org, rrsilva+wat...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org
    Attention needed from Fiona Macintosh

    Avi Drissman voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fiona Macintosh
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I496a306a990347fa4c3c103b067b2067207d2362
    Gerrit-Change-Number: 7353320
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Kevin Graney <k...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Comment-Date: Mon, 29 Dec 2025 18:17:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Fiona Macintosh (Gerrit)

    unread,
    Dec 29, 2025, 1:22:24 PM (yesterday) Dec 29
    to Avi Drissman, Kevin Graney, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Rijubrata Bhaumik, bmcquad...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, csharris...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, gavin...@chromium.org, jdonnel...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, omnibox-...@chromium.org, rrsilva+wat...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org

    Fiona Macintosh voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I496a306a990347fa4c3c103b067b2067207d2362
    Gerrit-Change-Number: 7353320
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Kevin Graney <k...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Dec 2025 18:22:16 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 29, 2025, 2:50:16 PM (yesterday) Dec 29
    to Fiona Macintosh, Avi Drissman, Kevin Graney, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, Rijubrata Bhaumik, bmcquad...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, csharris...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, gavin...@chromium.org, jdonnel...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, omnibox-...@chromium.org, rrsilva+wat...@google.com, speed-metrics...@chromium.org, speed-metr...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    2 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: chrome/browser/privacy_sandbox/privacy_sandbox_settings_delegate_unittest.cc
    Insertions: 0, Deletions: 346.

    The diff is too large to show. Please review the diff.
    ```

    Change information

    Commit message:
    Remove obsolete 3pcd feature setting in tests

    Due to 3pcd cleanup this feature no longer needs to be set
    Change-Id: I496a306a990347fa4c3c103b067b2067207d2362
    Reviewed-by: Kevin Graney <k...@google.com>
    Commit-Queue: Fiona Macintosh <fmaci...@google.com>
    Reviewed-by: Avi Drissman <a...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1563198}
    Files:
    • M chrome/browser/chrome_content_browser_client_browsertest.cc
    • M chrome/browser/first_party_sets/first_party_sets_policy_browsertest.cc
    • M chrome/browser/media/media_engagement_browsertest.cc
    • M chrome/browser/net/websocket_browsertest.cc
    • M chrome/browser/optimization_guide/hints_fetcher_browsertest.cc
    • M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
    • M chrome/browser/preloading/prefetch/no_state_prefetch/prerender_nostate_prefetch_browsertest.cc
    • M chrome/browser/privacy_sandbox/privacy_sandbox_settings_delegate_unittest.cc
    • M chrome/browser/storage_access_api/api_browsertest.cc
    • M chrome/browser/top_level_storage_access_api/request_storage_access_for_browsertest.cc
    • M chrome/browser/tpcd/experiment/tpcd_mitigations_browsertest.cc
    • M chrome/browser/tpcd/http_error_observer/http_error_tab_helper_browsertest.cc
    • M chrome/browser/tpcd/metadata/devtools_observer_browsertest.cc
    • M chrome/browser/ui/cookie_controls/roll_back_mode_b_infobar_controller_browsertest.cc
    • M chrome/browser/ui/login/login_handler_browsertest.cc
    • M chrome/browser/ui/views/location_bar/content_setting_bubble_dialog_browsertest.cc
    • M chrome/browser/ui/views/site_data/page_specific_site_data_dialog_browsertest.cc
    • M chrome/test/data/webui/settings/settings_browsertest.cc
    Change size: M
    Delta: 18 files changed, 40 insertions(+), 171 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Avi Drissman, +1 by Kevin Graney
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I496a306a990347fa4c3c103b067b2067207d2362
    Gerrit-Change-Number: 7353320
    Gerrit-PatchSet: 4
    Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Kevin Graney <k...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages