[debug] Convert usages of FixedArray::length to ulength [v8/v8 : main]
Arash Kazemi (Gerrit)
Arash Kazemi voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Omer Katz
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Omer Katz voted and added 1 comment![]( "Open in Gerrit")
- Arash Kazemi
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Omer Katz added 1 comment![]( "Open in Gerrit")
- Arash Kazemi
- Jakob Linke
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Jakob Linke voted and added 3 comments![]( "Open in Gerrit")
Votes added by Jakob Linke
| Code-Review | +1 |
3 comments
uint32_t keys_len = keys->ulength().value();q: `SafeHeapObjectSize` is just for porting and ulength will return a plain uint32_t once done?
int lines_end_len = static_cast<int>(line_ends->ulength().value());Why not uint32_t here too? And addtl a `DCHECK_GT(lines_end_len, 0)` for the subtractions below.
return values->ulength().value() - 2;DCHECK_GE(.., 2)
Related details
- Arash Kazemi
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arash Kazemi (Gerrit)
Arash Kazemi added 3 comments![]( "Open in Gerrit")
uint32_t keys_len = keys->ulength().value();q: `SafeHeapObjectSize` is just for porting and ulength will return a plain uint32_t once done?
The idea would be to keep `SafeHeapObjectSize` (renamed to something more generic) at least until implicit casts warnings can be enabled on the codebase. This way all callsites have to be more explicit when handling lengths by calling `.value()`. Of course, you could also end up writing `int something = length().value()` but it should hopefully be less likely.
int lines_end_len = static_cast<int>(line_ends->ulength().value());Why not uint32_t here too? And addtl a `DCHECK_GT(lines_end_len, 0)` for the subtractions below.
Done
return values->ulength().value() - 2;Arash KazemiDCHECK_GE(.., 2)
Done
Related details
- Jakob Linke
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Jakob Linke voted and added 3 comments![]( "Open in Gerrit")
Votes added by Jakob Linke
| Code-Review | +1 |
3 comments
uint32_t keys_len = keys->ulength().value();Arash Kazemiq: `SafeHeapObjectSize` is just for porting and ulength will return a plain uint32_t once done?
The idea would be to keep `SafeHeapObjectSize` (renamed to something more generic) at least until implicit casts warnings can be enabled on the codebase. This way all callsites have to be more explicit when handling lengths by calling `.value()`. Of course, you could also end up writing `int something = length().value()` but it should hopefully be less likely.
I see.
Of course, you could also end up writing int something = length().value() but it should hopefully be less likely.
Yeah exactly; I hope we're going in the right direction here wrt preventing mistakes vs. readable/simple code. Personally I'd much rather work with plain uint32_t.
return Just(GetSmiValue(line_ends, lines_end_len - 1));nit: There's one more here.
Related details
- Arash Kazemi
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arash Kazemi (Gerrit)
Arash Kazemi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Arash Kazemi
| Commit-Queue | +1 |
1 comment
nit: There's one more here.
- Jakob Linke
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Omer Katz voted Code-Review+1![]( "Open in Gerrit")
- Arash Kazemi
- Jakob Linke
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |