Generate console insights teasers with BuiltInAi [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Wolfgang Beyer (Gerrit)

unread,
Oct 13, 2025, 8:02:29 AM (18 hours ago) Oct 13
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko

Wolfgang Beyer voted and added 1 comment

Votes added by Wolfgang Beyer

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Wolfgang Beyer . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I5c661f4446a7ae4eeb8ae5152c221928e7461b72
Gerrit-Change-Number: 7035634
Gerrit-PatchSet: 2
Gerrit-Owner: Wolfgang Beyer <wo...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Wolfgang Beyer <wo...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Oct 2025 12:02:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
Oct 13, 2025, 2:19:37 PM (12 hours ago) Oct 13
to Wolfgang Beyer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Wolfgang Beyer

Alex Rudenko added 3 comments

File front_end/panels/console/ConsoleInsightTeaser.test.ts
Line 43, Patchset 2 (Latest): window.LanguageModel = {
Alex Rudenko . unresolved

let's clean up this after the test and restore the original window.LanguageModel.

Line 67, Patchset 2 (Latest): AiAssistanceModel.BuiltInAi.removeInstance();
Alex Rudenko . unresolved

let's clean this up after the test?

File front_end/panels/console/ConsoleInsightTeaser.ts
Line 35, Patchset 2 (Latest): headerText: String|null;
Alex Rudenko . unresolved

I think the type should be `string` here and below?

Open in Gerrit

Related details

Attention is currently required from:
  • Wolfgang Beyer
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I5c661f4446a7ae4eeb8ae5152c221928e7461b72
    Gerrit-Change-Number: 7035634
    Gerrit-PatchSet: 2
    Gerrit-Owner: Wolfgang Beyer <wo...@chromium.org>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Wolfgang Beyer <wo...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Wolfgang Beyer <wo...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Oct 2025 18:19:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Rudenko (Gerrit)

    unread,
    Oct 13, 2025, 2:19:56 PM (12 hours ago) Oct 13
    to Wolfgang Beyer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
    Attention needed from Wolfgang Beyer

    Alex Rudenko voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Wolfgang Beyer
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I5c661f4446a7ae4eeb8ae5152c221928e7461b72
    Gerrit-Change-Number: 7035634
    Gerrit-PatchSet: 2
    Gerrit-Owner: Wolfgang Beyer <wo...@chromium.org>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Wolfgang Beyer <wo...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Wolfgang Beyer <wo...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Oct 2025 18:19:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages