Fix dock icons in HC mode [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Sylvester Elorm Coch (Gerrit)

unread,
Dec 23, 2025, 2:21:03 AM (3 days ago) Dec 23
to Jack Franklin, devtools-rev...@chromium.org
Attention needed from Jack Franklin

Sylvester Elorm Coch added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Sylvester Elorm Coch . resolved

@jacktf...@chromium.org Could you ptal? Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I536ebe4c17de915df96cb837a0bf9298af2c4751
Gerrit-Change-Number: 7298543
Gerrit-PatchSet: 2
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Dec 2025 07:21:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Jack Franklin (Gerrit)

unread,
Dec 23, 2025, 4:25:40 AM (3 days ago) Dec 23
to Sylvester Elorm Coch, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Sylvester Elorm Coch

Jack Franklin added 1 comment

Patchset-level comments
Jack Franklin . resolved

Sadly imgur is blocked in the UK now so I can't see the screenshots; is it possible to share them a different way? Feel free to upload them in a comment on the attached bug and ping me. THanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Sylvester Elorm Coch
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I536ebe4c17de915df96cb837a0bf9298af2c4751
Gerrit-Change-Number: 7298543
Gerrit-PatchSet: 2
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 09:25:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Sylvester Elorm Coch (Gerrit)

unread,
Dec 23, 2025, 2:30:48 PM (3 days ago) Dec 23
to Devtools-frontend LUCI CQ, Jack Franklin, devtools-rev...@chromium.org
Attention needed from Jack Franklin

Sylvester Elorm Coch added 1 comment

Patchset-level comments
Jack Franklin . resolved

Sadly imgur is blocked in the UK now so I can't see the screenshots; is it possible to share them a different way? Feel free to upload them in a comment on the attached bug and ping me. THanks!

Sylvester Elorm Coch

Updated the description with screenshots.

Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I536ebe4c17de915df96cb837a0bf9298af2c4751
Gerrit-Change-Number: 7298543
Gerrit-PatchSet: 3
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Dec 2025 19:30:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jack Franklin <jacktf...@chromium.org>
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages