Wire up PolicyContainerPolicies in mojo::FetchClientSettingsObject [chromium/src : main]

0 views
Skip to first unread message

Hiroki Nakagawa (Gerrit)

unread,
Mar 2, 2026, 5:53:52 PM (21 hours ago) Mar 2
to Antonio Sartori, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, rayanka...@chromium.org, nator...@chromium.org, dibyapal+wa...@chromium.org, iclella...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org
Attention needed from Antonio Sartori

Hiroki Nakagawa added 3 comments

File content/browser/service_worker/service_worker_context_unittest.cc
Line 164, Patchset 11 (Latest):blink::mojom::FetchClientSettingsObjectPtr GetFetchClientSettingsObject() {
auto fetch_client_settings_object =
blink::mojom::FetchClientSettingsObject::New();
fetch_client_settings_object->policy_container_policies =
blink::mojom::PolicyContainerPolicies::New();
return fetch_client_settings_object;
}
Hiroki Nakagawa . unresolved

How about renaming this to `GetEmptyFetchClientSettingsObject()` and moving it to somewhere (content/browser/loader/ ?) as a common helper function so that both tests and production code can use it?

File content/browser/service_worker/service_worker_register_job.cc
Line 82, Patchset 11 (Latest): DCHECK(outside_fetch_client_settings_object_);
Hiroki Nakagawa . unresolved

Can you change this to CHECK as well?

Line 108, Patchset 11 (Latest): DCHECK(outside_fetch_client_settings_object_);
Hiroki Nakagawa . unresolved

Ditto.

Open in Gerrit

Related details

Attention is currently required from:
  • Antonio Sartori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87926d6fe075c7c37f344d5fbfe85e70ad04d11a
Gerrit-Change-Number: 7606759
Gerrit-PatchSet: 11
Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Antonio Sartori <antonio...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Mar 2026 22:53:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Antonio Sartori (Gerrit)

unread,
3:12 AM (12 hours ago) 3:12 AM
to Hiroki Nakagawa, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, rayanka...@chromium.org, nator...@chromium.org, dibyapal+wa...@chromium.org, iclella...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org
Attention needed from Hiroki Nakagawa

Antonio Sartori added 3 comments

File content/browser/service_worker/service_worker_context_unittest.cc
Line 164, Patchset 11:blink::mojom::FetchClientSettingsObjectPtr GetFetchClientSettingsObject() {

auto fetch_client_settings_object =
blink::mojom::FetchClientSettingsObject::New();
fetch_client_settings_object->policy_container_policies =
blink::mojom::PolicyContainerPolicies::New();
return fetch_client_settings_object;
}
Hiroki Nakagawa . resolved

How about renaming this to `GetEmptyFetchClientSettingsObject()` and moving it to somewhere (content/browser/loader/ ?) as a common helper function so that both tests and production code can use it?

Antonio Sartori

Done, but only for tests. I don't think this is useful for production code, which is always supposed to fill in the referrer.

File content/browser/service_worker/service_worker_register_job.cc
Line 82, Patchset 11: DCHECK(outside_fetch_client_settings_object_);
Hiroki Nakagawa . resolved

Can you change this to CHECK as well?

Antonio Sartori

Done

Line 108, Patchset 11: DCHECK(outside_fetch_client_settings_object_);
Hiroki Nakagawa . resolved

Ditto.

Antonio Sartori

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Hiroki Nakagawa
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I87926d6fe075c7c37f344d5fbfe85e70ad04d11a
    Gerrit-Change-Number: 7606759
    Gerrit-PatchSet: 11
    Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Comment-Date: Tue, 03 Mar 2026 08:12:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Hiroki Nakagawa <nhi...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hiroki Nakagawa (Gerrit)

    unread,
    3:23 AM (11 hours ago) 3:23 AM
    to Antonio Sartori, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, rayanka...@chromium.org, nator...@chromium.org, dibyapal+wa...@chromium.org, iclella...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org
    Attention needed from Antonio Sartori

    Hiroki Nakagawa voted and added 1 comment

    Votes added by Hiroki Nakagawa

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 13 (Latest):
    Hiroki Nakagawa . resolved

    LGTM, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Antonio Sartori
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I87926d6fe075c7c37f344d5fbfe85e70ad04d11a
      Gerrit-Change-Number: 7606759
      Gerrit-PatchSet: 13
      Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
      Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
      Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-Attention: Antonio Sartori <antonio...@chromium.org>
      Gerrit-Comment-Date: Tue, 03 Mar 2026 08:23:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Antonio Sartori (Gerrit)

      unread,
      3:39 AM (11 hours ago) 3:39 AM
      to Arthur Sonzogni, Hiroki Nakagawa, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, rayanka...@chromium.org, nator...@chromium.org, dibyapal+wa...@chromium.org, iclella...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org
      Attention needed from Arthur Sonzogni

      Antonio Sartori added 1 comment

      Patchset-level comments
      Antonio Sartori . resolved

      +Arthur for the rest of //content

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Arthur Sonzogni
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I87926d6fe075c7c37f344d5fbfe85e70ad04d11a
      Gerrit-Change-Number: 7606759
      Gerrit-PatchSet: 13
      Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
      Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
      Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Comment-Date: Tue, 03 Mar 2026 08:39:37 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Arthur Sonzogni (Gerrit)

      unread,
      7:50 AM (7 hours ago) 7:50 AM
      to Antonio Sartori, Hiroki Nakagawa, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, rayanka...@chromium.org, nator...@chromium.org, dibyapal+wa...@chromium.org, iclella...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org
      Attention needed from Antonio Sartori

      Arthur Sonzogni voted and added 1 comment

      Votes added by Arthur Sonzogni

      Code-Review+1

      1 comment

      Patchset-level comments
      Arthur Sonzogni . resolved

      Thanks!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Antonio Sartori
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I87926d6fe075c7c37f344d5fbfe85e70ad04d11a
      Gerrit-Change-Number: 7606759
      Gerrit-PatchSet: 13
      Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
      Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
      Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-Attention: Antonio Sartori <antonio...@chromium.org>
      Gerrit-Comment-Date: Tue, 03 Mar 2026 12:50:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Antonio Sartori (Gerrit)

      unread,
      10:41 AM (4 hours ago) 10:41 AM
      to Arthur Sonzogni, Hiroki Nakagawa, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, rayanka...@chromium.org, nator...@chromium.org, dibyapal+wa...@chromium.org, iclella...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org

      Antonio Sartori voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I87926d6fe075c7c37f344d5fbfe85e70ad04d11a
      Gerrit-Change-Number: 7606759
      Gerrit-PatchSet: 13
      Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
      Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
      Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-Comment-Date: Tue, 03 Mar 2026 15:40:57 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages