Do IWYU for base/functional/callback_helpers.h in Blink code [chromium/src : main]

0 views
Skip to first unread message

Hiroki Nakagawa (Gerrit)

unread,
Nov 27, 2025, 1:06:32 AM (5 days ago) Nov 27
to Lei Zhang, AyeAye, chromium...@chromium.org, Dirk Schulze, Hirokazu Honda, Hongchan Choi, Hu, Ningxin, Jiewei Qian, Stephen Chenney, Chromium LUCI CQ, blink-reviews-p...@chromium.org, blink-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, horo+...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com
Attention needed from Lei Zhang

Hiroki Nakagawa voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If6954bc4d4401415a4dbbb20adf62ba118f8c3e9
Gerrit-Change-Number: 7206781
Gerrit-PatchSet: 4
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 27 Nov 2025 06:05:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Nov 30, 2025, 12:37:17 AM (yesterday) Nov 30
to Lei Zhang, Hiroki Nakagawa, AyeAye, chromium...@chromium.org, Dirk Schulze, Hirokazu Honda, Hongchan Choi, Hu, Ningxin, Jiewei Qian, Stephen Chenney, Chromium LUCI CQ, blink-reviews-p...@chromium.org, blink-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, horo+...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If6954bc4d4401415a4dbbb20adf62ba118f8c3e9
Gerrit-Change-Number: 7206781
Gerrit-PatchSet: 5
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Comment-Date: Sun, 30 Nov 2025 05:37:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 30, 2025, 1:40:33 AM (yesterday) Nov 30
to Lei Zhang, Hiroki Nakagawa, AyeAye, chromium...@chromium.org, Dirk Schulze, Hirokazu Honda, Hongchan Choi, Hu, Ningxin, Jiewei Qian, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, horo+...@chromium.org, jshin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/blink/renderer/modules/webaudio/audio_context.cc
Insertions: 2, Deletions: 0.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:
Do IWYU for base/functional/callback_helpers.h in Blink code

Add some missing callback_helpers.h includes for call sites that use
base::DoNothing, base::ScopedClosureRunner, etc. This is in preparation
for removing the includes for callback_helpers.h from various //base
headers.
Change-Id: If6954bc4d4401415a4dbbb20adf62ba118f8c3e9
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1551799}
Files:
  • M third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.h
  • M third_party/blink/renderer/modules/ai/model_execution_responder.cc
  • M third_party/blink/renderer/modules/imagecapture/image_capture_test.cc
  • M third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler_unittest.cc
  • M third_party/blink/renderer/modules/mediacapturefromelement/html_video_element_capturer_source_unittest.cc
  • M third_party/blink/renderer/modules/mediastream/browser_capture_media_stream_track.cc
  • M third_party/blink/renderer/modules/mediastream/browser_capture_media_stream_track_test.cc
  • M third_party/blink/renderer/modules/mediastream/media_stream.cc
  • M third_party/blink/renderer/modules/mediastream/media_stream_video_track_test.cc
  • M third_party/blink/renderer/modules/mediastream/test/transfer_test_utils.cc
  • M third_party/blink/renderer/modules/ml/webnn/ml_graph_test.cc
  • M third_party/blink/renderer/modules/service_worker/web_embedded_worker_impl_test.cc
  • M third_party/blink/renderer/modules/webaudio/audio_context.cc
  • M third_party/blink/renderer/platform/exported/video_capture/web_video_capture_impl_manager_test.cc
  • M third_party/blink/renderer/platform/fonts/android/font_unique_name_lookup_android.cc
  • M third_party/blink/renderer/platform/graphics/static_bitmap_image_transform_test.cc
  • M third_party/blink/renderer/platform/media/video_frame_compositor_unittest.cc
  • M third_party/blink/renderer/platform/peerconnection/instrumented_simulcast_adapter_test.cc
  • M third_party/blink/renderer/platform/peerconnection/stats_collecting_decoder_test.cc
  • M third_party/blink/renderer/platform/peerconnection/stats_collecting_encoder_test.cc
  • M third_party/blink/renderer/platform/peerconnection/video_codec_factory.cc
  • M third_party/blink/renderer/platform/peerconnection/video_codec_factory_test.cc
  • M third_party/blink/renderer/platform/peerconnection/webrtc_decoding_info_handler.cc
  • M third_party/blink/renderer/platform/peerconnection/webrtc_encoding_info_handler.cc
  • M third_party/blink/renderer/platform/video_capture/video_capture_impl_test.cc
Change size: S
Delta: 25 files changed, 25 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Hiroki Nakagawa
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If6954bc4d4401415a4dbbb20adf62ba118f8c3e9
Gerrit-Change-Number: 7206781
Gerrit-PatchSet: 6
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages