[M144] Disable storage inspection for service workers. [devtools/devtools-frontend : chromium/7559]

0 views

Skip to first unread message

Rubber Stamper (Gerrit)

unread,

11:01 AM (13 hours ago) 11:01 AM

to Chrome Cherry Picker, AyeAye, devtools-rev...@chromium.org

Rubber Stamper voted

Bot-Commit	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,

11:34 AM (12 hours ago) 11:34 AM

to Benedikt Meurer, Chrome Cherry Picker, Rubber Stamper, AyeAye, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:

[M144] Disable storage inspection for service workers.

Original change's description:
> Disable storage inspection for service workers.
> 
> This is causing crashes in M143 and on. Unfortunately the original CL no
> longer reverts cleanly, so this is the minimal delta to disable its
> effects, which can also be back-merged appropriately.
> 
> Bug: 406991275
> Change-Id: If6451729e483de6d06d370c1f966fb981500cd3a
> Fixed: 466134219
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7319382
> Reviewed-by: Changhao Han <chang...@chromium.org>
> Auto-Submit: Benedikt Meurer <bme...@chromium.org>
> Commit-Queue: Changhao Han <chang...@chromium.org>

Bug: 472090936,406991275,466134219
Change-Id: If6451729e483de6d06d370c1f966fb981500cd3a
(cherry picked from commit 3d3ff165388c40702f84929013c9793e59125ff2)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7360151
Auto-Submit: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Files:

M front_end/core/sdk/ChildTargetManager.test.ts
M front_end/core/sdk/Target.test.ts
M front_end/core/sdk/Target.ts

Change size: M

Delta: 3 files changed, 38 insertions(+), 29 deletions(-)

Branch: refs/heads/chromium/7559

Submit Requirements:

Code-Review: Bot-Commit+1 by Rubber Stamper

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages