[iOS tracing] Extract native data source implementations from use_blink [chromium/src : main]
0 views
Skip to first unread message
Justin Cohen (Gerrit)
Apr 13, 2026, 2:46:04 PM (2 days ago) Apr 13
to Etienne Pierre-Doray, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, arc-review...@google.com, chrome-gr...@chromium.org, hidehik...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yhanada+...@chromium.org
Attention needed from Etienne Pierre-Doray
Justin Cohen voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Apr 13, 2026, 3:52:50 PM (2 days ago) Apr 13
to Justin Cohen, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, arc-review...@google.com, chrome-gr...@chromium.org, hidehik...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yhanada+...@chromium.org
Attention needed from Justin Cohen
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Apr 14, 2026, 6:02:35 PM (17 hours ago) Apr 14
to Etienne Pierre-Doray, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, arc-review...@google.com, chrome-gr...@chromium.org, hidehik...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yhanada+...@chromium.org
Justin Cohen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Apr 14, 2026, 8:29:14 PM (14 hours ago) Apr 14
to Justin Cohen, Etienne Pierre-Doray, chromium...@chromium.org, devtools...@chromium.org, arc-review...@google.com, chrome-gr...@chromium.org, hidehik...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yhanada+...@chromium.org
chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[iOS tracing] Extract native data source implementations from use_blink
This CL moves the C++ implementations of native Perfetto data sources
(e.g., TracingSamplerProfiler, SystemMetricsSampler, CustomEventRecorder)
out of the 'if (use_blink)' block in services/tracing/public/cpp/BUILD.gn.
It also introduces 'RegisterCommonPerfettoDataSources()' in
common_data_sources.cc, which provides a shared way to register these
platform-agnostic data sources without pulling in the blink-heavy
trace_startup.cc dependencies.
This builds on top of crrev.com/c/7748975 and allows platforms like
iOS that do not use Blink or the Mojo tracing service to run native
profiling.
Bug: 495937056
Change-Id: Ie09aaf08a4e791e5385e6fbd44fb1f4425b5b070
Commit-Queue: Justin Cohen <justi...@google.com>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1614805}
Files:
- M services/tracing/public/cpp/BUILD.gn
- A services/tracing/public/cpp/perfetto/common_data_sources.cc
- A services/tracing/public/cpp/perfetto/common_data_sources.h
- M services/tracing/public/cpp/perfetto/custom_event_recorder.cc
- M services/tracing/public/cpp/perfetto/perfetto_traced_process.cc
- M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc
Change size: M
Delta: 6 files changed, 74 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages