[heap, profiler] Use kExposeInternals for snapshots created by GC [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
5:05 AM (10 hours ago) 5:05 AM
to Camillo Bruni, Michael Lippautz, Hannes Payer, AyeAye, mlippau...@chromium.org, oilpan-r...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Camillo Bruni and Michael Lippautz
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Camillo Bruni
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
5:08 AM (10 hours ago) 5:08 AM
to Dominik Inführ, Camillo Bruni, Hannes Payer, AyeAye, mlippau...@chromium.org, oilpan-r...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Camillo Bruni and Dominik Inführ
Michael Lippautz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
2 comments
Patchset-level comments
File src/profiler/heap-profiler.cc
Line 204, Patchset 4 (Latest):
HeapProfiler::GetDefaultHeapSnapshotOptions() {Michael Lippautz . unresolved
`GetDefaultHeapSnapshotOptionsForTestingUsage()`? I'd like to encode that this is internal/testing somehow.
Related details
Attention is currently required from:
- Camillo Bruni
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
5:20 AM (9 hours ago) 5:20 AM
to V8 LUCI CQ, Michael Lippautz, Camillo Bruni, Hannes Payer, AyeAye, mlippau...@chromium.org, oilpan-r...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Camillo Bruni
Dominik Inführ added 1 comment![]( "Open in Gerrit")
File src/profiler/heap-profiler.cc
`GetDefaultHeapSnapshotOptionsForTestingUsage()`? I'd like to encode that this is internal/testing somehow.
Dominik Inführ
Done
Related details
Attention is currently required from:
- Camillo Bruni
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
5:23 AM (9 hours ago) 5:23 AM
to Dominik Inführ, V8 LUCI CQ, Michael Lippautz, Hannes Payer, AyeAye, mlippau...@chromium.org, oilpan-r...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Camillo Bruni voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
5:23 AM (9 hours ago) 5:23 AM
to Camillo Bruni, V8 LUCI CQ, Michael Lippautz, Hannes Payer, AyeAye, mlippau...@chromium.org, oilpan-r...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
10:26 AM (4 hours ago) 10:26 AM
to Dominik Inführ, Camillo Bruni, Michael Lippautz, Hannes Payer, AyeAye, mlippau...@chromium.org, oilpan-r...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap, profiler] Use kExposeInternals for snapshots created by GC
Move the options we use for V8-internal heap snapshots into a new
method GetDefaultHeapSnapshotOptions() and use it across all
call-sites.
WriteSnapshotToDiskAfterGC() which is used for e.g.
--heap-snapshot-on-gc, now uses the same options by default as well.
Change-Id: I0400c1855a50cc650e26d032c573f1cdb039689e
Reviewed-by: Camillo Bruni <cbr...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105558}
Files:
- M src/extensions/gc-extension.cc
- M src/heap/cppgc-js/cpp-heap.cc
- M src/profiler/heap-profiler.cc
- M src/profiler/heap-profiler.h
- M src/runtime/runtime-test.cc
Change size: M
Delta: 5 files changed, 30 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Camillo Bruni, +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages