[eslint] Disable rule for Doc files [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Kim-Anh Tran (Gerrit)

unread,
12:32 AM (8 hours ago) 12:32 AM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov

Kim-Anh Tran voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nikolay Vitkov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I0dde28db88a784338a5b4bc638c6015dc8def669
Gerrit-Change-Number: 7207245
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-CC: Benedikt Meurer <bme...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Dec 2025 05:32:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kim-Anh Tran (Gerrit)

unread,
12:32 AM (8 hours ago) 12:32 AM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov

Kim-Anh Tran added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kim-Anh Tran . resolved

LGTM, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Nikolay Vitkov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I0dde28db88a784338a5b4bc638c6015dc8def669
Gerrit-Change-Number: 7207245
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-CC: Benedikt Meurer <bme...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Dec 2025 05:32:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Nikolay Vitkov (Gerrit)

unread,
4:28 AM (4 hours ago) 4:28 AM
to Kim-Anh Tran, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Nikolay Vitkov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I0dde28db88a784338a5b4bc638c6015dc8def669
Gerrit-Change-Number: 7207245
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-CC: Benedikt Meurer <bme...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 09:28:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
4:59 AM (4 hours ago) 4:59 AM
to Nikolay Vitkov, Kim-Anh Tran, Benedikt Meurer, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
[eslint] Disable rule for Doc files

It should be OK to have some allowed rules in the .docs.ts files that
differ from the reset of DevTools.
Bug: none
Change-Id: I0dde28db88a784338a5b4bc638c6015dc8def669
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Reviewed-by: Kim-Anh Tran <kim...@chromium.org>
Files:
  • M eslint.config.mjs
  • M front_end/ui/components/snackbars/Snackbars.docs.ts
  • M front_end/ui/legacy/SelectMenu.docs.ts
Change size: XS
Delta: 3 files changed, 7 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kim-Anh Tran
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I0dde28db88a784338a5b4bc638c6015dc8def669
Gerrit-Change-Number: 7207245
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages