Empty binder for ScriptToolHost interface [chromium/src : main]
0 views
Skip to first unread message
Anders Hartvoll Ruud (Gerrit)
4:51 AM (3 hours ago) 4:51 AM
to Chromium IPC Reviews, Philip Pfaffe, Mason Freed, AyeAye, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Chromium IPC Reviews
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Chromium IPC Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
4:55 AM (3 hours ago) 4:55 AM
to Anders Hartvoll Ruud, Chromium IPC Reviews, Antonio Sartori, Philip Pfaffe, Mason Freed, AyeAye, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Antonio Sartori
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: antonio...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): antonio...@chromium.org
Reviewer source(s):
antonio...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
6:25 AM (2 hours ago) 6:25 AM
to Anders Hartvoll Ruud, Chromium IPC Reviews, Philip Pfaffe, Mason Freed, AyeAye, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Anders Hartvoll Ruud
Antonio Sartori voted and added 1 comment![]( "Open in Gerrit")
Votes added by Antonio Sartori
| Code-Review | +1 |
1 comment
File third_party/blink/web_tests/inspector-protocol/webmcp/execute-declarative-tool-crash.js
Line 1, Patchset 2 (Latest):
(async function(/** @type {import('test_runner').TestRunner} */ testRunner) {
const {dp} = await testRunner.startHTML(
`
<form id="my_form" toolname="declarative_tool" tooldescription="A declarative WebMCP tool" action="some_action.html">
<input type="text" name="text">
<input type="submit">
</form>
<script>
window.executeDeclarative = async function() {
await navigator.modelContextTesting.executeTool("declarative_tool", JSON.stringify({text: "hello"}));
};
</script>
`,
'Tests that declarative tool execution does not crash.');
await dp.WebMCP.enable();
testRunner.log('Executing declarative tool...');
const executePromise = dp.Runtime.evaluate({expression: 'window.executeDeclarative()', awaitPromise: true});
// Submit the form to unblock the execution.
await dp.Runtime.evaluate({expression: 'document.querySelector("input[type=submit]").click()'});
await executePromise;
testRunner.completeTest();
});Antonio Sartori . unresolved
(nit) can you make the long lines fit in 80 chars?
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
8:07 AM (9 minutes ago) 8:07 AM
to Antonio Sartori, Chromium IPC Reviews, Philip Pfaffe, Mason Freed, AyeAye, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Anders Hartvoll Ruud voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anders Hartvoll Ruud
| Commit-Queue | +2 |
1 comment
File third_party/blink/web_tests/inspector-protocol/webmcp/execute-declarative-tool-crash.js
Line 1, Patchset 2:
(async function(/** @type {import('test_runner').TestRunner} */ testRunner) {
const {dp} = await testRunner.startHTML(
`
<form id="my_form" toolname="declarative_tool" tooldescription="A declarative WebMCP tool" action="some_action.html">
<input type="text" name="text">
<input type="submit">
</form>
<script>
window.executeDeclarative = async function() {
await navigator.modelContextTesting.executeTool("declarative_tool", JSON.stringify({text: "hello"}));
};
</script>
`,
'Tests that declarative tool execution does not crash.');
await dp.WebMCP.enable();
testRunner.log('Executing declarative tool...');
const executePromise = dp.Runtime.evaluate({expression: 'window.executeDeclarative()', awaitPromise: true});
// Submit the form to unblock the execution.
await dp.Runtime.evaluate({expression: 'document.querySelector("input[type=submit]").click()'});
await executePromise;
testRunner.completeTest();
});Antonio Sartori . resolved
(nit) can you make the long lines fit in 80 chars?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages