RPP: Fix orphan script association in EnhancedTracesParser [devtools/devtools-frontend : main]
1 view
Skip to first unread message
Paul Irish (Gerrit)
Sep 17, 2025, 9:43:35 PM (7 days ago) Sep 17
to Connor Clark, devtools-rev...@chromium.org
Attention needed from Connor Clark
Paul Irish voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Connor Clark
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Sep 18, 2025, 12:02:26 PM (7 days ago) Sep 18
to Paul Irish, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Paul Irish
Connor Clark voted and added 1 comment![]( "Open in Gerrit")
Votes added by Connor Clark
| Code-Review | +1 |
1 comment
Commit Message
Line 9, Patchset 3 (Latest):
The `in` operator was being used to check for the existence of a key in the `executionContextIsolateToTarget` Map. This is incorrect, as the `in` operator checks for properties on the object itself, not for keys within the map.Connor Clark . unresolved
please format
Related details
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Sep 23, 2025, 12:07:59 PM (2 days ago) Sep 23
to Connor Clark, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Paul Irish voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Irish
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
Commit Message
Line 9, Patchset 3:
The `in` operator was being used to check for the existence of a key in the `executionContextIsolateToTarget` Map. This is incorrect, as the `in` operator checks for properties on the object itself, not for keys within the map.Connor Clark . resolved
Paul Irishplease format
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Sep 23, 2025, 3:17:09 PM (2 days ago) Sep 23
to Paul Irish, Connor Clark, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
RPP: Fix orphan script association in EnhancedTracesParser
The `in` operator was being used to check for the existence of a key in
the `executionContextIsolateToTarget` Map. This is incorrect, as the
`in` operator checks for properties on the object itself, not for keys
within the map.
This caused the check to always fail, preventing orphan scripts from
being correctly associated with their target frame via their execution
context.
This change corrects the logic to use `map.get()` and a subsequent
truthiness check, ensuring scripts are correctly associated.
Bug: 427455148
Change-Id: Ia1a420237b932fe571dff7dc0a1ac0c2da469d2c
Reviewed-by: Connor Clark <cja...@chromium.org>
Auto-Submit: Paul Irish <paul...@chromium.org>
Commit-Queue: Paul Irish <paul...@chromium.org>
Files:
- M front_end/core/sdk/EnhancedTracesParser.ts
- M front_end/core/sdk/RehydratingConnection.snapshot.txt
Change size: M
Delta: 2 files changed, 216 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Connor Clark
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages