gwsq (Gerrit)

unread,

Aug 13, 2026, 8:49:19 AM (6 days ago) Aug 13

to Ilya Nikolaevskiy, Chromium IPC Reviews, Kinuko Yasuda, Joe Downing, Jordan Bayles, Alex Rudenko, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, cc-...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org

Attention needed from Alex Rudenko, Joe Downing, Jordan Bayles and Kinuko Yasuda

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: kin...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): kin...@chromium.org

Reviewer source(s):
kin...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Joe Downing
Jordan Bayles
Kinuko Yasuda

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

Aug 13, 2026, 9:28:27 AM (6 days ago) Aug 13

to Ilya Nikolaevskiy, Chromium IPC Reviews, Kinuko Yasuda, Joe Downing, Jordan Bayles, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, cc-...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org

Attention needed from Ilya Nikolaevskiy, Joe Downing, Jordan Bayles and Kinuko Yasuda

Alex Rudenko voted and added 1 comment

Votes added by Alex Rudenko

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Alex Rudenko . resolved

devtools lgtm

Open in Gerrit

Related details

Attention is currently required from:

Ilya Nikolaevskiy

Joe Downing
Jordan Bayles
Kinuko Yasuda

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Guido Urdaneta (Gerrit)

unread,

Aug 13, 2026, 9:51:29 AM (6 days ago) Aug 13

to Ilya Nikolaevskiy, Alex Rudenko, Chromium IPC Reviews, Kinuko Yasuda, Joe Downing, Jordan Bayles, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, cc-...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org

Attention needed from Ilya Nikolaevskiy, Joe Downing, Jordan Bayles and Kinuko Yasuda

Guido Urdaneta voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Ilya Nikolaevskiy
Joe Downing
Jordan Bayles
Kinuko Yasuda

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Joe Downing (Gerrit)

unread,

Aug 13, 2026, 11:04:14 AM (6 days ago) Aug 13

to Ilya Nikolaevskiy, Guido Urdaneta, Alex Rudenko, Chromium IPC Reviews, Kinuko Yasuda, Jordan Bayles, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, cc-...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org

Attention needed from Ilya Nikolaevskiy, Jordan Bayles and Kinuko Yasuda

Joe Downing voted and added 1 comment

Votes added by Joe Downing

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Joe Downing . resolved

remoting lgtm

Open in Gerrit

Related details

Attention is currently required from:

Ilya Nikolaevskiy
Jordan Bayles
Kinuko Yasuda

satisfied_requirement

unsatisfied_requirement

open

diffy

Jordan Bayles (Gerrit)

unread,

Aug 14, 2026, 6:40:23 PM (5 days ago) Aug 14

to Ilya Nikolaevskiy, Joe Downing, Guido Urdaneta, Alex Rudenko, Chromium IPC Reviews, Kinuko Yasuda, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, cc-...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org

Attention needed from Ilya Nikolaevskiy and Kinuko Yasuda

Jordan Bayles voted and added 3 comments

Votes added by Jordan Bayles

Code-Review

+1

3 comments

File components/viz/service/frame_sinks/video_capture/shared_memory_video_frame_pool.h

Line 85, Patchset 3 (Latest): uint32_t pool_generation_ = 0;

Jordan Bayles . unresolved

A comment explaining what this is would be helpful.

File content/browser/devtools/devtools_video_consumer_unittest.cc

Line 115, Patchset 3 (Latest): MOCK_METHOD(void, InvalidateBuffers, (), (override));

Jordan Bayles . unresolved

NIT: can you update the other MOCK_METHOD declarations while you are in here to also use the new, integerless format (e.g. MOCK_METHOD instead of MOCK_METHOD0)?

File content/browser/media/capture/frame_sink_video_capture_device_unittest.cc

Line 136, Patchset 3 (Latest): MOCK_METHOD(void, InvalidateBuffers, (), (override));

Jordan Bayles . unresolved

NIT: can you update the other MOCK_METHOD declarations while you are in here to also use the new, integerless format (e.g. MOCK_METHOD instead of MOCK_METHOD0)?

Open in Gerrit

Related details

Attention is currently required from:

Ilya Nikolaevskiy
Kinuko Yasuda

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ilya Nikolaevskiy (Gerrit)

unread,

Aug 17, 2026, 6:17:17 AM (2 days ago) Aug 17

to Jordan Bayles, Joe Downing, Guido Urdaneta, Alex Rudenko, Chromium IPC Reviews, Kinuko Yasuda, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, cc-...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org

Attention needed from Kinuko Yasuda

Ilya Nikolaevskiy voted and added 3 comments

Votes added by Ilya Nikolaevskiy

Commit-Queue

+2

3 comments

File components/viz/service/frame_sinks/video_capture/shared_memory_video_frame_pool.h

Line 85, Patchset 3: uint32_t pool_generation_ = 0;

Jordan Bayles . resolved

A comment explaining what this is would be helpful.

Ilya Nikolaevskiy

Done

File content/browser/devtools/devtools_video_consumer_unittest.cc

Line 115, Patchset 3: MOCK_METHOD(void, InvalidateBuffers, (), (override));

Jordan Bayles . resolved

NIT: can you update the other MOCK_METHOD declarations while you are in here to also use the new, integerless format (e.g. MOCK_METHOD instead of MOCK_METHOD0)?

Ilya Nikolaevskiy

Done

File content/browser/media/capture/frame_sink_video_capture_device_unittest.cc

Line 136, Patchset 3: MOCK_METHOD(void, InvalidateBuffers, (), (override));

Jordan Bayles . resolved

NIT: can you update the other MOCK_METHOD declarations while you are in here to also use the new, integerless format (e.g. MOCK_METHOD instead of MOCK_METHOD0)?

Ilya Nikolaevskiy

Done

Open in Gerrit

Related details

Attention is currently required from:

Kinuko Yasuda

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kinuko Yasuda (Gerrit)

unread,

Aug 18, 2026, 7:27:45 PM (14 hours ago) Aug 18

to Ilya Nikolaevskiy, Jordan Bayles, Joe Downing, Guido Urdaneta, Alex Rudenko, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, cc-...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org

Attention needed from Ilya Nikolaevskiy

Kinuko Yasuda voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Ilya Nikolaevskiy

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Ilya Nikolaevskiy (Gerrit)

unread,

5:20 AM (4 hours ago) 5:20 AM

to Kinuko Yasuda, Jordan Bayles, Joe Downing, Guido Urdaneta, Alex Rudenko, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, cc-...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org

Ilya Nikolaevskiy voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Ilya Nikolaevskiy (Gerrit)

unread,

5:21 AM (4 hours ago) 5:21 AM

to Kinuko Yasuda, Jordan Bayles, Joe Downing, Guido Urdaneta, Alex Rudenko, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, cc-...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org

Ilya Nikolaevskiy voted Commit-Queue+1

Commit-Queue

+1

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

7:02 AM (3 hours ago) 7:02 AM

to Ilya Nikolaevskiy, Kinuko Yasuda, Jordan Bayles, Joe Downing, Guido Urdaneta, Alex Rudenko, Chromium IPC Reviews, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Rijubrata Bhaumik, cc-...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, mfoltz+wa...@chromium.org, oshima...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Implement InvalidateBuffers for video capture (cl 2/6)

This CL adds InvalidateBuffers method to FrameSinkVideoCapturer. It adds the method to:
- video capture device on browser side
- mojom interface
- FrameSinkVideoCapturerImpl in viz
- 2 used Frame Buffer Pool implementations and their interface

Bug: 543640868

Change-Id: I46fdd1a59ec5e0ce7c7b176d78bd70914d4c9260

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8257169

Reviewed-by: Alex Rudenko <alexr...@chromium.org>

Commit-Queue: Ilya Nikolaevskiy <il...@chromium.org>

Reviewed-by: Jordan Bayles <jop...@chromium.org>

Reviewed-by: Joe Downing <joe...@chromium.org>

Reviewed-by: Guido Urdaneta <gui...@chromium.org>

Reviewed-by: Kinuko Yasuda <kin...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1682185}

Files:

M components/mirroring/browser/single_client_video_capture_host_unittest.cc
M components/viz/host/client_frame_sink_video_capturer.cc
M components/viz/host/client_frame_sink_video_capturer.h
M components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc
M components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.h
M components/viz/service/frame_sinks/video_capture/mappable_shared_image_video_frame_pool.cc
M components/viz/service/frame_sinks/video_capture/mappable_shared_image_video_frame_pool.h
M components/viz/service/frame_sinks/video_capture/shared_memory_video_frame_pool.cc
M components/viz/service/frame_sinks/video_capture/shared_memory_video_frame_pool.h
M components/viz/service/frame_sinks/video_capture/video_frame_pool.h
M content/browser/devtools/devtools_video_consumer_unittest.cc
M content/browser/media/capture/frame_sink_video_capture_device_unittest.cc
M remoting/host/chromeos/frame_sink_desktop_capturer_unittest.cc
M services/viz/privileged/mojom/compositing/frame_sink_video_capture.mojom

Change size: M

Delta: 14 files changed, 63 insertions(+), 20 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alex Rudenko, +1 by Jordan Bayles, +1 by Guido Urdaneta, +1 by Joe Downing, +1 by Kinuko Yasuda

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Implement InvalidateBuffers for video capture (cl 2/6) [chromium/src : main]

gwsq (Gerrit)

Message from gwsq

Related details

Alex Rudenko (Gerrit)

Alex Rudenko voted and added 1 comment

Votes added by Alex Rudenko

1 comment

Related details

Guido Urdaneta (Gerrit)

Guido Urdaneta voted Code-Review+1

Related details

Joe Downing (Gerrit)

Joe Downing voted and added 1 comment

Votes added by Joe Downing

1 comment

Related details

Jordan Bayles (Gerrit)

Jordan Bayles voted and added 3 comments

Votes added by Jordan Bayles

3 comments

Related details

Ilya Nikolaevskiy (Gerrit)

Ilya Nikolaevskiy voted and added 3 comments

Votes added by Ilya Nikolaevskiy

3 comments

Related details

Kinuko Yasuda (Gerrit)

Kinuko Yasuda voted Code-Review+1

Related details

Ilya Nikolaevskiy (Gerrit)

Ilya Nikolaevskiy voted Commit-Queue+2

Related details

Ilya Nikolaevskiy (Gerrit)

Ilya Nikolaevskiy voted Commit-Queue+1

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Unreviewed changes

Change information