[global-state] Stash EventBreakpointsModel on DevToolsContext [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
Jul 3, 2026, 12:06:58 AM (yesterday) Jul 3
to Mathias Bynens, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Mathias Bynens
Simon Zünd voted and added 1 comment![]( "Open in Gerrit")
Votes added by Simon Zünd
| Code-Review | +1 |
1 comment
File front_end/core/sdk/EventBreakpointsModel.ts
Line 161, Patchset 1 (Latest):
static removeInstance(): void {
Root.DevToolsContext.globalInstance().delete(EventBreakpointsManager);
}
Simon Zünd . unresolved
Same here, might be worth calling in `deinitializeGlobalVars()` as well.
Related details
Attention is currently required from:
- Mathias Bynens
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mathias Bynens (Gerrit)
Jul 3, 2026, 8:06:24 AM (yesterday) Jul 3
to Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Mathias Bynens voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mathias Bynens (Gerrit)
Jul 3, 2026, 8:07:20 AM (yesterday) Jul 3
to Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Mathias Bynens voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mathias Bynens
| Commit-Queue | +2 |
1 comment
File front_end/core/sdk/EventBreakpointsModel.ts
Line 161, Patchset 1:
static removeInstance(): void {
Root.DevToolsContext.globalInstance().delete(EventBreakpointsManager);
}
Simon Zünd . resolved
Same here, might be worth calling in `deinitializeGlobalVars()` as well.
Mathias Bynens
Done
Related details
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mathias Bynens (Gerrit)
Jul 3, 2026, 8:10:26 AM (yesterday) Jul 3
to Alina Varkki, Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alina Varkki and Simon Zünd
Mathias Bynens voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mathias Bynens
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Mathias Bynens . resolved
Alina, I lost Simon’s +1 when addressing the comments. Could you PTAL?
Related details
Attention is currently required from:
- Alina Varkki
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mathias Bynens (Gerrit)
Jul 3, 2026, 8:40:09 AM (yesterday) Jul 3
to Alina Varkki, Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alina Varkki and Simon Zünd
Mathias Bynens voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Alina Varkki
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alina Varkki (Gerrit)
Jul 3, 2026, 9:10:46 AM (yesterday) Jul 3
to Mathias Bynens, Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Mathias Bynens and Simon Zünd
Alina Varkki voted![]( "Open in Gerrit")
Attention is currently required from:
- Mathias Bynens
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 3, 2026, 9:13:04 AM (yesterday) Jul 3
to Mathias Bynens, Alina Varkki, Simon Zünd, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[global-state] Stash EventBreakpointsModel on DevToolsContext
Step 1 of migrating away from singletons for EventBreakpointsModel. This
stashes the EventBreakpointsModel on DevToolsContext, and makes sure
that we don't use any .instance() calls.
Bug: 493763857
Change-Id: I826ef0a64bd1b7d5f8490b179e42c83786259edf
Reviewed-by: Alina Varkki <alina...@chromium.org>
Auto-Submit: Mathias Bynens <mat...@chromium.org>
Commit-Queue: Alina Varkki <alina...@chromium.org>
Files:
- M front_end/core/sdk/EventBreakpointsModel.ts
- M front_end/testing/EnvironmentHelpers.ts
Change size: S
Delta: 2 files changed, 10 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alina Varkki
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages