[bedrock] Move CloseAllBrowsersWithProfile to application_lifetime_desktop [chromium/src : main]

0 views

Skip to first unread message

Thomas Lukaszewicz (Gerrit)

unread,

May 14, 2026, 6:26:00 PMMay 14

to Yu He, Hidehiko Abe, android-bu...@system.gserviceaccount.com, Qikai Zhong, Kun Wang, Kevin DiClemente, Chromium LUCI CQ, chromium...@chromium.org, extension...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, ydago...@chromium.org, devtools...@chromium.org, dullweb...@chromium.org, nicolas...@chromium.org, msrame...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, csharrison+...@chromium.org, rginda...@chromium.org

Attention needed from Hidehiko Abe, Qikai Zhong and Yu He

Thomas Lukaszewicz voted and added 2 comments

Votes added by Thomas Lukaszewicz

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Thomas Lukaszewicz . resolved

lgtm % moving profile-scoped close browsers into application_lifetime_desktop.

Sorry for the delay - there are simplifications we can make to these APIs (I've uncovered a few) but we can do these after we move these out of browser_finder to avoid blocking on that task.

File chrome/browser/ui/browser_window/public/browser_collection.h

Line 90, Patchset 14 (Latest): void CloseAllBrowsers();

Thomas Lukaszewicz . unresolved

Let's move this to application_lifetime also and keep the profile param. Sorry for the code churn but it'll be helpful to have all lifetime-related APIs in the same location.

Open in Gerrit

Related details

Attention is currently required from:

Hidehiko Abe
Qikai Zhong
Yu He

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages