Let EsLint handle excluded files in PRESUBMIT [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Nikolay Vitkov (Gerrit)
Nov 4, 2025, 6:43:27 AM (2 days ago) Nov 4
to Benedikt Meurer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer
Nikolay Vitkov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nikolay Vitkov
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Nov 4, 2025, 6:44:11 AM (2 days ago) Nov 4
to Benedikt Meurer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer
Nikolay Vitkov added 1 comment![]( "Open in Gerrit")
File PRESUBMIT.py
Line 43, Patchset 1 (Parent):
r'front_end[\\/]generated[\\/]ARIAProperties\.ts$' # Auto-generated filesNikolay Vitkov . unresolved
No such file exits, its `ARIAProperties.js` but that has the correct licence.
Related details
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benedikt Meurer (Gerrit)
Nov 4, 2025, 7:31:18 AM (2 days ago) Nov 4
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov
Benedikt Meurer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Benedikt Meurer
| Code-Review | +1 |
1 comment
File PRESUBMIT.py
Line 43, Patchset 1 (Parent):
r'front_end[\\/]generated[\\/]ARIAProperties\.ts$' # Auto-generated filesNikolay Vitkov . resolved
No such file exits, its `ARIAProperties.js` but that has the correct licence.
Attention is currently required from:
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Nov 4, 2025, 7:31:31 AM (2 days ago) Nov 4
to Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Nikolay Vitkov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Nov 4, 2025, 7:33:04 AM (2 days ago) Nov 4
to Nikolay Vitkov, Benedikt Meurer, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Let EsLint handle excluded files in PRESUBMIT
We were excluding files from linting in PRESUBMIT,
the issue is that code path got omitted if we had more than 50 files
changed.
We should let EsLint config dictate what files are linted and what
are not. That ensures that we always have the same behaviour.
Bug: none
Change-Id: I5baa97f887980683cfec8c2be27dd5adfcd00ab2
Reviewed-by: Benedikt Meurer <bme...@chromium.org>
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Auto-Submit: Nikolay Vitkov <nvi...@chromium.org>
Files:
- M PRESUBMIT.py
Change size: XS
Delta: 1 file changed, 0 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Benedikt Meurer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages