Validate keyboard shortcuts in ExtensionServer [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Alex Rudenko (Gerrit)

unread,
6:38 AM (3 hours ago) 6:38 AM
to Philip Pfaffe, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe

Alex Rudenko voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Philip Pfaffe
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I9ec9d54b62cc988ecefe032065b9a8c675bb645f
Gerrit-Change-Number: 8250963
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 10:38:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Pfaffe (Gerrit)

unread,
6:48 AM (3 hours ago) 6:48 AM
to Alex Rudenko, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alex Rudenko

Philip Pfaffe voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I9ec9d54b62cc988ecefe032065b9a8c675bb645f
Gerrit-Change-Number: 8250963
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 10:48:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
8:11 AM (2 hours ago) 8:11 AM
to Alex Rudenko, Philip Pfaffe, devtools-rev...@chromium.org

devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Validate keyboard shortcuts in ExtensionServer
Fixed: 548611433
Change-Id: I9ec9d54b62cc988ecefe032065b9a8c675bb645f
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Commit-Queue: Philip Pfaffe <pfa...@chromium.org>
Auto-Submit: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Files:
  • M front_end/models/extensions/ExtensionAPI.ts
  • M front_end/panels/common/ExtensionServer.test.ts
  • M front_end/panels/common/ExtensionServer.ts
Change size: L
Delta: 3 files changed, 529 insertions(+), 54 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Philip Pfaffe
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I9ec9d54b62cc988ecefe032065b9a8c675bb645f
Gerrit-Change-Number: 8250963
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages