Shorten base::OnceCallback<void(void)> to base::OnceClosure [chromium/src : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Jun 12, 2026, 5:29:13 PM (2 days ago) Jun 12
to Lei Zhang, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Hiroki Nakagawa, agriev...@chromium.org, alandin...@chromium.org, arc-review...@google.com, blink-...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, jackshira+wat...@google.com, kinuko+ser...@chromium.org, lizeb...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, media-cro...@chromium.org, net-r...@chromium.org, nyquis...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, pdf-r...@chromium.org, phshah...@chromium.org, rhalava...@chromium.org, rkgibso...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, tbarzi...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org, yhanada+...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5cf2941d7d235aa91117470fd6b466b6cfc86a5
Gerrit-Change-Number: 7928749
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Jun 2026 21:29:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jun 12, 2026, 9:50:33 PM (2 days ago) Jun 12
to Lei Zhang, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Hiroki Nakagawa, agriev...@chromium.org, alandin...@chromium.org, arc-review...@google.com, blink-...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, jackshira+wat...@google.com, kinuko+ser...@chromium.org, lizeb...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, media-cro...@chromium.org, net-r...@chromium.org, nyquis...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, pdf-r...@chromium.org, phshah...@chromium.org, rhalava...@chromium.org, rkgibso...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, tbarzi...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org, yhanada+...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review+1
Commit-Queue+2
Owners-Override+1

1 comment

Patchset-level comments
Daniel Cheng . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5cf2941d7d235aa91117470fd6b466b6cfc86a5
Gerrit-Change-Number: 7928749
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Sat, 13 Jun 2026 01:50:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 12, 2026, 10:32:18 PM (2 days ago) Jun 12
to Lei Zhang, Daniel Cheng, chromium...@chromium.org, devtools...@chromium.org, Hiroki Nakagawa, agriev...@chromium.org, alandin...@chromium.org, arc-review...@google.com, blink-...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, jackshira+wat...@google.com, kinuko+ser...@chromium.org, lizeb...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, media-cro...@chromium.org, net-r...@chromium.org, nyquis...@chromium.org, oshima...@chromium.org, pasko...@chromium.org, pdf-r...@chromium.org, phshah...@chromium.org, rhalava...@chromium.org, rkgibso...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, tbarzi...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org, yhanada+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Shorten base::OnceCallback<void(void)> to base::OnceClosure

Mass replace some verbose callback definitions with a simpler
equivalent. Do the same for base::RepeatingCallback<void(void)>.
Change-Id: Ic5cf2941d7d235aa91117470fd6b466b6cfc86a5
Auto-Submit: Lei Zhang <the...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1646359}
Files:
  • M ash/drag_drop/drag_drop_capture_delegate.h
  • M ash/drag_drop/drag_drop_tracker.h
  • M ash/system/time/calendar_view_unittest.cc
  • M ash/wm/tablet_mode/tablet_mode_controller.cc
  • M base/android/pre_freeze_background_memory_trimmer.h
  • M base/android/self_compaction_manager.cc
  • M chrome/browser/ash/arc/nearby_share/share_info_file_handler.h
  • M chrome/browser/ash/login/users/avatar/fake_user_image_file_selector.cc
  • M chrome/browser/ash/login/users/avatar/fake_user_image_file_selector.h
  • M chrome/browser/ash/login/users/avatar/user_image_file_selector.cc
  • M chrome/browser/ash/login/users/avatar/user_image_file_selector.h
  • M chrome/browser/chromeos/policy/dlp/data_transfer_dlp_controller.cc
  • M chrome/browser/devtools/devtools_browsertest.cc
  • M chrome/browser/offline_pages/offline_page_request_handler.cc
  • M chrome/browser/offline_pages/offline_page_request_handler.h
  • M chrome/browser/pdf/pdf_extension_download_test.cc
  • M chrome/browser/screen_ai/optical_character_recognizer_browsertest.cc
  • M chrome/browser/ui/views/desktop_capture/audio_capture_permission_checker.cc
  • M chrome/browser/ui/views/desktop_capture/audio_capture_permission_checker.h
  • M chrome/browser/ui/views/desktop_capture/audio_capture_permission_checker_mac.h
  • M chrome/browser/ui/views/desktop_capture/audio_capture_permission_checker_mac.mm
  • M chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
  • M chrome/browser/ui/views/desktop_capture/share_audio_view.cc
  • M chrome/browser/ui/views/desktop_capture/share_audio_view.h
  • M chrome/browser/ui/webui/ash/login/online_login_utils.h
  • M chrome/browser/ui/webui/signin/ash/inline_login_dialog_onboarding.cc
  • M chrome/browser/ui/webui/signin/ash/inline_login_dialog_onboarding.h
  • M chromeos/ash/components/osauth/public/auth_session_storage.h
  • M components/optimization_guide/core/delivery/prediction_model_fetch_timer.cc
  • M components/optimization_guide/core/delivery/prediction_model_fetch_timer.h
  • M content/browser/loader/keep_alive_url_loader.h
  • M gpu/command_buffer/client/internal/mappable_buffer_dxgi.cc
  • M gpu/command_buffer/client/internal/mappable_buffer_dxgi.h
  • M ios/chrome/browser/app_launcher/model/app_launcher_browser_agent.h
  • M ios/chrome/common/credential_provider/passkey_keychain_provider.h
  • M ios/web/net/cookies/wk_http_system_cookie_store.mm
  • M media/gpu/android/android_video_surface_chooser.h
  • M services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer_proto.h
  • M third_party/blink/renderer/modules/service_worker/web_embedded_worker_impl_test.cc
Change size: M
Delta: 39 files changed, 57 insertions(+), 65 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5cf2941d7d235aa91117470fd6b466b6cfc86a5
Gerrit-Change-Number: 7928749
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages