Extract a tree model from ObjectPropertiesSection [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Philip Pfaffe (Gerrit)

unread,
5:53 AM (12 hours ago) 5:53 AM
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko

Philip Pfaffe added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Philip Pfaffe . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Id46d90d4e13d941f4bba6cc0210448c4a19a0496
Gerrit-Change-Number: 7105742
Gerrit-PatchSet: 5
Gerrit-Owner: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Nov 2025 10:53:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
8:09 AM (10 hours ago) 8:09 AM
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe

Alex Rudenko voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Philip Pfaffe
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Id46d90d4e13d941f4bba6cc0210448c4a19a0496
Gerrit-Change-Number: 7105742
Gerrit-PatchSet: 5
Gerrit-Owner: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Nov 2025 13:09:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Philip Pfaffe (Gerrit)

unread,
8:09 AM (10 hours ago) 8:09 AM
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Philip Pfaffe voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Id46d90d4e13d941f4bba6cc0210448c4a19a0496
Gerrit-Change-Number: 7105742
Gerrit-PatchSet: 5
Gerrit-Owner: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Wed, 05 Nov 2025 13:09:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
8:11 AM (10 hours ago) 8:11 AM
to Philip Pfaffe, Alex Rudenko, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Extract a tree model from ObjectPropertiesSection

This will simplify migrating the view to lit.
Bug: 407752218
Change-Id: Id46d90d4e13d941f4bba6cc0210448c4a19a0496
Commit-Queue: Philip Pfaffe <pfa...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Files:
  • M front_end/panels/elements/PropertiesWidget.ts
  • M front_end/panels/event_listeners/EventListenersView.ts
  • M front_end/panels/linear_memory_inspector/LinearMemoryInspectorController.ts
  • M front_end/panels/network/RequestPayloadView.ts
  • M front_end/panels/network/RequestTimingView.ts
  • M front_end/panels/sources/ScopeChainSidebarPane.ts
  • M front_end/panels/sources/WatchExpressionsSidebarPane.ts
  • M front_end/ui/legacy/components/object_ui/CustomPreviewComponent.ts
  • M front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.test.ts
  • M front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts
Change size: L
Delta: 10 files changed, 490 insertions(+), 371 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alex Rudenko
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Id46d90d4e13d941f4bba6cc0210448c4a19a0496
Gerrit-Change-Number: 7105742
Gerrit-PatchSet: 6
Gerrit-Owner: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages