Add visual logging contexts to Application panel for comment anchoring [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Alex Rudenko (Gerrit)

unread,
Aug 18, 2026, 3:43:33 AMĀ (yesterday)Ā Aug 18
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org

Alex Rudenko voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I40281b7e268c043f44519457d340ea5dcd6aa744
Gerrit-Change-Number: 8257558
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Comment-Date: Tue, 18 Aug 2026 07:43:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
Aug 18, 2026, 4:51:54 AMĀ (yesterday)Ā Aug 18
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org

Alex Rudenko voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I40281b7e268c043f44519457d340ea5dcd6aa744
Gerrit-Change-Number: 8257558
Gerrit-PatchSet: 3
Gerrit-Comment-Date: Tue, 18 Aug 2026 08:51:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
5:42 AMĀ (4 hours ago)Ā 5:42 AM
to Yulun Zeng, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Yulun Zeng

Alex Rudenko voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yulun Zeng
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I40281b7e268c043f44519457d340ea5dcd6aa744
Gerrit-Change-Number: 8257558
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Yulun Zeng <yul...@chromium.org>
Gerrit-Attention: Yulun Zeng <yul...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 09:42:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yulun Zeng (Gerrit)

unread,
6:45 AMĀ (3 hours ago)Ā 6:45 AM
to Alex Rudenko, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alex Rudenko

Yulun Zeng voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I40281b7e268c043f44519457d340ea5dcd6aa744
Gerrit-Change-Number: 8257558
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Yulun Zeng <yul...@chromium.org>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 10:45:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
8:07 AMĀ (2 hours ago)Ā 8:07 AM
to Alex Rudenko, Yulun Zeng, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org

devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Add visual logging contexts to Application panel for comment anchoring

Add jslog contexts to StorageView ('storage-usage', 'usage-breakdown')
and ServiceWorkersView ('service-worker' section) to support
CommentAnchorResolver.

Bug: 542928776
Change-Id: I40281b7e268c043f44519457d340ea5dcd6aa744
TAG=agy
CONV=fdf66637-1abc-41a3-afd9-c4f8272a49c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8257558
Auto-Submit: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Yulun Zeng <yul...@chromium.org>
Commit-Queue: Yulun Zeng <yul...@chromium.org>
Files:
  • M front_end/panels/application/ServiceWorkersView.ts
  • M front_end/panels/application/StorageView.ts
  • M front_end/ui/visual_logging/KnownContextValues.ts
  • M test/e2e/helpers/application-helpers.ts
Change size: M
Delta: 4 files changed, 33 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Yulun Zeng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I40281b7e268c043f44519457d340ea5dcd6aa744
Gerrit-Change-Number: 8257558
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Yulun Zeng <yul...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages