[RPP Observations] Add Record buttons [devtools/devtools-frontend : main]
Adam Raine (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Paul Irish
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kim-Anh Tran (Gerrit)
Kim-Anh Tran added 2 comments![]( "Open in Gerrit")
Hi Adam! I'm this week's google material reviewer for DevTools. I've added a comment on the button usage 😊
${this.#toggleRecordButton}Can we use `<devtools-button>` here? We use the legacy buttons mostly in legacy code. I think in this case you'd need a devtools button with the variant `icon toggle`, see: https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/ui/components/buttons/Button.ts;l=27;drc=f2e8fca99a170300ef5360049dec910aefe15cfd.
These toggles have been introduced recently, but there are some usages of it, for example here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/ui/legacy/SearchableView.ts;l=235;drc=3e02eb658e84b46ebb53667e0a1cb52fe53b5f87
But you can find other usages of `<devtools-button>` within the context of `LitHtml`
This will require some work with the `ActionRegistry` since you don't have the helper, but I think this should work - let me know if there are unexpected problems!
Related details
- Adam Raine
- Paul Irish
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Raine (Gerrit)
Adam Raine added 1 comment![]( "Open in Gerrit")
${this.#toggleRecordButton}Can we use `<devtools-button>` here? We use the legacy buttons mostly in legacy code. I think in this case you'd need a devtools button with the variant `icon toggle`, see: https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/ui/components/buttons/Button.ts;l=27;drc=f2e8fca99a170300ef5360049dec910aefe15cfd.
These toggles have been introduced recently, but there are some usages of it, for example here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/ui/legacy/SearchableView.ts;l=235;drc=3e02eb658e84b46ebb53667e0a1cb52fe53b5f87But you can find other usages of `<devtools-button>` within the context of `LitHtml`
This will require some work with the `ActionRegistry` since you don't have the helper, but I think this should work - let me know if there are unexpected problems!
I was trying that before, but it required extra steps for the button to work with the action registry. I will give it another go, now that some other problems have been sorted out.
Paul, we may need to diverge from the mocks slightly for this but I will update the screenshots when done.
Related details
- Kim-Anh Tran
- Paul Irish
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Raine (Gerrit)
Adam Raine added 1 comment![]( "Open in Gerrit")
Adam RaineCan we use `<devtools-button>` here? We use the legacy buttons mostly in legacy code. I think in this case you'd need a devtools button with the variant `icon toggle`, see: https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/ui/components/buttons/Button.ts;l=27;drc=f2e8fca99a170300ef5360049dec910aefe15cfd.
These toggles have been introduced recently, but there are some usages of it, for example here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/ui/legacy/SearchableView.ts;l=235;drc=3e02eb658e84b46ebb53667e0a1cb52fe53b5f87But you can find other usages of `<devtools-button>` within the context of `LitHtml`
This will require some work with the `ActionRegistry` since you don't have the helper, but I think this should work - let me know if there are unexpected problems!
I was trying that before, but it required extra steps for the button to work with the action registry. I will give it another go, now that some other problems have been sorted out.
Paul, we may need to diverge from the mocks slightly for this but I will update the screenshots when done.
Never mind, if anything this is more compliant with our mocks.
Related details
- Kim-Anh Tran
- Paul Irish
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Paul Irish voted Code-Review+1![]( "Open in Gerrit")
- Adam Raine
- Kim-Anh Tran
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |