Portals: Remove <portal> specific code [devtools/devtools-frontend : main]

1 view
Skip to first unread message

Adithya Srinivasan (Gerrit)

unread,
Jun 27, 2024, 4:44:33 PM (3 days ago) Jun 27
to Tim Van der Lippe, Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Tim Van der Lippe

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
  • Tim Van der Lippe
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ibad93d572c77665aed5311de7210ede259e09fbb
Gerrit-Change-Number: 5660478
Gerrit-PatchSet: 3
Gerrit-Owner: Adithya Srinivasan <adit...@chromium.org>
Gerrit-Reviewer: Adithya Srinivasan <adit...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Tim Van der Lippe <tvande...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Attention: Tim Van der Lippe <tvande...@chromium.org>
Gerrit-Comment-Date: Thu, 27 Jun 2024 20:44:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
Jun 28, 2024, 2:01:42 AM (2 days ago) Jun 28
to Adithya Srinivasan, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Adithya Srinivasan

Alex Rudenko voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adithya Srinivasan
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ibad93d572c77665aed5311de7210ede259e09fbb
Gerrit-Change-Number: 5660478
Gerrit-PatchSet: 3
Gerrit-Owner: Adithya Srinivasan <adit...@chromium.org>
Gerrit-Reviewer: Adithya Srinivasan <adit...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Adithya Srinivasan <adit...@chromium.org>
Gerrit-Comment-Date: Fri, 28 Jun 2024 06:01:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Adithya Srinivasan (Gerrit)

unread,
Jun 28, 2024, 10:35:12 AM (2 days ago) Jun 28
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Adithya Srinivasan voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ibad93d572c77665aed5311de7210ede259e09fbb
Gerrit-Change-Number: 5660478
Gerrit-PatchSet: 3
Gerrit-Owner: Adithya Srinivasan <adit...@chromium.org>
Gerrit-Reviewer: Adithya Srinivasan <adit...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Fri, 28 Jun 2024 14:35:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
Jun 28, 2024, 11:11:32 AM (2 days ago) Jun 28
to Adithya Srinivasan, Alex Rudenko, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Portals: Remove <portal> specific code

Portals have been removed from the chromium codebase; this CL cleans
up frontend code that specifically handled it.
Bug: 40287334
Change-Id: Ibad93d572c77665aed5311de7210ede259e09fbb
Commit-Queue: Adithya Srinivasan <adit...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Files:
  • M config/gni/devtools_grd_files.gni
  • M front_end/core/sdk/ChildTargetManager.ts
  • M front_end/core/sdk/DOMModel.ts
  • M front_end/core/sdk/ResourceTreeModel.ts
  • M front_end/models/issues_manager/BUILD.gn
  • M front_end/models/issues_manager/GenericIssue.test.ts
  • M front_end/models/issues_manager/GenericIssue.ts
  • D front_end/models/issues_manager/descriptions/genericCrossOriginPortalPostMessageError.md
  • M front_end/panels/elements/ElementsTreeOutline.ts
Change size: S
Delta: 9 files changed, 7 insertions(+), 37 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alex Rudenko
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ibad93d572c77665aed5311de7210ede259e09fbb
Gerrit-Change-Number: 5660478
Gerrit-PatchSet: 4
Gerrit-Owner: Adithya Srinivasan <adit...@chromium.org>
Gerrit-Reviewer: Adithya Srinivasan <adit...@chromium.org>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages