Add column to indicate whether network request is ad-related [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Andrew Paseltiner (Gerrit)
Sep 23, 2025, 12:01:51 PM (yesterday) Sep 23
to devtools-rev...@chromium.org
Andrew Paseltiner abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
Sep 23, 2025, 12:03:44 PM (yesterday) Sep 23
to Josh Karlin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Josh Karlin
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Josh Karlin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Josh Karlin (Gerrit)
Sep 23, 2025, 2:01:14 PM (yesterday) Sep 23
to Andrew Paseltiner, Josh Karlin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Andrew Paseltiner
Josh Karlin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Josh Karlin . resolved
lgtm but don't have any powers in this repo.
Related details
Attention is currently required from:
- Andrew Paseltiner
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adriana Ixba (Gerrit)
1:16 PM (8 hours ago) 1:16 PM
to Andrew Paseltiner, Josh Karlin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Andrew Paseltiner
Adriana Ixba voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adriana Ixba
| Code-Review | +1 |
1 comment
Patchset-level comments
Adriana Ixba . resolved
lgtm
Related details
Attention is currently required from:
- Andrew Paseltiner
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
1:17 PM (8 hours ago) 1:17 PM
to Adriana Ixba, Josh Karlin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Andrew Paseltiner voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
2:41 PM (6 hours ago) 2:41 PM
to Andrew Paseltiner, Adriana Ixba, Josh Karlin, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add column to indicate whether network request is ad-related
This is a boolean column that is hidden by default.
Bug: 443993633
Change-Id: Ib9dcbdf08eceb06a195eaf58b588a99900132fc0
Reviewed-by: Adriana Ixba <ai...@chromium.org>
Commit-Queue: Andrew Paseltiner <apase...@chromium.org>
Files:
- M front_end/core/sdk/NetworkManager.ts
- M front_end/core/sdk/NetworkRequest.ts
- M front_end/panels/network/NetworkDataGridNode.ts
- M front_end/panels/network/NetworkLogViewColumns.ts
- M front_end/ui/visual_logging/KnownContextValues.ts
Change size: S
Delta: 5 files changed, 43 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Adriana Ixba
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages