Replace uses of node_module/../tsc with third_party/../typescript.py [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Nikolay Vitkov (Gerrit)
Aug 18, 2026, 10:06:08 AM (24 hours ago) Aug 18
to Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org, devtools-revie...@chromium.org
Attention needed from Philip Pfaffe
Nikolay Vitkov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Aug 18, 2026, 10:06:54 AM (24 hours ago) Aug 18
to Simon Zünd, Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org, devtools-revie...@chromium.org
Attention needed from Philip Pfaffe and Simon Zünd
Nikolay Vitkov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Philip Pfaffe
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
Aug 18, 2026, 11:59:32 PM (10 hours ago) Aug 18
to Nikolay Vitkov, Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org, devtools-revie...@chromium.org
Attention needed from Nikolay Vitkov and Philip Pfaffe
Simon Zünd voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Nikolay Vitkov
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
3:26 AM (6 hours ago) 3:26 AM
to Nikolay Vitkov, Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org, devtools-revie...@chromium.org
Attention needed from Nikolay Vitkov
Philip Pfaffe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Pfaffe
| Code-Review | +1 |
1 comment
File extensions/cxx_debugging/CMakeLists.txt
Line 24, Patchset 1 (Latest):
find_program(PYTHON3_COMPILER python3 REQUIRED)Philip Pfaffe . unresolved
find_package is the canonical way to do this
Related details
Attention is currently required from:
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
4:39 AM (5 hours ago) 4:39 AM
to Philip Pfaffe, Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org, devtools-revie...@chromium.org
Nikolay Vitkov added 1 comment![]( "Open in Gerrit")
File extensions/cxx_debugging/CMakeLists.txt
Line 24, Patchset 1 (Latest):
find_program(PYTHON3_COMPILER python3 REQUIRED)Philip Pfaffe . resolved
find_package is the canonical way to do this
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
4:58 AM (5 hours ago) 4:58 AM
to Philip Pfaffe, Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org, devtools-revie...@chromium.org
Nikolay Vitkov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
5:10 AM (5 hours ago) 5:10 AM
to Nikolay Vitkov, Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org, devtools-revie...@chromium.org
Attention needed from Nikolay Vitkov and Philip Pfaffe
Simon Zünd voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Nikolay Vitkov
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
5:28 AM (4 hours ago) 5:28 AM
to Simon Zünd, Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org, devtools-revie...@chromium.org
Attention needed from Philip Pfaffe
Nikolay Vitkov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
6:20 AM (3 hours ago) 6:20 AM
to Nikolay Vitkov, Simon Zünd, Philip Pfaffe, devtools-rev...@chromium.org, devtools-revie...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Replace uses of node_module/../tsc with third_party/../typescript.py
We should use the new TSGO compiler as there are small changes bettween
the versions, also it's more performant.
The change includes:
- CXX extension
- Typechecking the custom EsLint rules
- Rebuilding the web-vitals package
Bug: none
Change-Id: Iab7cdcb162af13cffdfd3b5a5c317a1d69b48e91
Reviewed-by: Simon Zünd <szu...@chromium.org>
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Files:
- M extensions/cxx_debugging/CMakeLists.txt
- M extensions/cxx_debugging/e2e/runner.py
- M front_end/third_party/web-vitals/rebuild.sh
- M scripts/build/typescript/typescript.gni
- M scripts/devtools_paths.js
- M scripts/test/run_lint_check.mjs
- M third_party/typescript/typescript.py
Change size: M
Delta: 7 files changed, 30 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Simon Zünd
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages