Enable VariationsHttpHeader browser tests on Android [chromium/src : main]

0 views
Skip to first unread message

Alexei Svitkine (Gerrit)

unread,
Jan 16, 2026, 11:17:10 AM (4 days ago) Jan 16
to Andrzej Fiedukowicz, Ramon Cano Aparicio, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, net-r...@chromium.org, fuzzin...@chromium.org, chrome-intell...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, asvitki...@chromium.org, chromiumme...@microsoft.com
Attention needed from Andrzej Fiedukowicz and Ramon Cano Aparicio

Alexei Svitkine voted and added 4 comments

Votes added by Alexei Svitkine

Code-Review+1

4 comments

Patchset-level comments
File-level comment, Patchset 45 (Latest):
Alexei Svitkine . resolved

Nice! LGTM

File chrome/browser/metrics/variations/variations_http_headers_browsertest.cc
Line 88, Patchset 45 (Latest):
Alexei Svitkine . unresolved

Nit: No empty line here.

Line 91, Patchset 45 (Latest):#endif
Alexei Svitkine . unresolved

Nit: Empty line after this.

Line 203, Patchset 45 (Latest):#endif
Alexei Svitkine . unresolved

Nit: Add comment referencing the #if condition.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrzej Fiedukowicz
  • Ramon Cano Aparicio
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I33d794a2ac2f339f67d2dbab4b65a292f08144ba
Gerrit-Change-Number: 7450923
Gerrit-PatchSet: 45
Gerrit-Owner: Andrzej Fiedukowicz <af...@google.com>
Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Andrzej Fiedukowicz <af...@google.com>
Gerrit-Reviewer: Ramon Cano Aparicio <rcanoa...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Ramon Cano Aparicio <rcanoa...@google.com>
Gerrit-Attention: Andrzej Fiedukowicz <af...@google.com>
Gerrit-Comment-Date: Fri, 16 Jan 2026 16:17:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrzej Fiedukowicz (Gerrit)

unread,
Jan 19, 2026, 6:04:55 AM (yesterday) Jan 19
to Alexei Svitkine, Ramon Cano Aparicio, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, net-r...@chromium.org, fuzzin...@chromium.org, chrome-intell...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, asvitki...@chromium.org, chromiumme...@microsoft.com
Attention needed from Alexei Svitkine and Ramon Cano Aparicio

Andrzej Fiedukowicz added 3 comments

File chrome/browser/metrics/variations/variations_http_headers_browsertest.cc
Line 88, Patchset 45:
Alexei Svitkine . resolved

Nit: No empty line here.

Andrzej Fiedukowicz

Done

Line 91, Patchset 45:#endif
Alexei Svitkine . resolved

Nit: Empty line after this.

Andrzej Fiedukowicz

Done

Line 203, Patchset 45:#endif
Alexei Svitkine . resolved

Nit: Add comment referencing the #if condition.

Andrzej Fiedukowicz

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Alexei Svitkine
  • Ramon Cano Aparicio
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I33d794a2ac2f339f67d2dbab4b65a292f08144ba
    Gerrit-Change-Number: 7450923
    Gerrit-PatchSet: 46
    Gerrit-Owner: Andrzej Fiedukowicz <af...@google.com>
    Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Reviewer: Andrzej Fiedukowicz <af...@google.com>
    Gerrit-Reviewer: Ramon Cano Aparicio <rcanoa...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Attention: Ramon Cano Aparicio <rcanoa...@google.com>
    Gerrit-Comment-Date: Mon, 19 Jan 2026 11:04:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Alexei Svitkine <asvi...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alexei Svitkine (Gerrit)

    unread,
    Jan 19, 2026, 5:38:21 PM (13 hours ago) Jan 19
    to Andrzej Fiedukowicz, Ramon Cano Aparicio, Peter Beverloo, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, net-r...@chromium.org, fuzzin...@chromium.org, chrome-intell...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, asvitki...@chromium.org, chromiumme...@microsoft.com
    Attention needed from Andrzej Fiedukowicz and Ramon Cano Aparicio

    Alexei Svitkine voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrzej Fiedukowicz
    • Ramon Cano Aparicio
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I33d794a2ac2f339f67d2dbab4b65a292f08144ba
      Gerrit-Change-Number: 7450923
      Gerrit-PatchSet: 49
      Gerrit-Owner: Andrzej Fiedukowicz <af...@google.com>
      Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
      Gerrit-Reviewer: Andrzej Fiedukowicz <af...@google.com>
      Gerrit-Reviewer: Ramon Cano Aparicio <rcanoa...@google.com>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-Attention: Ramon Cano Aparicio <rcanoa...@google.com>
      Gerrit-Attention: Andrzej Fiedukowicz <af...@google.com>
      Gerrit-Comment-Date: Mon, 19 Jan 2026 22:38:11 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages