[GreenDev] Change 3 widgets functions into 1 [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alina Varkki (Gerrit)
Dec 10, 2025, 9:22:36 AMDec 10
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Alina Varkki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
Dec 11, 2025, 9:13:02 AMDec 11
to Alina Varkki, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alina Varkki
Jack Franklin added 1 comment![]( "Open in Gerrit")
File front_end/models/ai_assistance/agents/PerformanceAgent.ts
Line 1258, Patchset 2 (Latest):
type: {
type: Host.AidaClient.ParametersTypes.STRING,
description: 'The type of the widget to add.',
nullable: false,Jack Franklin . unresolved
The fact that we don't have a union type available here concerns me; is the LLM good at understanding what types are available? Can we at least add them to the description here?
Related details
Attention is currently required from:
- Alina Varkki
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alina Varkki (Gerrit)
1:51 PM (10 hours ago) 1:51 PM
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Alina Varkki added 1 comment![]( "Open in Gerrit")
File front_end/models/ai_assistance/agents/PerformanceAgent.ts
Line 1258, Patchset 2:
type: {
type: Host.AidaClient.ParametersTypes.STRING,
description: 'The type of the widget to add.',
nullable: false,Jack Franklin . resolved
The fact that we don't have a union type available here concerns me; is the LLM good at understanding what types are available? Can we at least add them to the description here?
Alina Varkki
`this.declareFunction` has `type` which only accepts `type: 'insight' | 'network-request' | 'flamechart'. I assume it does the job?
I will add those in the description as well, shouldn't hurt.
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages