Fix flakiness in CPUThrottlingManager tests [devtools/devtools-frontend : main]

0 views

Skip to first unread message

Samiya Caur (Gerrit)

unread,

10:57 AM (5 hours ago) 10:57 AM

to Alex Rudenko, devtools-rev...@chromium.org

Attention needed from Alex Rudenko

Samiya Caur voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

11:10 AM (5 hours ago) 11:10 AM

to Samiya Caur, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org

Attention needed from Samiya Caur

Alex Rudenko voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Samiya Caur

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

11:39 AM (4 hours ago) 11:39 AM

to Samiya Caur, Alex Rudenko, devtools-rev...@chromium.org

devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

Fix flakiness in CPUThrottlingManager tests

Flakiness was reproduced on changing the order in which tests are executed - pointing to some resource leak between test runs. This gets fixed on using describeWithMockConnection

Bug: 509476756

Change-Id: Ied059eb65c8c0adc7855f22540f4ace8a1520adc

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7806140

Reviewed-by: Alex Rudenko <alexr...@chromium.org>

Auto-Submit: Samiya Caur <sam...@chromium.org>

Commit-Queue: Samiya Caur <sam...@chromium.org>

Commit-Queue: Alex Rudenko <alexr...@chromium.org>

Files:

M front_end/core/sdk/CPUThrottlingManager.test.ts

Change size: XS

Delta: 1 file changed, 3 insertions(+), 2 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alex Rudenko

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages