Add test for PDF Viewer DevTools availability. [chromium/src : main]

0 views
Skip to first unread message

Michał Kaczmarczyk (Gerrit)

unread,
Jun 30, 2026, 7:39:34 AM (4 days ago) Jun 30
to Damian Rogowski, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Damian Rogowski

Michał Kaczmarczyk voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Damian Rogowski
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I386d26b89d9bb05770a20addc26c4357f41b1b44
Gerrit-Change-Number: 8023669
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
Gerrit-Reviewer: Damian Rogowski <dr...@google.com>
Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
Gerrit-Attention: Damian Rogowski <dr...@google.com>
Gerrit-Comment-Date: Tue, 30 Jun 2026 11:39:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Damian Rogowski (Gerrit)

unread,
Jun 30, 2026, 8:12:04 AM (4 days ago) Jun 30
to Michał Kaczmarczyk, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Michał Kaczmarczyk

Damian Rogowski added 1 comment

File chrome/browser/devtools/devtools_availability_checker_unittest.cc
Line 279, Patchset 1 (Latest): PdfViewerAllowedWhenDevtoolsAllowed) {
Damian Rogowski . unresolved

Ik was thinking more about the default value here, than allowed.

Open in Gerrit

Related details

Attention is currently required from:
  • Michał Kaczmarczyk
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I386d26b89d9bb05770a20addc26c4357f41b1b44
    Gerrit-Change-Number: 8023669
    Gerrit-PatchSet: 1
    Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
    Gerrit-Reviewer: Damian Rogowski <dr...@google.com>
    Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
    Gerrit-Attention: Michał Kaczmarczyk <mickacz...@google.com>
    Gerrit-Comment-Date: Tue, 30 Jun 2026 12:11:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Michał Kaczmarczyk (Gerrit)

    unread,
    Jul 3, 2026, 7:24:13 AM (yesterday) Jul 3
    to Damian Rogowski, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
    Attention needed from Damian Rogowski

    Michał Kaczmarczyk added 1 comment

    File chrome/browser/devtools/devtools_availability_checker_unittest.cc
    Line 279, Patchset 1: PdfViewerAllowedWhenDevtoolsAllowed) {
    Damian Rogowski . resolved

    Ik was thinking more about the default value here, than allowed.

    Michał Kaczmarczyk

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Damian Rogowski
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I386d26b89d9bb05770a20addc26c4357f41b1b44
      Gerrit-Change-Number: 8023669
      Gerrit-PatchSet: 9
      Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
      Gerrit-Reviewer: Damian Rogowski <dr...@google.com>
      Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
      Gerrit-Attention: Damian Rogowski <dr...@google.com>
      Gerrit-Comment-Date: Fri, 03 Jul 2026 11:23:56 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Damian Rogowski <dr...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michał Kaczmarczyk (Gerrit)

      unread,
      Jul 3, 2026, 7:57:56 AM (yesterday) Jul 3
      to Simon Kurek, Danil Somsikov, Damian Rogowski, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
      Attention needed from Damian Rogowski and Danil Somsikov

      Michał Kaczmarczyk voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Damian Rogowski
      • Danil Somsikov
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I386d26b89d9bb05770a20addc26c4357f41b1b44
      Gerrit-Change-Number: 8023669
      Gerrit-PatchSet: 12
      Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
      Gerrit-Reviewer: Damian Rogowski <dr...@google.com>
      Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
      Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
      Gerrit-CC: Simon Kurek <szymo...@google.com>
      Gerrit-Attention: Danil Somsikov <d...@chromium.org>
      Gerrit-Comment-Date: Fri, 03 Jul 2026 11:57:40 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michał Kaczmarczyk (Gerrit)

      unread,
      Jul 3, 2026, 10:00:11 AM (yesterday) Jul 3
      to Simon Kurek, Danil Somsikov, Damian Rogowski, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
      Attention needed from Damian Rogowski and Danil Somsikov

      Michał Kaczmarczyk voted Auto-Submit+1

      Auto-Submit+1
      Gerrit-Comment-Date: Fri, 03 Jul 2026 13:59:54 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Danil Somsikov (Gerrit)

      unread,
      Jul 3, 2026, 10:44:00 AM (yesterday) Jul 3
      to Michał Kaczmarczyk, Simon Kurek, Damian Rogowski, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
      Attention needed from Damian Rogowski and Michał Kaczmarczyk

      Danil Somsikov voted and added 2 comments

      Votes added by Danil Somsikov

      Code-Review+1

      2 comments

      File chrome/browser/devtools/devtools_browsertest.cc
      Line 2948, Patchset 12 (Latest): if (!server->Started()) {
      Danil Somsikov . unresolved
      NIT: You can likely replace this entire block with just:
      ```cpp
        ASSERT_TRUE(server->Start());
      ```
      `InProcessBrowserTest` already configures the default `embedded_test_server()` to serve files from `chrome/test/data`, and `Start()` encapsulates the initialization and listening steps.
      Line 2978, Patchset 12 (Latest):
      Danil Somsikov . unresolved

      NIT: Extra blank line.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Damian Rogowski
      • Michał Kaczmarczyk
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I386d26b89d9bb05770a20addc26c4357f41b1b44
      Gerrit-Change-Number: 8023669
      Gerrit-PatchSet: 12
      Gerrit-Owner: Michał Kaczmarczyk <mickacz...@google.com>
      Gerrit-Reviewer: Damian Rogowski <dr...@google.com>
      Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
      Gerrit-Reviewer: Michał Kaczmarczyk <mickacz...@google.com>
      Gerrit-CC: Simon Kurek <szymo...@google.com>
      Gerrit-Attention: Damian Rogowski <dr...@google.com>
      Gerrit-Attention: Michał Kaczmarczyk <mickacz...@google.com>
      Gerrit-Comment-Date: Fri, 03 Jul 2026 14:43:43 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages