Paul Irish (Gerrit)

unread,

Sep 12, 2025, 5:43:19 PMSep 12

to Devtools-frontend LUCI CQ, Connor Clark, devtools-rev...@chromium.org

Attention needed from Connor Clark

Paul Irish voted and added 1 comment

Votes added by Paul Irish

Commit-Queue

+1

1 comment

Commit Message

Line 7, Patchset 1:RPP: Reland hiding irrelvant buttons in standalone usages

Connor Clark . resolved

Please fix this WARNING reported by Spellchecker: "irrelvant" is a possible misspelling of "irrelevant".
To bypass Spellchecker, ...
"irrelvant" is a possible misspelling of "irrelevant".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER

Paul Irish

Done

Open in Gerrit

Related details

Attention is currently required from:

Connor Clark

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Connor Clark (Gerrit)

unread,

Sep 12, 2025, 5:46:37 PMSep 12

to Paul Irish, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Paul Irish

Connor Clark voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Paul Irish

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Paul Irish (Gerrit)

unread,

Sep 12, 2025, 6:02:55 PMSep 12

to Connor Clark, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Paul Irish voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,

Sep 12, 2025, 6:13:06 PMSep 12

to Paul Irish, Connor Clark, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:

RPP: Reland hiding irrelevant buttons in standalone usages

With a revised signal for `canRecord` we now hide the RPP Record button,
and others, in standalone scenarios.

Bug: 432043754

Change-Id: I7d470474ec0e481a2e257f2b40519e47b2b999bf

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6943527

Reviewed-by: Connor Clark <cja...@chromium.org>

Commit-Queue: Paul Irish <paul...@chromium.org>

Files:

M front_end/core/host/InspectorFrontendHost.ts
M front_end/core/sdk/Connections.ts
M front_end/core/sdk/TargetManager.ts
M front_end/models/live-metrics/LiveMetrics.ts
M front_end/panels/timeline/TimelinePanel.ts
M front_end/panels/timeline/TimingsTrackAppender.ts
M front_end/panels/timeline/components/LiveMetricsView.ts
M front_end/ui/visual_logging/KnownContextValues.ts

Change size: M

Delta: 8 files changed, 69 insertions(+), 20 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Connor Clark

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Simon Zünd (Gerrit)

unread,

5:25 AM (7 hours ago) 5:25 AM

to Paul Irish, Devtools-frontend LUCI CQ, Connor Clark, devtools-rev...@chromium.org

Attention needed from Paul Irish

Simon Zünd added 1 comment

File front_end/core/host/InspectorFrontendHost.ts

Line 501, Patchset 3 (Latest):

   *  | tab URL: `devtools://…?ws=…`                | **Hosted**     | `devtools://devtools/bundled/devtools_app.html?ws=localhost:9228/...`         |
   *  | tab URL: `devtools://…` but no connection   | **Hosted**     | `devtools://devtools/bundled/devtools_app.html`                               |

Simon Zünd . unresolved

This is incorrect. Any tab where we open DevTools via the scheme `devtools://` is **NOT Hosted** and runs with C++ bindings. You can test this by navigating an arbitrary tab to "devtools://devtools/bundled/devtools_app.html" and then open DevTools on that tab:

You can see the `DevToolsAPI` object available on `globalThis`.
Evaling `InspectorFrontendHost.isHostedMode()` returns `false`.

Open in Gerrit

Related details

Attention is currently required from:

Paul Irish

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

RPP: Reland hiding irrelevant buttons in standalone usages [devtools/devtools-frontend : main]

Paul Irish (Gerrit)

Paul Irish voted and added 1 comment

Votes added by Paul Irish

1 comment

Related details

Connor Clark (Gerrit)

Connor Clark voted Code-Review+1

Related details

Paul Irish (Gerrit)

Paul Irish voted Commit-Queue+2

Related details

Devtools-frontend LUCI CQ (Gerrit)

Devtools-frontend LUCI CQ submitted the change

Change information

Simon Zünd (Gerrit)

Simon Zünd added 1 comment

Related details