Remove FontSrcLocalMatching flag [chromium/src : main]
0 views
Skip to first unread message
Dominik Röttsches (Gerrit)
Apr 13, 2026, 10:59:37 AM (4 days ago) Apr 13
to Kent Tamura, Nico Weber, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, creis...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura and Nico Weber
Dominik Röttsches voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Röttsches
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 11 (Latest):
Dominik Röttsches . resolved
thakis@, if this LGTY, could I also ask for an owners-override?
Related details
Attention is currently required from:
- Kent Tamura
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Apr 13, 2026, 6:40:32 PM (4 days ago) Apr 13
to Dominik Röttsches, Kent Tamura, Koji Ishii, Nico Weber, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, creis...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, zol...@webkit.org
Attention needed from Dominik Röttsches, Koji Ishii and Nico Weber
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Code-Review | +1 |
Dominik Röttsches . resolved
thakis@, if this LGTY, could I also ask for an owners-override?
Kent Tamura
I can set Owners-Override+1 only for third_party/blink/public/ changes.
Related details
Attention is currently required from:
- Dominik Röttsches
- Koji Ishii
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
Apr 14, 2026, 8:59:56 AM (3 days ago) Apr 14
to Kent Tamura, Koji Ishii, Nico Weber, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, creis...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura, Koji Ishii and Nico Weber
Dominik Röttsches added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 14 (Latest):
Dominik Röttsches . resolved
Kent, could you renew your +1, I had to do one more change to make the android bots happy.
Related details
Attention is currently required from:
- Kent Tamura
- Koji Ishii
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Apr 14, 2026, 10:56:48 AM (3 days ago) Apr 14
to Dominik Röttsches, Nico Weber, Kent Tamura, Koji Ishii, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, creis...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, zol...@webkit.org
Attention needed from Dominik Röttsches, Kent Tamura and Koji Ishii
Nico Weber voted and added 3 comments![]( "Open in Gerrit")
Votes added by Nico Weber
| Code-Review | +1 |
3 comments
Patchset-level comments
Nico Weber . resolved
Apologies for missing this!
File content/test/test_blink_web_unit_test_support.cc
Line 93, Patchset 14 (Latest):
blink::WebRuntimeFeatures::EnableAndroidDownloadableFontsMatching(false);Nico Weber . resolved
(why is this moving up? seems unrelated?)
File third_party/blink/renderer/platform/fonts/plain_text_node_test.cc
Line 55, Patchset 14 (Latest):
feature_list_.InitAndDisableFeature(features::kGMSCoreEmoji);Nico Weber . unresolved
Why this? Also related to mojo and local()?
Related details
Attention is currently required from:
- Dominik Röttsches
- Kent Tamura
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
Apr 14, 2026, 11:09:38 AM (3 days ago) Apr 14
to Nico Weber, Kent Tamura, Koji Ishii, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, creis...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura, Koji Ishii and Nico Weber
Dominik Röttsches added 2 comments![]( "Open in Gerrit")
File content/test/test_blink_web_unit_test_support.cc
Line 93, Patchset 14 (Latest):
blink::WebRuntimeFeatures::EnableAndroidDownloadableFontsMatching(false);Nico Weber . resolved
(why is this moving up? seems unrelated?)
Dominik Röttsches
Moving this up makes it run before `blink::Platform::InitializeBlink()` which makes sure that platform code does not send the mojo IPC for local() / and GMSCore font matching.
File third_party/blink/renderer/platform/fonts/plain_text_node_test.cc
Line 55, Patchset 14 (Latest):
feature_list_.InitAndDisableFeature(features::kGMSCoreEmoji);Nico Weber . unresolved
Why this? Also related to mojo and local()?
Dominik Röttsches
Yes, one of the tests in this set requires an emoji, on Android that triggers trying to request the emoji font from the browser via IPC, because that's where the most up-to-date emoji font is. Disabling this here avoids making the IPC call on Android.
Related details
Attention is currently required from:
- Kent Tamura
- Koji Ishii
- Nico Weber
Nico Weber (Gerrit)
Apr 14, 2026, 11:41:32 AM (3 days ago) Apr 14
to Dominik Röttsches, Nico Weber, Kent Tamura, Koji Ishii, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, creis...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, zol...@webkit.org
Attention needed from Dominik Röttsches, Kent Tamura and Koji Ishii
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Weber
| Owners-Override | +1 |
1 comment
File third_party/blink/renderer/platform/fonts/plain_text_node_test.cc
Line 55, Patchset 14 (Latest):
feature_list_.InitAndDisableFeature(features::kGMSCoreEmoji);Nico Weber . resolved
Dominik RöttschesWhy this? Also related to mojo and local()?
Yes, one of the tests in this set requires an emoji, on Android that triggers trying to request the emoji font from the browser via IPC, because that's where the most up-to-date emoji font is. Disabling this here avoids making the IPC call on Android.
Attention is currently required from:
- Dominik Röttsches
- Kent Tamura
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
Apr 14, 2026, 12:31:10 PM (3 days ago) Apr 14
to Nico Weber, Kent Tamura, Koji Ishii, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, creis...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura and Koji Ishii
Dominik Röttsches voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Kent Tamura
- Koji Ishii
chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Apr 14, 2026, 12:35:57 PM (3 days ago) Apr 14
to Dominik Röttsches, Nico Weber, Kent Tamura, Koji Ishii, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, creis...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, zol...@webkit.org
chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove FontSrcLocalMatching flag
This has been default enabled since M77.
Disable FontFaceCacheTest.FontUniqueNameMatchAvailable on platforms
where the mojo connection to the browser process is required to perform
local() font name lookups.
Previously this test may have worked (with the flag off),
because src: local() matching was incorrectly performing a family
name match.
Disable GMSCoreEmoji flag in PlainTextNode tests, as falling
back to the GMS core emoji font triggers and local() font
matching IPC that is not available in tests.
Existing tests continue to cover local() font matching in:
content/browser/font_unique_name_lookup/font_unique_name_browsertest.cc
Bug: 40569816
Change-Id: I60149e042a1e92a9cc99a1d77932cf078781290d
Owners-Override: Nico Weber <tha...@chromium.org>
Commit-Queue: Dominik Röttsches <dr...@chromium.org>
Reviewed-by: Nico Weber <tha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1614539}
Files:
- M content/browser/browser_main_loop.cc
- M content/browser/font_unique_name_lookup/font_unique_name_browsertest.cc
- M content/browser/font_unique_name_lookup/font_unique_name_lookup_service.cc
- M content/browser/renderer_host/dwrite_font_proxy_impl_win.cc
- M content/browser/renderer_host/render_process_host_impl_receiver_bindings.cc
- M content/child/runtime_features.cc
- M content/common/features.cc
- M content/common/features.h
- M content/test/test_blink_web_unit_test_support.cc
- M third_party/blink/renderer/core/inspector/inspector_css_agent_test.cc
- M third_party/blink/renderer/core/layout/layout_text_test.cc
- M third_party/blink/renderer/platform/fonts/android/font_unique_name_lookup_android.cc
- M third_party/blink/renderer/platform/fonts/font_cache_test.cc
- M third_party/blink/renderer/platform/fonts/mac/font_cache_mac.mm
- M third_party/blink/renderer/platform/fonts/plain_text_node_test.cc
- M third_party/blink/renderer/platform/fonts/skia/font_cache_skia.cc
- M third_party/blink/renderer/platform/fonts/win/font_cache_skia_win.cc
- M third_party/blink/renderer/platform/fonts/win/font_unique_name_lookup_win.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M tools/metrics/histograms/enums.xml
Change size: M
Delta: 20 files changed, 56 insertions(+), 69 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nico Weber
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages